new packages gflags and glog
cover new packages gflags and glog
This patch set adds two new packages gflags and glog.
Rahul Bedarkar (2):
gflags: new package
glog: new package
package/Config.in | 2 ++ package/gflags/Config.in | 13 +++++++++++++ package/gflags/gflags.hash | 2 ++ package/gflags/gflags.mk | 17 +++++++++++++++++ package/glog/Config.in | 11 +++++++++++ package/glog/glog.hash | 2 ++ package/glog/glog.mk | 17 +++++++++++++++++ 7 files changed, 64 insertions(+) create mode 100644 package/gflags/Config.in create mode 100644 package/gflags/gflags.hash create mode 100644 package/gflags/gflags.mk create mode 100644 package/glog/Config.in create mode 100644 package/glog/glog.hash create mode 100644 package/glog/glog.mk
Signature · 1 line
1.9.1
PATCH 1/2 gflags: new package
--- package/Config.in | 1 + package/gflags/Config.in | 13 +++++++++++++ package/gflags/gflags.hash | 2 ++ package/gflags/gflags.mk | 17 +++++++++++++++++ 4 files changed, 33 insertions(+) create mode 100644 package/gflags/Config.in create mode 100644 package/gflags/gflags.hash create mode 100644 package/gflags/gflags.mk
package/Config.in +1 -0
@@ -1013,6 +1013,7 @@ menu "Other" source "package/elfutils/Config.in" source "package/fftw/Config.in" source "package/flann/Config.in" + source "package/gflags/Config.in" source "package/glibmm/Config.in" source "package/glm/Config.in" source "package/gmp/Config.in"
package/gflags/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_GFLAGS + bool "gflags" + depends on BR2_INSTALL_LIBSTDCPP + help + The gflags package contains a C++ library that implements + commandline flags processing. It includes built-in support for + standard types such as string and the ability to define flags + in the source file in which they are used. + + https://github.com/gflags/gflags + +comment "gflags needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP
package/gflags/gflags.hash new file +2 -0
@@ -0,0 +1,2 @@ +# No hash for v2.1.2, comes from the github-helper: +none xxx gflags-v2.1.2.tar.gz
package/gflags/gflags.mk new file +17 -0
@@ -0,0 +1,17 @@ +################################################################################ +# +# gflags +# +################################################################################ + +GFLAGS_VERSION = v2.1.2 +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION)) +GFLAGS_INSTALL_STAGING = YES +GFLAGS_LICENSE = BSD-3c +GFLAGS_LICENSE_FILES = COPYING.txt + +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n) +GFLAGS_CONF_OPTS = -DBUILD_gflags_LIB=OFF +endif + +$(eval $(cmake-package))
Signature · 1 line
1.9.1
PATCH 1/2 gflags: new package
Dear Rahul Bedarkar,
Thanks for this contribution. A few comments below.
package/gflags/gflags.hash line 2
Quoted 8 lines · Rahul Bedarkar
package/gflags/gflags.hash new file +2
-0@@ -0,0 +1,2 @@ +# No hash for v2.1.2, comes from the github-helper: +none xxx gflags-v2.1.2.tar.gz
I believe in this case, we generally do not provide a hash file at all. Though maybe in the future we will want to have a hash file for *all* packages. Yann, what is our policy on this?
package/gflags/gflags.hash
Quoted 7 lines
package/gflags/gflags.hash new file +7
-0+GFLAGS_VERSION = v2.1.2 +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION)) +GFLAGS_INSTALL_STAGING = YES +GFLAGS_LICENSE = BSD-3c +GFLAGS_LICENSE_FILES = COPYING.txt + +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n)
This should be:
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 gflags: new package
Thomas, Rahul, All,
On 2015-06-09 09:01 +0200, Thomas Petazzoni spake thusly:
Quoted 14 lines · Rahul Bedarkar
package/gflags/gflags.hash line 2
Quoted 9 lines
package/gflags/gflags.hash new file +2
-0@@ -0,0 +1,2 @@ +# No hash for v2.1.2, comes from the github-helper: +none xxx gflags-v2.1.2.tar.gzI believe in this case, we generally do not provide a hash file at all. Though maybe in the future we will want to have a hash file for *all* packages. Yann, what is our policy on this?
Hmm. Ideally, I think we want a .hash file for all packages, so that can eventually be a hard error when one is missing.
However, I can see that can be cumbersome to add a .hash file to just say 'talk to my hand, I have no hash'. Especially as we're not enforcing it so far...
But I was planning on working on .hash sometime this summer to add all those missing at the time, so we have all .hash files for the lat release of the year. I'm pretty happy to see so many hashes being added in the meantime! ;-)
So, to answer the specific question: I think that is good to have a none-hash file; and to top it off, it's nicely commented. :-)
Regards,
Yann E. MORIN.
Quoted 19 lines
package/gflags/gflags.hash
Quoted 7 lines
package/gflags/gflags.hash new file +7
-0+GFLAGS_VERSION = v2.1.2 +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION)) +GFLAGS_INSTALL_STAGING = YES +GFLAGS_LICENSE = BSD-3c +GFLAGS_LICENSE_FILES = COPYING.txt + +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n)This should be:
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 2/2 glog: new package
In reply to Rahul Bedarkar--- package/Config.in | 1 + package/glog/Config.in | 11 +++++++++++ package/glog/glog.hash | 2 ++ package/glog/glog.mk | 17 +++++++++++++++++ 4 files changed, 31 insertions(+) create mode 100644 package/glog/Config.in create mode 100644 package/glog/glog.hash create mode 100644 package/glog/glog.mk
package/Config.in +1 -0
@@ -892,6 +892,7 @@ menu "JSON/XML" endmenu menu "Logging" + source "package/glog/Config.in" source "package/liblog4c-localtime/Config.in" source "package/liblogging/Config.in" source "package/log4cplus/Config.in"
package/glog/Config.in new file +11 -0
@@ -0,0 +1,11 @@ +config BR2_PACKAGE_GLOG + bool "glog" + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_HAS_THREADS + help + C++ implementation of the Google logging module + + https://github.com/google/glog + +comment "glog needs a toolchain w/ C++, threads" + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
package/glog/glog.hash new file +2 -0
@@ -0,0 +1,2 @@ +# No hash for v0.3.4, comes from the github-helper: +none xxx glog-v0.3.4.tar.gz
package/glog/glog.mk new file +17 -0
@@ -0,0 +1,17 @@ +################################################################################ +# +# glog +# +################################################################################ + +GLOG_VERSION = v0.3.4 +GLOG_SITE = $(call github,google,glog,$(GLOG_VERSION)) +GLOG_INSTALL_STAGING = YES +GLOG_LICENSE = BSD-3c +GLOG_LICENSE_FILES = COPYING + +ifeq ($(BR2_PACKAGE_GFLAGS),y) +GLOG_DEPENDENCIES = gflags +endif + +$(eval $(autotools-package))
Signature · 1 line
1.9.1