Skip to contentSkip to conversation

ASoC: fsl: add an error check

PATCH Applied Dan Carpenter 3 participants 4 messages Jun 10, 2015

Subsystems (5)
Sound Arm i.MX and Layerscape Kernel janitors ASoC +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ASoC: fsl: add an error check

My static checker complains that:

	sound/soc/fsl/imx-wm8962.c:196 imx_wm8962_probe() warn:
	we tested 'ret' before and it was 'false'

The intent was that we use "ret" to check imx_audmux_v2_configure_port().

Fixes 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver')
Signed-off-by Dan Carpenter <[email protected]>

---
I assume checking for an error here will not change anything but I have not tested this patch.

sound/soc/fsl/imx-wm8962.c +1 -1
index cd146d4..b38b98c 100644
@@ -190,7 +190,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "audmux internal port setup failed\n");
 		return ret;
 	}
-	imx_audmux_v2_configure_port(ext_port,
+	ret = imx_audmux_v2_configure_port(ext_port,
 			IMX_AUDMUX_V2_PTCR_SYN,
 			IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
 	if (ret) {
reviewer
#1 lore raw
Quoted 9 lines · Dan Carpenter

My static checker complains that:

	sound/soc/fsl/imx-wm8962.c:196 imx_wm8962_probe() warn:
	we tested 'ret' before and it was 'false'

The intent was that we use "ret" to check imx_audmux_v2_configure_port().

Fixes 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver')
Signed-off-by Dan Carpenter <[email protected]>

Could you please use an subject like:
ASoC: imx-wm8962: Add a missing error check
(Since it only applies to this file)

Otherwise, Acked-by: Nicolin Chen <[email protected]>

Thank you indeed for the fix
Nicolin

Quoted 17 lines

---
I assume checking for an error here will not change anything but I have not tested this patch.

sound/soc/fsl/imx-wm8962.c +1 -1
index cd146d4..b38b98c 100644
@@ -190,7 +190,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "audmux internal port setup failed\n");
 		return ret;
 	}
-	imx_audmux_v2_configure_port(ext_port,
+	ret = imx_audmux_v2_configure_port(ext_port,
 			IMX_AUDMUX_V2_PTCR_SYN,
 			IMX_AUDMUX_V2_PDCR_RXDSEL(int_port));
 	if (ret) {
author
#2 lore raw
Quoted 4 lines

Could you please use an subject like:
ASoC: imx-wm8962: Add a missing error check
(Since it only applies to this file)

I have been meaning to say something about this.

This is sort of a recurrent problem for me because I'm often the first person to touch a driver after it's added. I just copied your patch prefix from 8de2ae2a7f1f ('ASoC: fsl: add imx-wm8962 machine driver'). Really you should also have used "ASoC: imx-wm8962:" as well.

This is the third new driver today where I have faced this situation.

regards,
dan carpenter

maintainer Applied
#3 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

My static checker complains that:

	sound/soc/fsl/imx-wm8962.c:196 imx_wm8962_probe() warn:
	we tested 'ret' before and it was 'false'

Applied, thanks.