Skip to contentSkip to conversation

drm/virtio: checking for NULL instead of IS_ERR

PATCH In review Dan Carpenter 2 participants 3 messages Jun 10, 2015 – Jun 11, 2015

Subsystems (5)
DRM drivers DRM misc Kernel janitors virtio core +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm/virtio: checking for NULL instead of IS_ERR

virtio_gpu_alloc_object() returns an error pointer, it never returns NULL.

Fixes dc5698e80cf7 ('Add virtio gpu driver.')
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/virtio/virtgpu_fb.c +2 -2
index 25bf333..df198d9 100644
@@ -299,8 +299,8 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper,
 
 	size = mode_cmd.pitches[0] * mode_cmd.height;
 	obj = virtio_gpu_alloc_object(dev, size, false, true);
-	if (!obj)
-		return -ENOMEM;
+	if (IS_ERR(obj))
+		return PTR_ERR(obj);
 
 	virtio_gpu_resource_id_get(vgdev, &resid);
 	virtio_gpu_cmd_create_resource(vgdev, resid, format,