Skip to contentSkip to conversation

openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

PATCH New Jerzy Grzegorek 4 participants 5 messages Jun 10, 2015 – Jun 11, 2015

lore
Share & tools
lore

Jerzy Grzegorek

author
#0 lore raw

PATCH 1/1 openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

Signed-off-by Jerzy Grzegorek <[email protected]>
---
 package/openvmtools/openvmtools.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/openvmtools/openvmtools.mk +3 -2
index ef6544a..92ecd36 100644
@@ -4,9 +4,10 @@
 #
 ################################################################################
 
-OPENVMTOOLS_VERSION = 9.10.0-2476743
+OPENVMTOOLS_VERSION_MAJOR = 9.10.0
+OPENVMTOOLS_VERSION = $(OPENVMTOOLS_VERSION_MAJOR)-2476743
 OPENVMTOOLS_SOURCE = open-vm-tools-$(OPENVMTOOLS_VERSION).tar.gz
-OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-9.10.0
+OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-$(OPENVMTOOLS_VERSION_MAJOR)
 OPENVMTOOLS_LICENSE = LGPLv2.1
 OPENVMTOOLS_LICENSE_FILES = COPYING
 # Autoreconf needed or config/missing will run configure again at buildtime
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

Hi,

the official openvmtools repo is also moving to GitHub, maybe we should modify the whole download process?
I thought I'll wait for the next release before moving from sourceforge to github, but we could also do it now.
The back draw it that hash files can not be used with Github currently (AFAIK).

Regards,
Karoly
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150610/237526b5/attachment.html>

author
#2 lore raw

PATCH 1/1 openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

Hi K?roly,

Quoted 6 lines

Hi,

the official openvmtools repo is also moving to GitHub, maybe we should modify the whole download process?
I thought I'll wait for the next release before moving from sourceforge to github, but we could also do it now.

Thanks for the review.
Feel free to submit such a patch.

Quoted 2 lines

The back draw it that hash files can not be used with Github currently (AFAIK).

Let's wait and see what others think.

Regards,
Jerzy

Quoted 3 lines

Regards,
Karoly

#3 lore raw

PATCH 1/1 openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

In reply to Jerzy Grzegorek
Quoted 1 line · Jerzy Grzegorek
Signed-off-by Jerzy Grzegorek <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Note that the proposed move to github is a good idea, but a separate patch anyway.

Regards,
Arnout

Quoted 22 lines
---
 package/openvmtools/openvmtools.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/openvmtools/openvmtools.mk +3 -2
index ef6544a..92ecd36 100644
@@ -4,9 +4,10 @@
 #
 ################################################################################
 
-OPENVMTOOLS_VERSION = 9.10.0-2476743
+OPENVMTOOLS_VERSION_MAJOR = 9.10.0
+OPENVMTOOLS_VERSION = $(OPENVMTOOLS_VERSION_MAJOR)-2476743
 OPENVMTOOLS_SOURCE = open-vm-tools-$(OPENVMTOOLS_VERSION).tar.gz
-OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-9.10.0
+OPENVMTOOLS_SITE = http://downloads.sourceforge.net/project/open-vm-tools/open-vm-tools/stable-$(OPENVMTOOLS_VERSION_MAJOR)
 OPENVMTOOLS_LICENSE = LGPLv2.1
 OPENVMTOOLS_LICENSE_FILES = COPYING
 # Autoreconf needed or config/missing will run configure again at buildtime
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Applied
#4 lore raw

PATCH 1/1 openvmtools: add OPENVMTOOLS_VERSION_MAJOR variable

In reply to Jerzy Grzegorek

Dear Jerzy Grzegorek,

Quoted 4 lines · Jerzy Grzegorek
Signed-off-by Jerzy Grzegorek <[email protected]>
---
 package/openvmtools/openvmtools.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com