Skip to contentSkip to conversation

kyua: new package and dependencies

PATCH New Sebastien Bourdelin 3 participants 12 messages Jun 11, 2015 – Jun 13, 2015

lore
Share & tools
lore
#0 lore raw

v5 cover kyua: new package and dependencies

This patchset introduces the Kyua testing framework with its dependencies.

https://github.com/jmmv/kyua

Sebastien Bourdelin (3):
atf: new package
lutok: new package
kyua: new package

 package/Config.in       |  3 +++
 package/atf/Config.in   | 11 +++++++++++
 package/atf/atf.hash    |  2 ++
 package/atf/atf.mk      | 21 +++++++++++++++++++++
 package/kyua/Config.in  | 18 ++++++++++++++++++
 package/kyua/kyua.hash  |  2 ++
 package/kyua/kyua.mk    | 26 ++++++++++++++++++++++++++
 package/lutok/Config.in | 11 +++++++++++
 package/lutok/lutok.mk  | 19 +++++++++++++++++++
 9 files changed, 113 insertions(+)
 create mode 100644 package/atf/Config.in
 create mode 100644 package/atf/atf.hash
 create mode 100644 package/atf/atf.mk
 create mode 100644 package/kyua/Config.in
 create mode 100644 package/kyua/kyua.hash
 create mode 100644 package/kyua/kyua.mk
 create mode 100644 package/lutok/Config.in
 create mode 100644 package/lutok/lutok.mk
Signature · 1 line
2.4.0
#1 lore raw

PATCH v5 1/3 atf: new package

ATF, or Automated Testing Framework, is a collection of libraries to write test programs in C, C++ and POSIX shell.

https://github.com/jmmv/atf

---
Changes v4 -> v5:
suggested by Thomas Petazzoni <[email protected]>:
suggested by Arnout Vandecapelle <[email protected]>:
- do not install the precompiled tests.

Changes v3 -> v4:
- rebase

suggested by Arnout Vandecapelle <[email protected]>:
- changes the license to BSD-2c, BSD-3c

suggested by Thomas Petazzoni <[email protected]>:
- moves the package to Librairies/Other

Changes v2 -> v3:
- rebase

suggested by Arnout Vandecapelle <[email protected]>:
- adds comment to explain the need to use AUTORECONF

Changes v1 -> v2:
suggested by Arnout Vandecapelle <[email protected]>:
- bump the version
- uses the release archive instead of the github automatic one
- updates the hash
- removes host-pkgconf from dependencies
- changes the license
- reworks the comment around CONF_ENV to avoid error

---
 package/Config.in     |  1 +
 package/atf/Config.in | 11 +++++++++++
 package/atf/atf.hash  |  2 ++
 package/atf/atf.mk    | 24 ++++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/atf/Config.in
 create mode 100644 package/atf/atf.hash
 create mode 100644 package/atf/atf.mk
package/Config.in +1 -0
index a17901f..d111a82 100644
@@ -1005,6 +1005,7 @@ menu "Other"
 	source "package/apr-util/Config.in"
 	source "package/argp-standalone/Config.in"
 	source "package/armadillo/Config.in"
+	source "package/atf/Config.in"
 	source "package/bdwgc/Config.in"
 	source "package/boost/Config.in"
 	source "package/clapack/Config.in"
package/atf/Config.in new file +11 -0
new file mode 100644
index 0000000..59712ab
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_ATF
+	bool "atf"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  ATF, or Automated Testing Framework, is a collection of
+	  libraries to write test programs in C, C++ and POSIX shell.
+
+	  https://github.com/jmmv/atf
+
+comment "atf needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/atf/atf.hash new file +2 -0
new file mode 100644
index 0000000..78cd3c6
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 92bc64180135eea8fe84c91c9f894e678767764f6dbc8482021d4dde09857505 atf-0.21.tar.gz
package/atf/atf.mk new file +24 -0
new file mode 100644
index 0000000..ed2080e
@@ -0,0 +1,24 @@
+################################################################################
+#
+# atf
+#
+################################################################################
+
+ATF_VERSION = 0.21
+ATF_SITE = https://github.com/jmmv/atf/releases/download/atf-$(ATF_VERSION)
+ATF_INSTALL_STAGING = YES
+ATF_LICENSE = BSD-2c, BSD-3c
+ATF_LICENSE_FILES = COPYING
+# Ships a beta libtool version hence our patch doesn't apply.
+ATF_AUTORECONF = YES
+# Do not install precompiled tests.
+ATF_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) install-exec
+
+# ATF_SHELL defaults to the host's bash
+ATF_CONF_ENV = \
+	kyua_cv_getopt_plus=yes \
+	kyua_cv_attribute_noreturn=yes \
+	kyua_cv_getcwd_works=yes \
+	ATF_SHELL=/bin/sh
+
+$(eval $(autotools-package))
Signature · 1 line
2.4.0
#2 lore raw

PATCH v5 1/3 atf: new package

Dear Sebastien Bourdelin,

Quoted 11 lines · Sebastien Bourdelin

ATF, or Automated Testing Framework, is a collection of libraries to write test programs in C, C++ and POSIX shell.

https://github.com/jmmv/atf

---
Changes v4 -> v5:
suggested by Thomas Petazzoni <[email protected]>:
suggested by Arnout Vandecapelle <[email protected]>:
- do not install the precompiled tests.

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH v5 2/3 lutok: new package

In reply to Sebastien Bourdelin

Lutok is a lightweight C++ API library for Lua.

https://github.com/jmmv/lutok

---
Changes v4 -> v5:
suggested by Arnout Vandecapelle <[email protected]>:
- force the --without-atf option to not build the example tests.
- puts the dependencies &&-ed in Config.in on 2 lines
- adds comment to explain the need of dlopen

Changes v3 -> v4:
- rebase

Changes v2 -> v3:
- rebase

suggested by Arnout Vandecapelle <[email protected]>:
- reworks comment in the Config.in for the required lua dependencies

Changes v1 -> v2:
suggested by Arnout Vandecapelle <[email protected]>:
- reworks lua dependencies, doesn't work with luajit
- adds comment in the Config.in for the required lua dependencies
- uses the release archive instead of the github automatic one
- updates the hash
- removes the useless AUTORECONF option
- adds optional dependency on atf
- don't generate the doxygen doc
- changes the license

---
 package/Config.in        |  1 +
 package/lutok/Config.in  | 13 +++++++++++++
 package/lutok/lutok.hash |  2 ++
 package/lutok/lutok.mk   | 20 ++++++++++++++++++++
 4 files changed, 36 insertions(+)
 create mode 100644 package/lutok/Config.in
 create mode 100644 package/lutok/lutok.hash
 create mode 100644 package/lutok/lutok.mk
package/Config.in +1 -0
index d111a82..b006211 100644
@@ -456,6 +456,7 @@ endif
 	source "package/lua/Config.in"
 	source "package/luainterpreter/Config.in"
 	source "package/luajit/Config.in"
+	source "package/lutok/Config.in"
 if BR2_PACKAGE_HAS_LUAINTERPRETER && !BR2_STATIC_LIBS
 # lua modules are dynamically loaded, so not available on static builds
 menu "Lua libraries/modules"
package/lutok/Config.in new file +13 -0
new file mode 100644
index 0000000..d6c87cf
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LUTOK
+	bool "lutok"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
+	depends on !BR2_PACKAGE_LUAJIT
+	help
+	  Lutok is a lightweight C++ API library for Lua.
+
+	  https://github.com/jmmv/lutok
+
+comment "lutok needs a toolchain w/ C++ and full Lua"
+	depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
+	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
package/lutok/lutok.hash new file +2 -0
new file mode 100644
index 0000000..0ec8988
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 2cec51efa0c8d65ace8b21eaa08384b77abc5087b46e785f78de1c21fb754cd5 lutok-0.4.tar.gz
package/lutok/lutok.mk new file +20 -0
new file mode 100644
index 0000000..0b1f214
@@ -0,0 +1,20 @@
+################################################################################
+#
+# lutok
+#
+################################################################################
+
+LUTOK_VERSION = 0.4
+LUTOK_SITE = https://github.com/jmmv/lutok/releases/download/lutok-$(LUTOK_VERSION)
+LUTOK_INSTALL_STAGING = YES
+LUTOK_DEPENDENCIES = host-pkgconf lua
+LUTOK_CONF_OPTS = --without-doxygen --without-atf
+LUTOK_LICENSE = BSD-3c
+LUTOK_LICENSE_FILES = COPYING
+
+# liblua uses dlopen when dynamically linked
+ifneq ($(BR2_STATIC_LIBS),y)
+LUTOK_MAKE_OPTS = LIBS=-ldl
+endif
+
+$(eval $(autotools-package))
Signature · 1 line
2.4.0
#4 lore raw

PATCH v5 2/3 lutok: new package

Dear Sebastien Bourdelin,

package/lutok/lutok.mk line 11

Quoted 5 lines · Sebastien Bourdelin
package/lutok/lutok.mk new file +5 -0
+LUTOK_VERSION = 0.4
+LUTOK_SITE = https://github.com/jmmv/lutok/releases/download/lutok-$(LUTOK_VERSION)
+LUTOK_INSTALL_STAGING = YES
+LUTOK_DEPENDENCIES = host-pkgconf lua
+LUTOK_CONF_OPTS = --without-doxygen --without-atf

Both the lutok and kyua packages after --without-atf ? Why so ? You add the atf package as the first patch, and then it isn't used in follow-up patches ?

package/lutok/lutok.mk line 16

Quoted 2 lines
package/lutok/lutok.mk new file +2 -0
+# liblua uses dlopen when dynamically linked
+ifneq ($(BR2_STATIC_LIBS),y)

ifeq ($(BR2_STATIC_LIBS),)

maybe?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH v5 2/3 lutok: new package

Hello,

Quoted 3 lines · Thomas Petazzoni

Both the lutok and kyua packages after --without-atf ? Why so ? You add the atf package as the first patch, and then it isn't used in follow-up patches ?

Ok, --without-atf is not about ATF support, but about build ATF-based tests. I've added a comment to explain this.

Quoted 4 lines

package/lutok/lutok.mk line 16

Quoted 2 lines
package/lutok/lutok.mk new file +2 -0
+# liblua uses dlopen when dynamically linked
+ifneq ($(BR2_STATIC_LIBS),y)

ifeq ($(BR2_STATIC_LIBS),)

Actually, I was able to build without adding -ldl, so I'm not sure why it is needed. We'll see what the autobuilders have to say, unless you have more details about the specific configuration that was causing problems.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH v5 2/3 lutok: new package

Quoted 16 lines · Thomas Petazzoni

Hello,

Quoted 3 lines · Thomas Petazzoni

Both the lutok and kyua packages after --without-atf ? Why so ? You add the atf package as the first patch, and then it isn't used in follow-up patches ?

Ok, --without-atf is not about ATF support, but about build ATF-based tests. I've added a comment to explain this.

Quoted 4 lines

package/lutok/lutok.mk line 16

Quoted 2 lines
package/lutok/lutok.mk new file +2 -0
+# liblua uses dlopen when dynamically linked
+ifneq ($(BR2_STATIC_LIBS),y)

ifeq ($(BR2_STATIC_LIBS),)

Quoted 4 lines

Actually, I was able to build without adding -ldl, so I'm not sure why it is needed. We'll see what the autobuilders have to say, unless you have more details about the specific configuration that was causing problems.

If you build --with-atf, then the linking of the tests will fail, because some
of them link with liblua and lua's .pc file forgets to add -ldl.

See haserl.mk.

Since now we build --without-atf, this package doesn't link anything anymore so
the -ldl is no longer needed - at least not here.

Regards,
Arnout

Quoted 5 lines

Thanks,

Thomas

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#7 lore raw

PATCH v5 2/3 lutok: new package

In reply to Sebastien Bourdelin

Dear Sebastien Bourdelin,

Quoted 11 lines · Sebastien Bourdelin

Lutok is a lightweight C++ API library for Lua.

https://github.com/jmmv/lutok

---
Changes v4 -> v5:
suggested by Arnout Vandecapelle <[email protected]>:
- force the --without-atf option to not build the example tests.
- puts the dependencies &&-ed in Config.in on 2 lines
- adds comment to explain the need of dlopen

Applied, thanks, after doing the tweaks that I highlighted already:

[Thomas:
- move lutok inclusion in package/Config.in after including the Lua external modules
- add a comment explaining why we are passing --without-atf
- remove the logic around -ldl, it seems to build just fine without it.]

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#8 lore raw

PATCH v5 3/3 kyua: new package

In reply to Sebastien Bourdelin

Kyua is a testing framework for infrastructure software, originally designed to equip BSD-based operating systems with a test suite. This means that Kyua is lightweight and simple, and that Kyua integrates well with various build systems and continuous integration frameworks.

https://github.com/jmmv/kyua

---
Changes v4 -> v5:
suggested by Arnout Vandecapelle <[email protected]>:
- force the --without-atf option to not build the example tests.
- puts the dependencies &&-ed in Config.in on 2 lines
- change the comment for dependencies in Config.in

Changes v3 -> v4:
- rebase

Changes v2 -> v3:
- rebase

Changes v1 -> v2:
- don't generate the doxygen doc

suggested by Arnout Vandecapelle <[email protected]>:
- reworks dependencies in Config.in
- uses the uploaded archive instead of the github automatic one
- changes the hash
- removes the useless AUTORECONF
- changes the license
- fixes a mistake with POST_INSTALL_HOOK

---
 package/Config.in      |  1 +
 package/kyua/Config.in | 20 ++++++++++++++++++++
 package/kyua/kyua.hash |  2 ++
 package/kyua/kyua.mk   | 27 +++++++++++++++++++++++++++
 4 files changed, 50 insertions(+)
 create mode 100644 package/kyua/Config.in
 create mode 100644 package/kyua/kyua.hash
 create mode 100644 package/kyua/kyua.mk
package/Config.in +1 -0
index b006211..1d7b7bc 100644
@@ -72,6 +72,7 @@ menu "Debugging, profiling and benchmark"
 	source "package/kexec/Config.in"
 	source "package/kexec-lite/Config.in"
 	source "package/ktap/Config.in"
+	source "package/kyua/Config.in"
 	source "package/latencytop/Config.in"
 	source "package/lmbench/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
package/kyua/Config.in new file +20 -0
new file mode 100644
index 0000000..e1bcd48
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_KYUA
+	bool "kyua"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_LUAINTERPRETER # lutok
+	depends on !BR2_PACKAGE_LUAJIT # lutok
+	select BR2_PACKAGE_ATF
+	select BR2_PACKAGE_LUTOK
+	select BR2_PACKAGE_SQLITE
+	help
+	  Kyua is a testing framework for infrastructure software,
+	  originally designed to equip BSD-based operating systems
+	  with a test suite. This means that Kyua is lightweight
+	  and simple, and that Kyua integrates well with various build
+	  systems and continuous integration frameworks.
+
+	  https://github.com/jmmv/kyua
+
+comment "kyua needs a toolchain w/ C++ and full Lua"
+	depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
+	depends on BR2_PACKAGE_HAS_LUAINTERPRETER
package/kyua/kyua.hash new file +2 -0
new file mode 100644
index 0000000..938e556
@@ -0,0 +1,2 @@
+# Locally Calculted
+sha256 2b8b64a458b642df75086eeb73e8073d105b8d9cff04c9b1a905b68bc8502560 kyua-0.11.tar.gz
package/kyua/kyua.mk new file +27 -0
new file mode 100644
index 0000000..c75a09f
@@ -0,0 +1,27 @@
+################################################################################
+#
+# kyua
+#
+################################################################################
+
+KYUA_VERSION = 0.11
+KYUA_SITE = https://github.com/jmmv/kyua/releases/download/kyua-$(KYUA_VERSION)
+KYUA_DEPENDENCIES = host-pkgconf atf lutok sqlite
+KYUA_CONF_OPTS = --without-doxygen --without-atf
+KYUA_LICENSE = BSD-3c
+KYUA_LICENSE_FILES = COPYING
+KYUA_CONF_ENV = \
+	kyua_cv_attribute_noreturn=yes \
+	kyua_cv_getcwd_dyn=yes \
+	kyua_cv_lchmod_works=no \
+	kyua_cv_getopt_gnu=yes \
+	kyua_cv_getopt_optind_reset_value=0 \
+	kyua_cv_signals_lastno=15
+
+define KYUA_INSTALL_CONFIG
+	$(INSTALL) -D -m 644 $(@D)/examples/kyua.conf $(TARGET_DIR)/etc/kyua/kyua.conf
+endef
+
+KYUA_POST_INSTALL_HOOKS += KYUA_INSTALL_CONFIG
+
+$(eval $(autotools-package))
Signature · 1 line
2.4.0
#9 lore raw

PATCH v5 3/3 kyua: new package

Dear Sebastien Bourdelin,

Quoted 7 lines · Sebastien Bourdelin

Kyua is a testing framework for infrastructure software, originally designed to equip BSD-based operating systems with a test suite. This means that Kyua is lightweight and simple, and that Kyua integrates well with various build systems and continuous integration frameworks.

https://github.com/jmmv/kyua

Quoted 7 lines

---
Changes v4 -> v5:
suggested by Arnout Vandecapelle <[email protected]>:
- force the --without-atf option to not build the example tests.
- puts the dependencies &&-ed in Config.in on 2 lines
- change the comment for dependencies in Config.in

Applied, thanks. I fixed a minor typo in the hash file.

However, there are a few things that might be worth looking into for follow-up patches:

1/ Some installed stuff is probably unneeded:

./usr/share/kyua/store
./usr/share/kyua/store/schema_v3.sql
./usr/share/kyua/store/migrate_v2_v3.sql
./usr/share/kyua/store/migrate_v1_v2.sql
./usr/share/kyua/misc
./usr/share/kyua/misc/report.css
./usr/share/kyua/misc/test_result.html
./usr/share/kyua/misc/index.html
./usr/share/kyua/misc/context.html
./usr/share/kyua/examples
./usr/share/kyua/examples/kyua.conf
./usr/share/kyua/examples/Kyuafile.top

2/ The CFLAGS/LDFLAGS handling seems to go crazy with zillions of duplicates of the same flags. At build time, one can see:

/home/thomas/projets/buildroot/output/host/usr/bin/arm-linux-g++ -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroo
t/usr/in
clude -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/
host/usr
/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/i
nclude
-I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/us
r/arm-bu
ildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include
-I/home
/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-b
uildroot
-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/hom
e/thomas
/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot
-linux-u
clibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclib
cgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/proj
ets/buil
droot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -I/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -D_FORTIFY_SOURCE=2 -Wall -Wcast-qual -Wextra -Wpointer-arith -Wredundant-decls -Wreturn-type -Wshadow -Wsign-compare -Wswitch -Wwrite-strings -DNDEBUG -Wabi -Wctor-dtor-privacy -Wno-deprecated -Wno-non-template-friend -Wno-pmf-conversions -Wnon-virtual-dtor -Woverloaded-virtual -Wreorder -Wsign-promo -Wsynth -o kyua kyua-main.o libcli.a libdrivers.a libengine.a libstore.a libmodel.a libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas
/projets
/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thoma
s/projet
s/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libmodel.a libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -
L/home/t
homas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3
libstor
e.a libmodel.a libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclib
cgnueabi
/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libmodel.a libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot
-linux-u
clibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroo
t-linux-
uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libengine.a libstore.a libmodel.a libutils.a -L/home/thomas/pro
jets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/th
omas/pro
jets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libmodel.a libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok
-L/hom
e/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok

    -L/ho

me/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3 libutils.a -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llua -lm -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -llutok -L/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib -lsqlite3
/home/thomas/projets/buildroot/output/host/usr/bin/arm-linux-gcc -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -D_FORTIFY_SOURCE=2 -Wall -Wcast-qual -Wextra -Wpointer-arith -Wredundant-decls -Wreturn-type -Wshadow -Wsign-compare -Wswitch -Wwrite-strings -DNDEBUG -Wmissing-prototypes -Wno-traditional -o testers/kyua-tap-tester testers/tap_main.o testers/libtap_tester.a testers/libtester.a

Yes, this is the full command line!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#10 lore raw

PATCH v5 3/3 kyua: new package

Quoted 23 lines · Thomas Petazzoni

Dear Sebastien Bourdelin,

Quoted 7 lines · Sebastien Bourdelin

Kyua is a testing framework for infrastructure software, originally designed to equip BSD-based operating systems with a test suite. This means that Kyua is lightweight and simple, and that Kyua integrates well with various build systems and continuous integration frameworks.

https://github.com/jmmv/kyua

Quoted 7 lines

---
Changes v4 -> v5:
suggested by Arnout Vandecapelle <[email protected]>:
- force the --without-atf option to not build the example tests.
- puts the dependencies &&-ed in Config.in on 2 lines
- change the comment for dependencies in Config.in

Applied, thanks. I fixed a minor typo in the hash file.

However, there are a few things that might be worth looking into for follow-up patches:

Quoted 6 lines

1/ Some installed stuff is probably unneeded:

./usr/share/kyua/store
./usr/share/kyua/store/schema_v3.sql
./usr/share/kyua/store/migrate_v2_v3.sql
./usr/share/kyua/store/migrate_v1_v2.sql

I think these are needed to be able to create the report database. Ah, but the
migrate scripts may indeed be redundant.

Quoted 5 lines

./usr/share/kyua/misc
./usr/share/kyua/misc/report.css
./usr/share/kyua/misc/test_result.html
./usr/share/kyua/misc/index.html
./usr/share/kyua/misc/context.html

I believe these are needed to be able to generate html reports.

Quoted 3 lines

./usr/share/kyua/examples
./usr/share/kyua/examples/kyua.conf
./usr/share/kyua/examples/Kyuafile.top

These could indeed be removed.

Quoted 3 lines

2/ The CFLAGS/LDFLAGS handling seems to go crazy with zillions of duplicates of the same flags. At build time, one can see:

Yeah, but that's an upstream problem, no? They include LUTOK_CFLAGS several
times. Correcting that would be a feature patch.

Regards,
Arnout

[snip ridiculously long command line]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#11 lore raw

PATCH v5 3/3 kyua: new package

Dear Arnout Vandecappelle,

Quoted 10 lines · Arnout Vandecappelle
Quoted 6 lines

1/ Some installed stuff is probably unneeded:

./usr/share/kyua/store
./usr/share/kyua/store/schema_v3.sql
./usr/share/kyua/store/migrate_v2_v3.sql
./usr/share/kyua/store/migrate_v1_v2.sql

I think these are needed to be able to create the report database. Ah, but the
migrate scripts may indeed be redundant.

Quoted 7 lines
Quoted 5 lines

./usr/share/kyua/misc
./usr/share/kyua/misc/report.css
./usr/share/kyua/misc/test_result.html
./usr/share/kyua/misc/index.html
./usr/share/kyua/misc/context.html

I believe these are needed to be able to generate html reports.

Ok.

Quoted 5 lines
Quoted 2 lines

2/ The CFLAGS/LDFLAGS handling seems to go crazy with zillions of duplicates of the same flags. At build time, one can see:

Yeah, but that's an upstream problem, no? They include LUTOK_CFLAGS several
times. Correcting that would be a feature patch.

Absolutely, and that's why I applied the patch anyway. My comment was mainly a suggestion to report the problem upstream, so that it hopefully gets fixed in a later version. For now, it is not a big problem.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com