Staging: sm750fb: fix checkpatch.pl indentation warnings
PATCH 1/1 Staging: sm750fb: fix checkpatch.pl indentation warnings
From: Niranjan Dighe <[email protected]>
This patch fixes indentation issues by replacing spaces by tabs at the start of line
drivers/staging/sm750fb/ddk750_dvi.c +36 -38
@@ -1,4 +1,4 @@ -#define USE_DVICHIP +#define USE_DVICHIP #ifdef USE_DVICHIP #include "ddk750_help.h" #include "ddk750_reg.h"
@@ -12,44 +12,43 @@ static dvi_ctrl_device_t g_dcftSupportedDviController[] { #ifdef DVI_CTRL_SII164 - { - .pfnInit = sii164InitChip, - .pfnGetVendorId = sii164GetVendorID, - .pfnGetDeviceId = sii164GetDeviceID, + { + .pfnInit = sii164InitChip, + .pfnGetVendorId = sii164GetVendorID, + .pfnGetDeviceId = sii164GetDeviceID, #ifdef SII164_FULL_FUNCTIONS - .pfnResetChip = sii164ResetChip, - .pfnGetChipString = sii164GetChipString, - .pfnSetPower = sii164SetPower, - .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection, - .pfnIsConnected = sii164IsConnected, - .pfnCheckInterrupt = sii164CheckInterrupt, - .pfnClearInterrupt = sii164ClearInterrupt, + .pfnResetChip = sii164ResetChip, + .pfnGetChipString = sii164GetChipString, + .pfnSetPower = sii164SetPower, + .pfnEnableHotPlugDetection = sii164EnableHotPlugDetection, + .pfnIsConnected = sii164IsConnected, + .pfnCheckInterrupt = sii164CheckInterrupt, + .pfnClearInterrupt = sii164ClearInterrupt, #endif - }, + }, #endif }; - int dviInit( - unsigned char edgeSelect, - unsigned char busSelect, - unsigned char dualEdgeClkSelect, - unsigned char hsyncEnable, - unsigned char vsyncEnable, - unsigned char deskewEnable, - unsigned char deskewSetting, - unsigned char continuousSyncEnable, - unsigned char pllFilterEnable, - unsigned char pllFilterValue - ) + unsigned char edgeSelect, + unsigned char busSelect, + unsigned char dualEdgeClkSelect, + unsigned char hsyncEnable, + unsigned char vsyncEnable, + unsigned char deskewEnable, + unsigned char deskewSetting, + unsigned char continuousSyncEnable, + unsigned char pllFilterEnable, + unsigned char pllFilterValue +) { dvi_ctrl_device_t *pCurrentDviCtrl; pCurrentDviCtrl = g_dcftSupportedDviController; - if(pCurrentDviCtrl->pfnInit != NULL) + if (pCurrentDviCtrl->pfnInit != NULL) { return pCurrentDviCtrl->pfnInit(edgeSelect, busSelect, dualEdgeClkSelect, hsyncEnable, - vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, - pllFilterEnable, pllFilterValue); + vsyncEnable, deskewEnable, deskewSetting, continuousSyncEnable, + pllFilterEnable, pllFilterValue); } return -1; /* error */ }
@@ -64,13 +63,13 @@ int dviInit(*/ unsigned short dviGetVendorID (void ) { -dvi_ctrl_device_t *pCurrentDviCtrl; +dvi_ctrl_device_t *pCurrentDviCtrl; - pCurrentDviCtrl = g_dcftSupportedDviController; -if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0 ) -return pCurrentDviCtrl->pfnGetVendorId (); + pCurrentDviCtrl = g_dcftSupportedDviController; +if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0 ) +return pCurrentDviCtrl->pfnGetVendorId (); -return 0x0000 ; +return 0x0000 ; }
@@ -83,15 +82,14 @@ unsigned short dviGetVendorID(void)*/ unsigned short dviGetDeviceID (void ) { -dvi_ctrl_device_t *pCurrentDviCtrl; +dvi_ctrl_device_t *pCurrentDviCtrl; pCurrentDviCtrl = g_dcftSupportedDviController; -if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0 ) -return pCurrentDviCtrl->pfnGetDeviceId (); +if (pCurrentDviCtrl != (dvi_ctrl_device_t *)0 ) +return pCurrentDviCtrl->pfnGetDeviceId (); -return 0x0000 ; +return 0x0000 ; }#endif -
Signature · 1 line
1.9.1
drivers/staging/sm750fb/ddk750_dvi.c line 46
Quoted 12 lines
This patch fixes indentation issues by replacing spaces by tabs at the start of line
Signed-off-by Niranjan Dighe <[email protected]>drivers/staging/sm750fb/ddk750_dvi.c +1
-1-if (pCurrentDviCtrl->pfnInit !=NULL ) +if (pCurrentDviCtrl->pfnInit !=NULL )
You are fixing a different type of warning here. Please make only one kind of change per patch.
Regards,
Markus
Quoted 10 lines · Markus Böhme
Quoted 9 lines
This patch fixes indentation issues by replacing spaces by tabs at the start of line
Signed-off-by Niranjan Dighe <[email protected]>drivers/staging/sm750fb/ddk750_dvi.c +0
-0
Quoted 9 lines
drivers/staging/sm750fb/ddk750_dvi.c line 46
Quoted 2 lines
drivers/staging/sm750fb/ddk750_dvi.c +1
-1-if (pCurrentDviCtrl->pfnInit !=NULL ) +if (pCurrentDviCtrl->pfnInit !=NULL )You are fixing a different type of warning here. Please make only one kind of change per patch.
Regards,
Markus
Hello Markus,
Thanks for your review. I will correct and resend a new patch. Please disregard this for the moment.
Thanks,
Niranjan Dighe