Caring at91bootstrap3

PATCH New Angelo Compagnucci 3 participants 9 messages Jun 2, 2015 – Jun 15, 2015 Arm/Microchip (AT91) SoC support

Share & tools

Angelo Compagnucci

author

2015-06-02 08:46 UTC #0 lore raw

v2 cover Caring at91bootstrap3

This patch series:
* Add license information to at91bootstrap
* Bumps to v3.7.2
* Adds the option to download via git from custom url

Angelo Compagnucci (3):
boot/at91bootstrap3: add license information boot/at91bootstrap3: bump to version 3.7.2 boot/at91bootstrap3: download via custom git url

 boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk | 21 ++++++++++++++++++++-
 2 files changed, 54 insertions(+), 1 deletion(-)

Signature · 1 line

2.4.2

Angelo Compagnucci

author

2015-06-02 08:46 UTC #1 lore raw

PATCH v2 1/3 boot/at91bootstrap3: add license information

This patch adds licensing informations to at91bootstrap3

Signed-off-by Angelo Compagnucci <[email protected]>

---
Changes v1 -> v2:
- Fixed license with a more appropriate one

 boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
 1 file changed, 2 insertions(+)

boot/at91bootstrap3/at91bootstrap3.mk +2 -0

index ff49e14..a997152 100644
@@ -6,6 +6,8 @@
 
 AT91BOOTSTRAP3_VERSION = v3.7.1
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+AT91BOOTSTRAP3_LICENSE = BSD-2c with endorsement clause
+AT91BOOTSTRAP3_LICENSE_FILES = main.c
 
 AT91BOOTSTRAP3_INSTALL_IMAGES = YES
 AT91BOOTSTRAP3_INSTALL_TARGET = NO

Signature · 1 line

2.4.2

Alexandre Belloni

2015-06-02 21:04 UTC #2 lore raw

PATCH v2 1/3 boot/at91bootstrap3: add license information

Quoted 15 lines · Angelo Compagnucci

This patch adds licensing informations to at91bootstrap3
Signed-off-by Angelo Compagnucci <[email protected]>
---
Changes v1 -> v2:
- Fixed license with a more appropriate one
 boot/at91bootstrap3/at91bootstrap3.mk | 2 ++
 1 file changed, 2 insertions(+)
boot/at91bootstrap3/at91bootstrap3.mk +0 -0
index ff49e14..a997152 100644

boot/at91bootstrap3/at91bootstrap3.mk line 9

Quoted 4 lines

boot/at91bootstrap3/at91bootstrap3.mk +1 -0

@@ -6,6 +6,8 @@
 
 AT91BOOTSTRAP3_VERSION = v3.7.1
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+AT91BOOTSTRAP3_LICENSE = BSD-2c with endorsement clause

I know I'm late to the party but this is actually a non endorsement clause.

Signature · 3 lines

Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thomas Petazzoni

2015-06-15 14:18 UTC #3 lore raw

PATCH v2 1/3 boot/at91bootstrap3: add license information

In reply to Angelo Compagnucci

Dear Angelo Compagnucci,

boot/at91bootstrap3/at91bootstrap3.mk line 10

Quoted 4 lines · Angelo Compagnucci

AT91BOOTSTRAP3_VERSION = v3.7.1
AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
boot/at91bootstrap3/at91bootstrap3.mk +2 -0
+AT91BOOTSTRAP3_LICENSE = BSD-2c with endorsement clause
+AT91BOOTSTRAP3_LICENSE_FILES = main.c

The license is neither a BSD-2c nor a BSD-3c, so I changed that to "Atmel License", like Yocto is doing, after a suggestion from Alexandre Belloni. Applied after doing this change.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Angelo Compagnucci

author

2015-06-02 08:46 UTC #4 lore raw

PATCH v2 2/3 boot/at91bootstrap3: bump to version 3.7.2

In reply to Angelo Compagnucci

This patch bumps at91bootstrap3 version to 3.7.2

Signed-off-by Angelo Compagnucci <[email protected]>

---
Changes v1 -> v2:
- No changes

 boot/at91bootstrap3/at91bootstrap3.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

boot/at91bootstrap3/at91bootstrap3.mk +1 -1

index a997152..2e25617 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.1
+AT91BOOTSTRAP3_VERSION = v3.7.2
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
 AT91BOOTSTRAP3_LICENSE = BSD-2c with endorsement clause
 AT91BOOTSTRAP3_LICENSE_FILES = main.c

Signature · 1 line

2.4.2

Thomas Petazzoni

Applied

2015-06-15 14:18 UTC #5 lore raw

PATCH v2 2/3 boot/at91bootstrap3: bump to version 3.7.2

Dear Angelo Compagnucci,

Quoted 6 lines · Angelo Compagnucci

This patch bumps at91bootstrap3 version to 3.7.2
Signed-off-by Angelo Compagnucci <[email protected]>
---
Changes v1 -> v2:
- No changes

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Angelo Compagnucci

author

2015-06-02 08:46 UTC #6 lore raw

PATCH v2 3/3 boot/at91bootstrap3: download via custom git url

In reply to Angelo Compagnucci

This patch adds the option to download at91bootstrap3 from a custom git URL. This is a requirement for all that boards that use a custom at91bootstrap3 version.

Signed-off-by Angelo Compagnucci <[email protected]>

---
Changes v1 -> v2:
- Adding error handling for BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL and BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION

 boot/at91bootstrap3/Config.in         | 34 ++++++++++++++++++++++++++++++++++
 boot/at91bootstrap3/at91bootstrap3.mk | 19 ++++++++++++++++++-
 2 files changed, 52 insertions(+), 1 deletion(-)

boot/at91bootstrap3/Config.in +34 -0

index 8ac40ed..9f2f49b 100644
@@ -10,6 +10,40 @@ config BR2_TARGET_AT91BOOTSTRAP3
 
 if BR2_TARGET_AT91BOOTSTRAP3
 
+choice
+
+	prompt "AT91 Bootstrap 3 version"
+
+config BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	bool "3.7.2"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+	bool "Custom Git repository"
+	help
+	  This option allows Buildroot to get the AT91 Bootstrap 3 source
+	  code from a Git repository.
+
+endchoice
+
+if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL
+	string "URL of custom repository"
+
+config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
+	string "Custom repository version"
+	help
+	  Revision to use in the typical format used by Git
+	  E.G. a sha id, a tag, branch, ..
+
+endif
+
+config BR2_TARGET_AT91BOOTSTRAP3_VERSION
+	string
+	default "v3.7.2" if BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION
+	default BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION \
+		if BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT
+
 config BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_PATCH_DIR
 	string "custom patch dir"
 	help

boot/at91bootstrap3/at91bootstrap3.mk +18 -1

index 2e25617..c045261 100644
@@ -4,8 +4,15 @@
 #
 ################################################################################
 
-AT91BOOTSTRAP3_VERSION = v3.7.2
+AT91BOOTSTRAP3_VERSION = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_VERSION))
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+AT91BOOTSTRAP3_SITE = $(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL))
+AT91BOOTSTRAP3_SITE_METHOD = git
+else
 AT91BOOTSTRAP3_SITE = $(call github,linux4sam,at91bootstrap,$(AT91BOOTSTRAP3_VERSION))
+endif
+
 AT91BOOTSTRAP3_LICENSE = BSD-2c with endorsement clause
 AT91BOOTSTRAP3_LICENSE_FILES = main.c

@@ -57,4 +64,14 @@ ifeq ($(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_CONFIG_FILE)),)
 $(error No at91bootstrap3 configuration file specified, check your BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_CONFIG_FILE setting)
 endif
 endif
+
+ifeq ($(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT),y)
+ifeq ($(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL)),)
+$(error No custom at91bootstrap3 repository URL specified. Check your BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL setting)
+endif
+ifeq ($(call qstrip,$(BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION)),)
+$(error No custom at91bootstrap3 repository version specified. Check your BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION setting)
+endif
+endif
+
 endif

Signature · 1 line

2.4.2

Thomas Petazzoni

Applied

2015-06-15 14:18 UTC #7 lore raw

PATCH v2 3/3 boot/at91bootstrap3: download via custom git url

Dear Angelo Compagnucci,

Quoted 9 lines · Angelo Compagnucci

This patch adds the option to download at91bootstrap3 from a custom git URL. This is a requirement for all that boards that use a custom at91bootstrap3 version.
Signed-off-by Angelo Compagnucci <[email protected]>
---
Changes v1 -> v2:
- Adding error handling for BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL and BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Angelo Compagnucci

author

2015-06-15 14:29 UTC #8 lore raw

PATCH v2 3/3 boot/at91bootstrap3: download via custom git url

Dear Thomas Petazzoni,

2015-06-15 16:18 GMT+02:00 Thomas Petazzoni
<[email protected]>:

Quoted 7 lines

Dear Angelo Compagnucci,
Quoted 4 lines · Angelo Compagnucci
This patch adds the option to download at91bootstrap3 from a custom git URL. This is a requirement for all that boards that use a custom at91bootstrap3 version.

Quoted 7 lines

Quoted 5 lines
Signed-off-by Angelo Compagnucci <[email protected]>
---
Changes v1 -> v2:
- Adding error handling for BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL and BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION
Applied, thanks.

A really big and appreciated thank you!

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 1 line

Profile: http://it.linkedin.com/in/compagnucciangelo