Skip to contentSkip to conversation

Fixes: 9697dffb098d ("drm: Turn off Legacy Context Functions")

PATCH In review Eddie Kovsky 2 participants 2 messages Jun 17, 2015 – Jun 18, 2015

Subsystems (2)
DRM drivers DRM misc
lore
Share & tools
lore

Eddie Kovsky

author
#0 lore raw

PATCH 1/1 Fixes: 9697dffb098d ("drm: Turn off Legacy Context Functions")

Commit 9697dffb098d ("drm: Turn off Legacy Context Functions") added checks for legacy features to several functions in the drm driver. It is now possible for the void functions changed by this commit to return an int error code. This patch updates the function definitions to return int. This fixes the build warnings:

warning: ‘return’ with a value, in function returning void
return -EINVAL

Signed-off-by Eddie Kovsky <[email protected]>
---
 drivers/gpu/drm/drm_context.c | 12 +++++++++---
 drivers/gpu/drm/drm_legacy.h  |  6 +++---
 2 files changed, 12 insertions(+), 6 deletions(-)
drivers/gpu/drm/drm_context.c +9 -3
index f3ea657f6574..3c2f4a76f934 100644
@@ -51,7 +51,7 @@ struct drm_ctx_list {
  * in drm_device::ctx_idr, while holding the drm_device::struct_mutex
  * lock.
  */
-void drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
+int drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
 {
 	if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT) &&
 		drm_core_check_feature(dev, DRIVER_MODESET))

@@ -60,6 +60,8 @@ void drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
 	mutex_lock(&dev->struct_mutex);
 	idr_remove(&dev->ctx_idr, ctx_handle);
 	mutex_unlock(&dev->struct_mutex);
+
+	return 0;
 }
 
 /**

@@ -107,7 +109,7 @@ int drm_legacy_ctxbitmap_init(struct drm_device * dev)
  * Free all idr members using drm_ctx_sarea_free helper function
  * while holding the drm_device::struct_mutex lock.
  */
-void drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
+int drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
 {
 	if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT) &&
 		drm_core_check_feature(dev, DRIVER_MODESET))

@@ -116,6 +118,8 @@ void drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
 	mutex_lock(&dev->struct_mutex);
 	idr_destroy(&dev->ctx_idr);
 	mutex_unlock(&dev->struct_mutex);
+
+	return 0;
 }
 
 /**

@@ -127,7 +131,7 @@ void drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
  * @file. Note that after this call returns, new contexts might be added if
  * the file is still alive.
  */
-void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file)
+int drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file)
 {
 	struct drm_ctx_list *pos, *tmp;
 

@@ -150,6 +154,8 @@ void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file)
 	}
 
 	mutex_unlock(&dev->ctxlist_mutex);
+
+	return 0;
 }
 
 /*@}*/
drivers/gpu/drm/drm_legacy.h +3 -3
index c1dc61473db5..26c16220e475 100644
@@ -43,9 +43,9 @@ struct drm_file;
 #define DRM_RESERVED_CONTEXTS		1
 
 int drm_legacy_ctxbitmap_init(struct drm_device *dev);
-void drm_legacy_ctxbitmap_cleanup(struct drm_device *dev);
-void drm_legacy_ctxbitmap_free(struct drm_device *dev, int ctx_handle);
-void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file);
+int drm_legacy_ctxbitmap_cleanup(struct drm_device *dev);
+int drm_legacy_ctxbitmap_free(struct drm_device *dev, int ctx_handle);
+int drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file);
 
 int drm_legacy_resctx(struct drm_device *d, void *v, struct drm_file *f);
 int drm_legacy_addctx(struct drm_device *d, void *v, struct drm_file *f);
Signature · 1 line
2.4.3
#1 lore raw
Quoted 10 lines · Eddie Kovsky

Commit 9697dffb098d ("drm: Turn off Legacy Context Functions") added checks for legacy features to several functions in the drm driver. It is now possible for the void functions changed by this commit to return an int error code. This patch updates the function definitions to return int. This fixes the build warnings:

warning: ‘return’ with a value, in function returning void
return -EINVAL

Signed-off-by Eddie Kovsky <[email protected]>

Oops sorry, I spotted this while applying but somehow screwed up and still pushed out the patch. Dropped it now for real.

Thanks, Daniel

Quoted 87 lines
---
 drivers/gpu/drm/drm_context.c | 12 +++++++++---
 drivers/gpu/drm/drm_legacy.h  |  6 +++---
 2 files changed, 12 insertions(+), 6 deletions(-)
drivers/gpu/drm/drm_context.c +9 -3
index f3ea657f6574..3c2f4a76f934 100644
@@ -51,7 +51,7 @@ struct drm_ctx_list {
  * in drm_device::ctx_idr, while holding the drm_device::struct_mutex
  * lock.
  */
-void drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
+int drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
 {
 	if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT) &&
 		drm_core_check_feature(dev, DRIVER_MODESET))

@@ -60,6 +60,8 @@ void drm_legacy_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
 	mutex_lock(&dev->struct_mutex);
 	idr_remove(&dev->ctx_idr, ctx_handle);
 	mutex_unlock(&dev->struct_mutex);
+
+	return 0;
 }
 
 /**

@@ -107,7 +109,7 @@ int drm_legacy_ctxbitmap_init(struct drm_device * dev)
  * Free all idr members using drm_ctx_sarea_free helper function
  * while holding the drm_device::struct_mutex lock.
  */
-void drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
+int drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
 {
 	if (!drm_core_check_feature(dev, DRIVER_KMS_LEGACY_CONTEXT) &&
 		drm_core_check_feature(dev, DRIVER_MODESET))

@@ -116,6 +118,8 @@ void drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
 	mutex_lock(&dev->struct_mutex);
 	idr_destroy(&dev->ctx_idr);
 	mutex_unlock(&dev->struct_mutex);
+
+	return 0;
 }
 
 /**

@@ -127,7 +131,7 @@ void drm_legacy_ctxbitmap_cleanup(struct drm_device * dev)
  * @file. Note that after this call returns, new contexts might be added if
  * the file is still alive.
  */
-void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file)
+int drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file)
 {
 	struct drm_ctx_list *pos, *tmp;
 

@@ -150,6 +154,8 @@ void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file)
 	}
 
 	mutex_unlock(&dev->ctxlist_mutex);
+
+	return 0;
 }
 
 /*@}*/
drivers/gpu/drm/drm_legacy.h +3 -3
index c1dc61473db5..26c16220e475 100644
@@ -43,9 +43,9 @@ struct drm_file;
 #define DRM_RESERVED_CONTEXTS		1
 
 int drm_legacy_ctxbitmap_init(struct drm_device *dev);
-void drm_legacy_ctxbitmap_cleanup(struct drm_device *dev);
-void drm_legacy_ctxbitmap_free(struct drm_device *dev, int ctx_handle);
-void drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file);
+int drm_legacy_ctxbitmap_cleanup(struct drm_device *dev);
+int drm_legacy_ctxbitmap_free(struct drm_device *dev, int ctx_handle);
+int drm_legacy_ctxbitmap_flush(struct drm_device *dev, struct drm_file *file);
 
 int drm_legacy_resctx(struct drm_device *d, void *v, struct drm_file *f);
 int drm_legacy_addctx(struct drm_device *d, void *v, struct drm_file *f);
Signature · 6 lines
2.4.3

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel