Skip to contentSkip to conversation

staging: sm750fb: convert pr_err to pr_info

PATCH In review Gujulan Elango, Hari Prasath (H.) 2 participants 5 messages Jun 18, 2015 – Jun 25, 2015

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Gujulan Elango, Hari Prasath (H.)

author
#0 lore raw

PATCH 1/1 staging: sm750fb: convert pr_err to pr_info

From: Hari Prasath Gujulan Elango <[email protected]>

This patch modifies few debug prints from pr_err() to pr_info() as they fall under that category.

Signed-off-by Hari Prasath Gujulan Elango <[email protected]>
---
 drivers/staging/sm750fb/sm750.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/sm750fb/sm750.c +3 -3
index 6b642d7..3f30bc0 100644
@@ -338,7 +338,7 @@ static int lynxfb_ops_set_par(struct fb_info *info)
 	line_length = var->xres_virtual * var->bits_per_pixel / 8;
 	line_length = PADDING(crtc->line_pad, line_length);
 	fix->line_length = line_length;
-	pr_err("fix->line_length = %d\n", fix->line_length);
+	pr_info("fix->line_length = %d\n", fix->line_length);
 
 	/* var->red,green,blue,transp are need to be set by driver
 	 * and these data should be set before setcolreg routine

@@ -1021,8 +1021,8 @@ static void sm750fb_setup(struct lynx_share *share, char *src)
 	}
 
 	while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
-		pr_err("opt=%s\n", opt);
-		pr_err("src=%s\n", src);
+		pr_info("opt=%s\n", opt);
+		pr_info("src=%s\n", src);
 
 		if (!strncmp(opt, "swap", strlen("swap")))
 			swap = 1;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Hari Prasath (H.)

From: Hari Prasath Gujulan Elango <[email protected]>

This patch modifies few debug prints from pr_err() to pr_info() as they fall under that category.

They should be dbg or removed.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in

author
#3 lore raw
In reply to Gujulan Elango, Hari Prasath (H.)
Quoted 12 lines · Dan Carpenter
Quoted 5 lines · Hari Prasath (H.)

From: Hari Prasath Gujulan Elango <[email protected]>

This patch modifies few debug prints from pr_err() to pr_info() as they fall under that category.

They should be dbg or removed.

regards,
dan carpenter

Dan,Greg has already merged this patch.Should I now send another patch to convert this from pr_info() to pr_dbg() ?

Regards
Hari Prasath

#4 lore raw
In reply to Gujulan Elango, Hari Prasath (H.)
Quoted 8 lines · Hari Prasath (H.)
Quoted 7 lines · Dan Carpenter
Quoted 5 lines · Hari Prasath (H.)

From: Hari Prasath Gujulan Elango <[email protected]>

This patch modifies few debug prints from pr_err() to pr_info() as they fall under that category.

Quoted 8 lines
Quoted 5 lines

They should be dbg or removed.

regards,
dan carpenter

Dan,Greg has already merged this patch.Should I now send another patch to convert this from pr_info() to pr_dbg() ?

Nah. Don't worry about it until someone complains.

Eventually all the debug output in this driver needs to be redone.

regards,
dan carpenter