Skip to contentSkip to conversation

NET: ROSE: Don't dereference NULL neighbour pointer.

PATCH Applied Ralf Baechle 2 participants 2 messages Jun 18, 2015 – Jun 23, 2015

Subsystems (3)
Networking Network drivers Stable branch
lore
Share & tools
lore

Ralf Baechle

author
#0 lore raw

PATCH 1/1 NET: ROSE: Don't dereference NULL neighbour pointer.

A ROSE socket doesn't necessarily always have a neighbour pointer so check if the neighbour pointer is valid before dereferencing it.

Signed-off-by Ralf Baechle <[email protected]>
Tested-by Bernard Pidoux <[email protected]>
Cc [email protected] #2.6.11+
net/rose/af_rose.c +2 -1
index 8ae6030..dd304bc 100644
@@ -192,7 +192,8 @@ static void rose_kill_by_device(struct net_device *dev)
 
 		if (rose->device == dev) {
 			rose_disconnect(s, ENETUNREACH, ROSE_OUT_OF_ORDER, 0);
-			rose->neighbour->use--;
+			if (rose->neighbour)
+				rose->neighbour->use--;
 			rose->device = NULL;
 		}
 	}