mfd: flexcom: add a driver for Flexcom
v3 cover mfd: flexcom: add a driver for Flexcom
ChangeLog
v3:
- remove MODULE_ALIAS()
- add Acked-by from Boris Brezillon and Alexandre Belloni
v2:
- enhance the documentation of DT bindings and change the way the "ranges" property is used.
- replace __raw_readl() and __raw_writel() by readl() and writel().
- change the module license to "GPL" for v2 or later
- print the selected flexcom mode after the hardware version
v1:
This series of patches a support to the Atmel Flexcom, a wrapper which integrates an USART, a SPI controller and a TWI controller. Only one peripheral can be used at a time. The active function is selected though the Flexcom Mode Register.
Cyrille Pitchen (2):
mfd: devicetree: add bindings for Atmel Flexcom
mfd: flexcom: add a driver for Atmel Flexible Serial Communication
Unit
.../devicetree/bindings/mfd/atmel-flexcom.txt | 58 +++++++++++++ drivers/mfd/Kconfig | 11 +++ drivers/mfd/Makefile | 1 + drivers/mfd/atmel-flexcom.c | 96 ++++++++++++++++++++++ 4 files changed, 166 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt create mode 100644 drivers/mfd/atmel-flexcom.c
Signature · 1 line
1.8.2.2
PATCH v3 1/2 mfd: devicetree: add bindings for Atmel Flexcom
--- .../devicetree/bindings/mfd/atmel-flexcom.txt | 58 ++++++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
Documentation/devicetree/bindings/mfd/atmel-flexcom.txt new file +58 -0
@@ -0,0 +1,58 @@ +* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit) + +The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C +controller and an USART. Only one function can be used at a time and is chosen +at boot time according to the device tree. + +Required properties: +- compatible: "atmel,sama5d2-flexcom" +- reg: shall be the offset/length value for Flexcom dedicated I/O registers + (without USART, TWI or SPI registers). +- clocks: shall be the Flexcom peripheral clock from PMC. +- #address-cells: should be <1> +- #size-cells: should be <1> +- ranges: one range for the full I/O register region (including USART, TWI and + SPI registers) +- atmel,flexcom-mode: shall be a string among { "spi", "usart", "i2c", "twi" }. + "i2c" and "twi" are synonymous. + +Required child: +a child device of type matching the "atmel,flexcom-mode" property. +The reg property of this child should be: +- <0x200 0x200> for USART +- <0x400 0x200> for SPI +- <0x600 0x200> for I2C +The phandle provided by the clocks property of the child is the same as one for +the Flexcom parent. +Other properties remain unchanged. See documentation of the respective device. + +Example: + +flx0: flexcom at f8034000 { + compatible = "atmel,sama5d2-flexcom"; + reg = <0xf8034000 0x200>; + clocks = <&flx0_clk>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0xf8034000 0x800>; + atmel,flexcom-mode = "spi"; + + spi at f8034400 { + compatible = "atmel,at91rm9200-spi"; + reg = <0x400 0x200>; + interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flx0_ioset1>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&flx0_clk>; + clock-names = "spi_clk"; + atmel,fifo-size = <32>; + + mtd_dataflash at 0 { + compatible = "atmel,at25f512b"; + reg = <0>; + spi-max-frequency = <20000000>; + }; + }; +};
Signature · 1 line
1.8.2.2
PATCH v3 2/2 mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit
In reply to Cyrille PitchenThis driver supports the new Atmel Flexcom. The Flexcom is a wrapper which integrates one SPI controller, one I2C controller and one USART. Only one function can be enabled at a time. This driver selects the function once for all, when the Flexcom is probed, according to the value of the new "atmel,flexcom-mode" device tree property.
This driver has chosen to present the Flexcom to the system as a MFD so the implementation is seamless for the existing Atmel SPI, I2C and USART drivers.
Also the Flexcom embeds FIFOs: the latest patches of the SPI, I2C and USART drivers take advantage of this new feature.
--- drivers/mfd/Kconfig | 11 ++++++ drivers/mfd/Makefile | 1 + drivers/mfd/atmel-flexcom.c | 96 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 108 insertions(+) create mode 100644 drivers/mfd/atmel-flexcom.c
drivers/mfd/Kconfig +11 -0
@@ -59,6 +59,17 @@ config MFD_AAT2870_CORE additional drivers must be enabled in order to use the functionality of the device. +config MFD_ATMEL_FLEXCOM + tristate "Atmel Flexcom (Flexible Serial Communication Unit)" + select MFD_CORE + depends on OF + help + Select this to get support for Atmel Flexcom. This is a wrapper + which embeds a SPI controller, a I2C controller and a USART. Only + one function can be used at a time. The choice is done at boot time + by the probe function of this MFD driver according to a device tree + property. + config MFD_ATMEL_HLCDC tristate "Atmel HLCDC (High-end LCD Controller)" select MFD_CORE
drivers/mfd/Makefile +1 -0
@@ -160,6 +160,7 @@ obj-$(CONFIG_MFD_SPMI_PMIC) += qcom-spmi-pmic.o obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o obj-$(CONFIG_MFD_TPS65090) += tps65090.o obj-$(CONFIG_MFD_AAT2870_CORE) += aat2870-core.o +obj-$(CONFIG_MFD_ATMEL_FLEXCOM) += atmel-flexcom.o obj-$(CONFIG_MFD_ATMEL_HLCDC) += atmel-hlcdc.o obj-$(CONFIG_MFD_INTEL_MSIC) += intel_msic.o obj-$(CONFIG_MFD_PALMAS) += palmas.o
drivers/mfd/atmel-flexcom.c new file +96 -0
96 lines not on this page · raw message
Signature · 1 line
1.8.2.2
Re: [PATCH v3 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit
Hi Cyrille,
Review
Quoted 2 lines · Cyrille Pitchen
(quoted diff) +2
-0+ + clk_prepare_enable(clk);
I believe you need to have error handling here, not because it will actually fail but to handle deferrals.
drivers/mfd/atmel-flexcom.c line 76
Quoted 8 lines
drivers/mfd/atmel-flexcom.c new file +8
-0+ version =readl (map +FX_VERSION ); +writel (mr, map +FX_MR ); +clk_disable_unprepare (clk); + +dev_info (&pdev->dev,"version: %#x, mode: %s\n" , version, mode); + +return of_platform_populate (pdev->dev.of_node,NULL ,NULL , &pdev->dev); +}
Thanks.
Signature · 1 line
Dmitry