rpi-firmware: allow disabling installation of binary DTBs

PATCH New Floris Bos 4 participants 14 messages May 2, 2015 – Jun 28, 2015

Share & tools

Floris Bos

author

2015-05-02 15:10 UTC #0 lore raw

PATCH 1/2 rpi-firmware: allow disabling installation of binary DTBs

The binary .dtb files are not suitable for everyone as they are kernel version specific.
Reintroduces BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS option.

Signed-off-by Floris Bos <[email protected]>

---
 package/rpi-firmware/Config.in       | 10 ++++++++++
 package/rpi-firmware/rpi-firmware.mk |  2 ++
 2 files changed, 12 insertions(+)

package/rpi-firmware/Config.in +10 -0

index cd45be4..2de26e3 100644
@@ -45,4 +45,14 @@ config BR2_PACKAGE_RPI_FIRMWARE_BOOT
 	default "_x"    if BR2_PACKAGE_RPI_FIRMWARE_X
 	default "_cd"   if BR2_PACKAGE_RPI_FIRMWARE_CD
 
+config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
+	bool "Install Device Tree Blobs (DTBs)"
+	default "y"
+	help
+	  Say 'y' here if you want to install the binary DTB files which
+	  are suitable for a rpi-3.18.y branch Linux kernel.
+
+	  Say 'n' here if you intend to compile the device tree files
+	  from kernel source instead.
+
 endif # BR2_PACKAGE_RPI_FIRMWARE

package/rpi-firmware/rpi-firmware.mk +2 -0

index cbcf790..9cccb38 100644
@@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
 
+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb

@@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
 		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \
 	done
 endef
+endif
 
 define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
 	$(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin

Signature · 1 line

2.1.4

Floris Bos

author

2015-05-02 15:10 UTC #1 lore raw

PATCH 2/2 rpi-firmware: modify settings for Pi 2

Remove low-level settings from config.txt like arm_freq and sdram_freq. The defaults should be good for most and differ by Pi model. E.g. the Pi 2 runs at 900 Mhz by default, setting arm_freq=700 like we had previously would underclock it.

Add short description in comments to options.
Mention initramfs option.

Remove obsolete options from cmdline.txt

Signed-off-by Floris Bos <[email protected]>

---
 package/rpi-firmware/cmdline.txt |  2 +-
 package/rpi-firmware/config.txt  | 14 ++++++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

package/rpi-firmware/cmdline.txt +1 -1

index 061e54b..38aa378 100644
@@ -1 +1 @@
-dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait
+root=/dev/mmcblk0p2 rootwait

package/rpi-firmware/config.txt +10 -4

index 994972b..aa8d2ab 100644
@@ -4,11 +4,17 @@
 # See http://buildroot.org/downloads/manual/manual.html#rootfs-custom
 # and http://elinux.org/RPiconfig for a description of config.txt syntax
 
-arm_freq=700
-core_freq=250
 kernel=zImage
+
+# To use an external initramfs file
+#initramfs rootfs.cpio.gz
+
+# Disable overscan assuming the display supports displaying the full resolution
+# If the text shown on the screen disappears off the edge, comment this out
 disable_overscan=1
+
+# How much memory in MB to assign to the GPU on Pi models having
+# 256, 512 or 1024 MB total memory
 gpu_mem_256=100
 gpu_mem_512=100
-sdram_freq=400
-over_voltage=0
+gpu_mem_1024=100

Signature · 1 line

2.1.4

Yann E. MORIN

2015-05-02 15:56 UTC #2 lore raw

PATCH 2/2 rpi-firmware: modify settings for Pi 2

Floris, All,

On 2015-05-02 17:10 +0200, Floris Bos spake thusly:

Quoted 11 lines

Remove low-level settings from config.txt like arm_freq and sdram_freq. The defaults should be good for most and differ by Pi model. E.g. the Pi 2 runs at 900 Mhz by default, setting arm_freq=700 like we had previously would underclock it.
Add short description in comments to options.
Mention initramfs option.
Remove obsolete options from cmdline.txt
Signed-off-by Floris Bos <[email protected]>

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 45 lines

---
 package/rpi-firmware/cmdline.txt |  2 +-
 package/rpi-firmware/config.txt  | 14 ++++++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

package/rpi-firmware/cmdline.txt +1 -1

index 061e54b..38aa378 100644
@@ -1 +1 @@
-dwc_otg.fiq_fix_enable=1 sdhci-bcm2708.sync_after_dma=0 dwc_otg.lpm_enable=0 console=tty1 root=/dev/mmcblk0p2 rootwait
+root=/dev/mmcblk0p2 rootwait

package/rpi-firmware/config.txt +10 -4

index 994972b..aa8d2ab 100644
@@ -4,11 +4,17 @@
 # See http://buildroot.org/downloads/manual/manual.html#rootfs-custom
 # and http://elinux.org/RPiconfig for a description of config.txt syntax
 
-arm_freq=700
-core_freq=250
 kernel=zImage
+
+# To use an external initramfs file
+#initramfs rootfs.cpio.gz
+
+# Disable overscan assuming the display supports displaying the full resolution
+# If the text shown on the screen disappears off the edge, comment this out
 disable_overscan=1
+
+# How much memory in MB to assign to the GPU on Pi models having
+# 256, 512 or 1024 MB total memory
 gpu_mem_256=100
 gpu_mem_512=100
-sdram_freq=400
-over_voltage=0
+gpu_mem_1024=100

Signature · 6 lines

2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Thomas Petazzoni

Applied

2015-05-02 17:17 UTC #3 lore raw

PATCH 2/2 rpi-firmware: modify settings for Pi 2

In reply to Floris Bos

Dear Floris Bos,

Quoted 8 lines · Floris Bos

Remove low-level settings from config.txt like arm_freq and sdram_freq. The defaults should be good for most and differ by Pi model. E.g. the Pi 2 runs at 900 Mhz by default, setting arm_freq=700 like we had previously would underclock it.
Add short description in comments to options.
Mention initramfs option.

Quoted 7 lines

Remove obsolete options from cmdline.txt
Signed-off-by Floris Bos <[email protected]>
---
 package/rpi-firmware/cmdline.txt |  2 +-
 package/rpi-firmware/config.txt  | 14 ++++++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Floris Bos

author

2015-05-02 15:10 UTC #4 lore raw

PATCH v2 1/1 php.ini: set date.timezone

In reply to Floris Bos

Set date.timezone in php.ini to match time zone settings. Prevents a warning being logged about it not being set each time a PHP date/time method is used.

Signed-off-by Floris Bos <[email protected]>

---
v2: follows Arnout's suggestion, using BR2_TARGET_LOCALTIME

---
 package/php/php.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

package/php/php.mk +8 -0

index 3b9a117..47811ff 100644
@@ -24,6 +24,12 @@ PHP_CONF_ENV = \
 	ac_cv_func_strcasestr=yes \
 	EXTRA_LIBS="$(PHP_EXTRA_LIBS)"
 
+ifeq ($(BR2_TARGET_LOCALTIME),)
+PHP_LOCALTIME = UTC
+else
+PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)
+endif
+
 # PHP can't be AUTORECONFed the standard way unfortunately
 PHP_DEPENDENCIES += host-autoconf host-automake host-libtool
 define PHP_BUILDCONF

@@ -288,6 +294,8 @@ define PHP_INSTALL_FIXUP
 	rm -f $(TARGET_DIR)/usr/bin/phpize
 	$(INSTALL) -D -m 0755 $(PHP_DIR)/php.ini-production \
 		$(TARGET_DIR)/etc/php.ini
+	$(SED) 's%;date.timezone =.*%date.timezone = $(PHP_LOCALTIME)%' \
+		$(TARGET_DIR)/etc/php.ini
 endef
 
 PHP_POST_INSTALL_TARGET_HOOKS += PHP_INSTALL_FIXUP

Signature · 1 line

2.1.4

Arnout Vandecappelle

2015-05-02 15:43 UTC #5 lore raw

PATCH v2 1/1 php.ini: set date.timezone

Quoted 5 lines · Floris Bos

Set date.timezone in php.ini to match time zone settings. Prevents a warning being logged about it not being set each time a PHP date/time method is used.
Signed-off-by Floris Bos <[email protected]>

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 34 lines

---
v2: follows Arnout's suggestion, using BR2_TARGET_LOCALTIME

---
 package/php/php.mk | 8 ++++++++
 1 file changed, 8 insertions(+)

package/php/php.mk +8 -0

index 3b9a117..47811ff 100644
@@ -24,6 +24,12 @@ PHP_CONF_ENV = \
 	ac_cv_func_strcasestr=yes \
 	EXTRA_LIBS="$(PHP_EXTRA_LIBS)"
 
+ifeq ($(BR2_TARGET_LOCALTIME),)
+PHP_LOCALTIME = UTC
+else
+PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)
+endif
+
 # PHP can't be AUTORECONFed the standard way unfortunately
 PHP_DEPENDENCIES += host-autoconf host-automake host-libtool
 define PHP_BUILDCONF

@@ -288,6 +294,8 @@ define PHP_INSTALL_FIXUP
 	rm -f $(TARGET_DIR)/usr/bin/phpize
 	$(INSTALL) -D -m 0755 $(PHP_DIR)/php.ini-production \
 		$(TARGET_DIR)/etc/php.ini
+	$(SED) 's%;date.timezone =.*%date.timezone = $(PHP_LOCALTIME)%' \
+		$(TARGET_DIR)/etc/php.ini
 endef
 
 PHP_POST_INSTALL_TARGET_HOOKS += PHP_INSTALL_FIXUP

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

Thomas Petazzoni

2015-05-02 17:18 UTC #6 lore raw

PATCH v2 1/1 php.ini: set date.timezone

In reply to Floris Bos

Dear Floris Bos,

package/php/php.mk PHP_CONF_ENV = \ · line 30

Quoted 4 lines · Floris Bos

package/php/php.mk +4 -0

+ifeq ($(BR2_TARGET_LOCALTIME),)
+PHP_LOCALTIME = UTC
+else
+PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)

I suppose you tested that a qstrip call is not needed here.

So, I applied with Arnout Reviewed-by.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Floris Bos

author

2015-05-02 17:22 UTC #7 lore raw

PATCH v2 1/1 php.ini: set date.timezone

Quoted 9 lines · Thomas Petazzoni

Dear Floris Bos,
package/php/php.mk PHP_CONF_ENV = \ · line 30
Quoted 4 lines · Floris Bos
package/php/php.mk +4 -0
+ifeq ($(BR2_TARGET_LOCALTIME),)
+PHP_LOCALTIME = UTC
+else
+PHP_LOCALTIME = $(BR2_TARGET_LOCALTIME)
I suppose you tested that a qstrip call is not needed here.

Yes.
Quotes are fine in php.ini

Yours sincerely,

Floris Bos

Thomas Petazzoni

2015-05-02 18:54 UTC #8 lore raw

PATCH v2 1/1 php.ini: set date.timezone

Hello,

Quoted 2 lines · Floris Bos

Yes.
Quotes are fine in php.ini

Great, thanks for the confirmation.

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Yann E. MORIN

2015-06-19 20:30 UTC #9 lore raw

PATCH 1/2 rpi-firmware: allow disabling installation of binary DTBs

In reply to Floris Bos

floris, All,

On 2015-05-02 17:10 +0200, Floris Bos spake thusly:

Quoted 3 lines

The binary .dtb files are not suitable for everyone as they are kernel version specific.
Reintroduces BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS option.

I am revisitng this one now that I have a little tiny bit of time.

Indeed, using the DTBs from rpi-firmware is not working with linux 3.19 or 4.0, although they do work with 3.18.

Quoted 13 lines

Signed-off-by Floris Bos <[email protected]>

---
 package/rpi-firmware/Config.in       | 10 ++++++++++
 package/rpi-firmware/rpi-firmware.mk |  2 ++
 2 files changed, 12 insertions(+)

package/rpi-firmware/Config.in +0 -0

index cd45be4..2de26e3 100644
@@ -45,4 +45,14 @@ config BR2_PACKAGE_RPI_FIRMWARE_BOOT
 	default "_x"    if BR2_PACKAGE_RPI_FIRMWARE_X
 	default "_cd"   if BR2_PACKAGE_RPI_FIRMWARE_CD

package/rpi-firmware/Config.in config BR2_PACKAGE_RPI_FIRMWARE_BOOT · line 56

Quoted 10 lines

package/rpi-firmware/Config.in +9 -0

 
+config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
+	bool "Install Device Tree Blobs (DTBs)"
+	default "y"
+	help
+	  Say 'y' here if you want to install the binary DTB files which
+	  are suitable for a rpi-3.18.y branch Linux kernel.
+
+	  Say 'n' here if you intend to compile the device tree files
+	  from kernel source instead.

I would rephrase that as:

If you are using a Linux kernel <= 3.18, you should say 'y' here.

If you are using a Linux kernel >= 3.19, you should say 'n' here, and enable BR2_LINUX_KERNEL_DTS_SUPPORT to let the kernel build the DTB.

Quoted 15 lines

package/rpi-firmware/Config.in +1 -0

+
 endif # BR2_PACKAGE_RPI_FIRMWARE

package/rpi-firmware/rpi-firmware.mk +1 -0

index cbcf790..9cccb38 100644
@@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
 RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
 
+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb

package/rpi-firmware/rpi-firmware.mk define RPI_FIRMWARE_INSTALL_DTB · line 25

Quoted 4 lines

package/rpi-firmware/rpi-firmware.mk +1 -0

@@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
 		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \
 	done
 endef
+endif

I'd put the overlays out of the conditional block, because they are *not* built by the Linux kernel.

Also, I think we'd want an option to enable/disable installign the overlays.

I'll take your patch here and repsin a bit later tonight.

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 9 lines

package/rpi-firmware/rpi-firmware.mk +0 -0

 define RPI_FIRMWARE_INSTALL_IMAGES_CMDS
 	$(INSTALL) -D -m 0644 $(@D)/boot/bootcode.bin $(BINARIES_DIR)/rpi-firmware/bootcode.bin

Signature · 6 lines

2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Floris Bos

author

2015-06-19 20:52 UTC #10 lore raw

PATCH 1/2 rpi-firmware: allow disabling installation of binary DTBs

Quoted 11 lines · Yann E. MORIN

package/rpi-firmware/Config.in +9 -0

+config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
+	bool "Install Device Tree Blobs (DTBs)"
+	default "y"
+	help
+	  Say 'y' here if you want to install the binary DTB files which
+	  are suitable for a rpi-3.18.y branch Linux kernel.
+
+	  Say 'n' here if you intend to compile the device tree files
+	  from kernel source instead.

I would rephrase that as:

Quoted 6 lines

If you are using a Linux kernel <= 3.18, you should say 'y' here.
If you are using a Linux kernel >= 3.19, you should say 'n' here, and enable BR2_LINUX_KERNEL_DTS_SUPPORT to let the kernel build the DTB.

Rephrashing is fine with me.

Quoted 18 lines

endif # BR2_PACKAGE_RPI_FIRMWARE

package/rpi-firmware/rpi-firmware.mk +2 -0

index cbcf790..9cccb38 100644
@@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 
  RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
 
+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
  define RPI_FIRMWARE_INSTALL_DTB
  	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
  	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb

@@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
  		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \
  	done
  endef
+endif

Quoted 2 lines

I'd put the overlays out of the conditional block, because they are *not* built by the Linux kernel.

They do seem to be part of the rpi Linux source tree:
https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays
Isn't it a matter of adding overlay/name-of-overlay to BR2_LINUX_KERNEL_INTREE_DTS_NAME if someone wants an overlay build?

Yours sincerely,

Floris Bos

Yann E. MORIN

2015-06-19 21:07 UTC #11 lore raw

PATCH 1/2 rpi-firmware: allow disabling installation of binary DTBs

Floris, All,

On 2015-06-19 22:52 +0200, Floris Bos spake thusly:

Quoted 12 lines · Yann E. MORIN

Quoted 11 lines

package/rpi-firmware/Config.in +9 -0

+config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS
+	bool "Install Device Tree Blobs (DTBs)"
+	default "y"
+	help
+	  Say 'y' here if you want to install the binary DTB files which
+	  are suitable for a rpi-3.18.y branch Linux kernel.
+
+	  Say 'n' here if you intend to compile the device tree files
+	  from kernel source instead.

I would rephrase that as:

Quoted 7 lines

Quoted 5 lines
If you are using a Linux kernel <= 3.18, you should say 'y' here.
If you are using a Linux kernel >= 3.19, you should say 'n' here, and enable BR2_LINUX_KERNEL_DTS_SUPPORT to let the kernel build the DTB.
Rephrashing is fine with me.

OK, thanks.

Quoted 13 lines

endif # BR2_PACKAGE_RPI_FIRMWARE

package/rpi-firmware/rpi-firmware.mk +1 -0

index cbcf790..9cccb38 100644
@@ -13,6 +13,7 @@ RPI_FIRMWARE_INSTALL_IMAGES = YES
 RPI_FIRMWARE_DEPENDENCIES += host-rpi-firmware
+ifeq ($(BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTBS),y)
 define RPI_FIRMWARE_INSTALL_DTB
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b.dtb
 	$(INSTALL) -D -m 0644 $(@D)/boot/bcm2708-rpi-b-plus.dtb $(BINARIES_DIR)/rpi-firmware/bcm2708-rpi-b-plus.dtb

@@ -21,6 +22,7 @@ define RPI_FIRMWARE_INSTALL_DTB
 		$(INSTALL) -D -m 0644 $${ovldtb} $(BINARIES_DIR)/rpi-firmware/overlays/$${ovldtb##*/} || exit 1; \

Quoted 8 lines

Quoted 5 lines
package/rpi-firmware/rpi-firmware.mk +1 -0
 	done
 endef
+endif
I'd put the overlays out of the conditional block, because they are *not* built by the Linux kernel.
They do seem to be part of the rpi Linux source tree:
https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays

Ah, indeed. I was mislead by looking at the rpi-4.0.y branch, which does not have that sub-directory. But looking further, the overlays are all along side the standard DTS, not in a sub-directory.

I'll see what I can do with that.

Quoted 2 lines

Isn't it a matter of adding overlay/name-of-overlay to BR2_LINUX_KERNEL_INTREE_DTS_NAME if someone wants an overlay build?

It would seem so. I'll test that.

Thanks for the tips! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yann E. MORIN

2015-06-19 22:47 UTC #12 lore raw

PATCH 1/2 rpi-firmware: allow disabling installation of binary DTBs

Floris, All,

On 2015-06-19 23:07 +0200, Yann E. MORIN spake thusly:

Quoted 2 lines

On 2015-06-19 22:52 +0200, Floris Bos spake thusly:
Quoted 1 line · Yann E. MORIN

[--SNIP--]

Quoted 9 lines

Quoted 5 lines
Quoted 2 lines
I'd put the overlays out of the conditional block, because they are *not* built by the Linux kernel.
They do seem to be part of the rpi Linux source tree:
https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays
Ah, indeed. I was mislead by looking at the rpi-4.0.y branch, which does not have that sub-directory. But looking further, the overlays are all along side the standard DTS, not in a sub-directory.

OK, so I was a bit mislead. I was looking at the rpi-3.19.y branch, which has all the overlays alongside the standard dts. the rpi-3.18.y and rpi4.0.y branches indeed have them in a specific sub-dir, as you pointed out.

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Yann E. MORIN

2015-06-28 22:35 UTC #13 lore raw

PATCH 1/2 rpi-firmware: allow disabling installation of binary DTBs

In reply to Floris Bos

Floris, All,

On 2015-06-19 22:52 +0200, Floris Bos spake thusly:

Quoted 1 line · Yann E. MORIN

[--SNIP--]

Quoted 6 lines

Quoted 2 lines
I'd put the overlays out of the conditional block, because they are *not* built by the Linux kernel.
They do seem to be part of the rpi Linux source tree: https://github.com/raspberrypi/linux/tree/rpi-3.18.y/arch/arm/boot/dts/overlays
Isn't it a matter of adding overlay/name-of-overlay to
BR2_LINUX_KERNEL_INTREE_DTS_NAME if someone wants an overlay build?

In fact, no, it does not work.

We would need to do some changes in Buildroot for how we handle DTB generation to be able to generate the DTB overlays.

So, I've postponed that change for later, and introduced a new Kconfig knob to install DTB overlays:

    https://patchwork.ozlabs.org/patch/489181/

Regards,
Yann E. MORIN.

Signature · 6 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'