Skip to contentSkip to conversation

staging: comedi: no space before tabs

PATCH In review Luis de Bethencourt 2 participants 3 messages Jun 22, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 staging: comedi: no space before tabs

Warning found by checkpatch.pl
WARNING: please, no space before tabs
/drivers/staging/comedi/drivers/das16m1.c:83
+ 404-407 ^I8254$

---
 drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/staging/comedi/drivers/das16m1.c +12 -12
index 1adf6a7..a991c97 100644
@@ -69,18 +69,18 @@ irq can be omitted, although the cmd interface will not work without it.
 
     "cio-das16/m1"
 
-  0	a/d bits 0-3, mux		start 12 bit
-  1	a/d bits 4-11		unused
-  2	status		control
-  3	di 4 bit		do 4 bit
-  4	unused			clear interrupt
-  5	interrupt, pacer
-  6	channel/gain queue address
-  7	channel/gain queue data
-  89ab	8254
-  cdef	8254
-  400	8255
-  404-407 	8254
+  0		a/d bits 0-3, mux		start 12 bit
+  1		a/d bits 4-11		unused
+  2		status		control
+  3		di 4 bit		do 4 bit
+  4		unused			clear interrupt
+  5		interrupt, pacer
+  6		channel/gain queue address
+  7		channel/gain queue data
+  89ab		8254
+  cdef		8254
+  400		8255
+  404-407	8254
 
 */
 
Signature · 5 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/
#1 lore raw
Quoted 9 lines · Luis de Bethencourt

Warning found by checkpatch.pl
WARNING: please, no space before tabs
/drivers/staging/comedi/drivers/das16m1.c:83
+ 404-407 ^I8254$

---
  drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
  1 file changed, 12 insertions(+), 12 deletions(-)

Like for your "Author string" patch for das08_cs.c, it would be nice to mention the module name in the subject line in this patch and in patch 2 of the series, especially as these changes are for a specific module, not the whole of comedi.

Signature · 5 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/
#2 lore raw
Quoted 11 lines · Ian Abbott
Quoted 9 lines · Luis de Bethencourt

Warning found by checkpatch.pl
WARNING: please, no space before tabs
/drivers/staging/comedi/drivers/das16m1.c:83
+ 404-407 ^I8254$

---
 drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)
Quoted 5 lines

Like for your "Author string" patch for das08_cs.c, it would be nice to mention the module name in the subject line in this patch and in patch 2 of the series, especially as these changes are for a specific module, not the whole of comedi.

Makes sense. I should've gone ahead and done it sooner. Fixed now.

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/