openvmtools: fix legal info
PATCH 1/1 openvmtools: fix legal info
In ab71dff0 it was moved to SUBDIR, but this was never reflected for the legal-info files, update this to fix:
http://autobuild.buildroot.net/results/836/8363943cc9c967713f585209408ea087a052a12d/
--- package/openvmtools/openvmtools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/openvmtools/openvmtools.mk +1 -1
@@ -7,7 +7,7 @@ OPENVMTOOLS_VERSION = stable-9.10.0 OPENVMTOOLS_SITE = $(call github,vmware,open-vm-tools,$(OPENVMTOOLS_VERSION)) OPENVMTOOLS_LICENSE = LGPLv2.1 -OPENVMTOOLS_LICENSE_FILES = COPYING +OPENVMTOOLS_LICENSE_FILES = $(OPENVMTOOLS_SUBDIR)/COPYING # Autoreconf needed or config/missing will run configure again at buildtime OPENVMTOOLS_AUTORECONF = YES OPENVMTOOLS_SUBDIR = open-vm-tools
Signature · 1 line
2.3.6
PATCH 1/1 openvmtools: fix legal info
Gustavo, All,
On 2015-06-21 08:25 -0300, Gustavo Zacarias spake thusly:
Quoted 14 lines
In
ab71dff0it was moved to SUBDIR, but this was never reflected for the legal-info files, update this to fix:
http://autobuild.buildroot.net/results/836/8363943cc9c967713f585209408ea087a052a12d/Signed-off-by Gustavo Zacarias <[email protected]>--- package/openvmtools/openvmtools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/openvmtools/openvmtools.mk +0
-0
package/openvmtools/openvmtools.mk line 10
Quoted 5 lines
package/openvmtools/openvmtools.mk +1
-1@@ -7,7 +7,7 @@ OPENVMTOOLS_VERSION = stable-9.10.0 OPENVMTOOLS_SITE = $(call github,vmware,open-vm-tools,$(OPENVMTOOLS_VERSION)) OPENVMTOOLS_LICENSE = LGPLv2.1 -OPENVMTOOLS_LICENSE_FILES = COPYING +OPENVMTOOLS_LICENSE_FILES = $(OPENVMTOOLS_SUBDIR)/COPYING
I know this has no impact in Makefiles, but I prefer when we define variables before we use them, it's easier to understand. So, I'd prefer we define OPENVMTOOLS_SUBDIR before we use it.
Otherwise:
Regards,
Yann E. MORIN.
Quoted 10 lines
package/openvmtools/openvmtools.mk +0
-0# Autoreconf needed or config/missing will run configure again at buildtime OPENVMTOOLS_AUTORECONF = YES OPENVMTOOLS_SUBDIR = open-vm-toolsSignature · 6 lines
2.3.6 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 openvmtools: fix legal info
In reply to Gustavo ZacariasHi Gustavo, all,
sorry, I missed this one.
Tested with make legal-info.
Quoted 2 lines
Signed-off-by Gustavo Zacarias <[email protected]>
Best regards,
Karoly
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150621/27cb1a98/attachment.html>
PATCH 1/1 openvmtools: fix legal info
Quoted 3 lines · K?roly Kasza
Hi Gustavo, all,
sorry, I missed this one.
Hi all.
I wonder if it wouldn't be better to just use subdir in the legal info, i don't think there's any package using/needing to fetch the files outside of it.
Regards.
PATCH 1/1 openvmtools: fix legal info
Dear Gustavo,
Quoted 10 lines · Gustavo Zacarias
Quoted 3 lines · K?roly Kasza
Hi Gustavo, all,
sorry, I missed this one.
Hi all.
I wonder if it wouldn't be better to just use subdir in the legal info,
Looks like a good idea, but...
Quoted 2 lines
i don't think there's any package using/needing to fetch the files outside of it.
...we have them! :( Here's a couple examples:
$ git grep -E '_(LICENSE_FILES|SUBDIR) =' -- package/samba package/berkeleydb/ package/berkeleydb/berkeleydb.mk:BERKELEYDB_SUBDIR = build_unix package/berkeleydb/berkeleydb.mk:BERKELEYDB_LICENSE_FILES = LICENSE package/samba/samba.mk:SAMBA_SUBDIR = source3 package/samba/samba.mk:SAMBA_LICENSE_FILES = COPYING $
Setting SAMBA_LICENSE_FILES to ../COPYING does not look very nice to me.
Signature · 1 line
Luca
PATCH 1/1 openvmtools: fix legal info
Quoted 11 lines · Luca Ceresoli
...we have them! :( Here's a couple examples:
$ git grep -E '_(LICENSE_FILES|SUBDIR) =' -- package/samba package/berkeleydb/ package/berkeleydb/berkeleydb.mk:BERKELEYDB_SUBDIR = build_unix package/berkeleydb/berkeleydb.mk:BERKELEYDB_LICENSE_FILES = LICENSE package/samba/samba.mk:SAMBA_SUBDIR = source3 package/samba/samba.mk:SAMBA_LICENSE_FILES = COPYING $Setting
SAMBA_LICENSE_FILESto ../COPYING does not look very nice to me.
D'oh!
Samba is going away, it's already deprecated in favour of samba4, but it still leaves berkeleydb.
Regards.
PATCH 1/1 openvmtools: fix legal info
Dear Gustavo,
Quoted 14 lines · Gustavo Zacarias
Quoted 10 lines · Luca Ceresoli
...we have them! :( Here's a couple examples:
$ git grep -E '_(LICENSE_FILES|SUBDIR) =' -- package/samba package/berkeleydb/ package/berkeleydb/berkeleydb.mk:BERKELEYDB_SUBDIR = build_unix package/berkeleydb/berkeleydb.mk:BERKELEYDB_LICENSE_FILES = LICENSE package/samba/samba.mk:SAMBA_SUBDIR = source3 package/samba/samba.mk:SAMBA_LICENSE_FILES = COPYING $
Quoted 5 lines
Quoted 1 line
Setting
SAMBA_LICENSE_FILESto ../COPYING does not look very nice to me.D'oh!
Samba is going away, it's already deprecated in favour of samba4, but it still leaves berkeleydb.
These are the first two examples I found. Most likely there are more.
Signature · 1 line
Luca
PATCH 1/1 openvmtools: fix legal info
In reply to Gustavo ZacariasDear Gustavo Zacarias,
Quoted 8 lines · Gustavo Zacarias
In
ab71dff0it was moved to SUBDIR, but this was never reflected for the legal-info files, update this to fix:
http://autobuild.buildroot.net/results/836/8363943cc9c967713f585209408ea087a052a12d/Signed-off-by Gustavo Zacarias <[email protected]>--- package/openvmtools/openvmtools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied after adjusting the variable order, as suggested by Yann. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com