force rsync of local package and try to rebuild it with its dependencies
PATCH 1/1 force rsync of local package and try to rebuild it with its dependencies
The purpose of this patch is to force rsync of local site packages and rebuild them if their source code has changed. Therefore, if the source of a package has changed, it will be rebuild if you type make or make <pkg>. Likewise, if a package has a library dependency which is local site package too and you type make <pkg>, the library will be rebuild if the source has been modified.
This behavior is pretty useful if you use buildroot with many of your own packages. Especially if you share these packages with a developer team through a version control system like git.
--- package/pkg-generic.mk | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
package/pkg-generic.mk +7 -3
@@ -102,7 +102,7 @@ $(BUILD_DIR)/%/.stamp_rsynced: @$(call MESSAGE,"Syncing from source dir $(SRCDIR)") @test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1) $(foreach hook,$($(PKG)_PRE_RSYNC_HOOKS),$(call $(hook))$(sep)) - rsync -au $(RSYNC_VCS_EXCLUSIONS) $(SRCDIR)/ $(@D) + rsync -au $(RSYNC_VCS_EXCLUSIONS) --include core $(SRCDIR)/ $(@D) $(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep)) $(Q)touch $@
@@ -458,7 +458,11 @@ $(2)_PRE_LEGAL_INFO_HOOKS ?= $(2)_POST_LEGAL_INFO_HOOKS ?= # human-friendly targets and target sequencing +ifeq ($$($(2)_SITE_METHOD),local) +$(1): $(1)-clean-for-rebuild $(1)-install +else $(1): $(1)-install +endif ifeq ($$($(2)_TYPE),host) $(1)-install: $(1)-install-host
@@ -604,12 +608,12 @@ $(1)-reinstall: $(1)-clean-for-reinstall $(1) $(1)-clean-for-rebuild: $(1)-clean-for-reinstall rm -f $$($(2)_TARGET_BUILD) -$(1)-rebuild: $(1)-clean-for-rebuild $(1) +$(1)-rebuild: $(1)-clean-for-rebuild $(1)-install $(1)-clean-for-reconfigure: $(1)-clean-for-rebuild rm -f $$($(2)_TARGET_CONFIGURE) -$(1)-reconfigure: $(1)-clean-for-reconfigure $(1) +$(1)-reconfigure: $(1)-clean-for-reconfigure $(1)-install # define the PKG variable for all targets, containing the # uppercase package variable prefix
Signature · 1 line
2.1.4
PATCH 1/1 force rsync of local package and try to rebuild it with its dependencies
Dear Anthony Viallard,
Quoted 10 lines · Anthony Viallard
The purpose of this patch is to force rsync of local site packages and rebuild them if their source code has changed. Therefore, if the source of a package has changed, it will be rebuild if you type make or make <pkg>. Likewise, if a package has a library dependency which is local site package too and you type make <pkg>, the library will be rebuild if the source has been modified.
This behavior is pretty useful if you use buildroot with many of your own packages. Especially if you share these packages with a developer team through a version control system like git.
Again, I don't think we want this change in Buildroot. I don't think we want *all* local packages to systematically be rsync'ed and rebuilt, at every "make" invocation.
Maybe we want a separate "make rebuild-local" target (not sure of the name), which would trigger this special action. Local packages could be all registered in a global LOCAL_PACKAGES variable, and make rebuild-local would rebuild them all.
Note that you could also solve this problem by adding something like that in your external.mk (provided you're using BR2_EXTERNAL):
# Needs to be filled in with your complete list of packages CUSTOM_PACKAGES = foo1 foo2 foo3
rebuild-custom: $(foreach p,$(CUSTOM_PACKAGES),$(p))
package/pkg-generic.mk $(BUILD_DIR)/%/.stamp_rsynced: · line 105
Quoted 2 lines
package/pkg-generic.mk +1
-1- rsync -au $(RSYNC_VCS_EXCLUSIONS) $(SRCDIR)/ $(@D) + rsync -au $(RSYNC_VCS_EXCLUSIONS) --include core $(SRCDIR)/ $(@D)
This change is unrelated to the patch I believe.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 force rsync of local package and try to rebuild it with its dependencies
Quoted 10 lines · Thomas Petazzoni
Dear Anthony Viallard,
Quoted 7 lines · Anthony Viallard
The purpose of this patch is to force rsync of local site packages and rebuild them if their source code has changed. Therefore, if the source of a package has changed, it will be rebuild if you type make or make <pkg>. Likewise, if a package has a library dependency which is local site package too and you type make <pkg>, the library will be rebuild if the source has been modified.
Quoted 7 lines
Quoted 3 lines
This behavior is pretty useful if you use buildroot with many of your own packages. Especially if you share these packages with a developer team through a version control system like git.
Again, I don't think we want this change in Buildroot. I don't think we want *all* local packages to systematically be rsync'ed and rebuilt, at every "make" invocation.
Actually, why not? Ideally, we would like to rebuild everything every time -
but that just takes too long. However, we can assume that there aren't so many local packages, so their rebuild does not necessarily take too long.
So I went and did an experiment on my laptop (HDD, 8GB RAM, so relatively
slow): when nothing actually has to be rebuilt, 'make linux-rebuild' takes 40s longer than 'make linux'. (I'm taking linux because that's the one where we can expect the most overhead from rebuilding.) That is the same amount of time as building a small package like xz.
Conclusion: indeed, we shouldn't do rebuilding of local packages by default.
Quoted 8 lines
Maybe we want a separate "make rebuild-local" target (not sure of the name), which would trigger this special action. Local packages could be all registered in a global
LOCAL_PACKAGESvariable, and make rebuild-local would rebuild them all.Note that you could also solve this problem by adding something like that in your external.mk (provided you're using
BR2_EXTERNAL):
Or in your local.mk (BR2_PACKAGE_OVERRIDE_FILE), where you put these overrides.
Quoted 5 lines
# Needs to be filled in with your complete list of packages
CUSTOM_PACKAGES= foo1 foo2 foo3rebuild-custom: $(foreach p,$(CUSTOM_PACKAGES),$(p))
Or if you don't want to call a specific target:
world: $(foreach p,$(CUSTOM_PACKAGES),$(p))
That way, you can just type 'make' and it will rebuild your custom packages.
Quoted 5 lines
package/pkg-generic.mk $(BUILD_DIR)/%/.stamp_rsynced: · line 105
Quoted 3 lines
package/pkg-generic.mk +1
-1- rsync -au $(RSYNC_VCS_EXCLUSIONS) $(SRCDIR)/ $(@D) + rsync -au $(RSYNC_VCS_EXCLUSIONS) --include core $(SRCDIR)/ $(@D)This change is unrelated to the patch I believe.
And it should be added to RSYNC_VCS_EXCLUSIONS instead.
However, why is this even needed? RSYNC_VCS_EXCLUSIONS doesn't exclude any
pattern that matches 'core'.
Regards,
Arnout
Quoted 5 lines
Best regards,
Thomas
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF