Skip to contentSkip to conversation

valgrind: install to staging

PATCH New Vicente Olivert Riera 5 participants 6 messages Jul 2, 2015 – Jul 3, 2015

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/1 valgrind: install to staging

This is necessary for some packages depending on valgrind, such as libdrm which will fail with an error like this one:

checking for VALGRIND... no
checking whether to enable Valgrind support... configure: error:
Valgrind support required but not present package/pkg-generic.mk:146: recipe for target '/br/output/build/libdrm-2.4.62/.stamp_configured' failed

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/valgrind/valgrind.mk | 1 +
 1 file changed, 1 insertion(+)
package/valgrind/valgrind.mk +1 -0
index cfce8da..f8f205e 100644
@@ -11,6 +11,7 @@ VALGRIND_LICENSE = GPLv2 GFDLv1.2
 VALGRIND_LICENSE_FILES = COPYING COPYING.DOCS
 VALGRIND_CONF_OPTS = --disable-tls
 VALGRIND_AUTORECONF = YES
+VALGRIND_INSTALL_STAGING = YES
 
 # On ARM, Valgrind only supports ARMv7, and uses the arch part of the
 # host tuple to determine whether it's being built for ARMv7 or
Signature · 1 line
2.3.6
#1 lore raw

PATCH 1/1 valgrind: install to staging

Vicente, All,

On 2015-07-02 17:52 +0200, Vicente Olivert Riera spake thusly:

Quoted 10 lines

This is necessary for some packages depending on valgrind, such as libdrm which will fail with an error like this one:

checking for VALGRIND... no
checking whether to enable Valgrind support... configure: error:
Valgrind support required but not present package/pkg-generic.mk:146: recipe for target '/br/output/build/libdrm-2.4.62/.stamp_configured' failed

Signed-off-by Vicente Olivert Riera <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 package/valgrind/valgrind.mk | 1 +
 1 file changed, 1 insertion(+)
package/valgrind/valgrind.mk +1 -0
index cfce8da..f8f205e 100644
@@ -11,6 +11,7 @@ VALGRIND_LICENSE = GPLv2 GFDLv1.2
 VALGRIND_LICENSE_FILES = COPYING COPYING.DOCS
 VALGRIND_CONF_OPTS = --disable-tls
 VALGRIND_AUTORECONF = YES
+VALGRIND_INSTALL_STAGING = YES
 
 # On ARM, Valgrind only supports ARMv7, and uses the arch part of the
 # host tuple to determine whether it's being built for ARMv7 or
Signature · 6 lines
2.3.6

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 valgrind: install to staging

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 9 lines · Vicente Olivert Riera

This is necessary for some packages depending on valgrind, such as libdrm which will fail with an error like this one:

checking for VALGRIND... no
checking whether to enable Valgrind support... configure: error:
Valgrind support required but not present package/pkg-generic.mk:146: recipe for target '/br/output/build/libdrm-2.4.62/.stamp_configured' failed

Quoted 4 lines
Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/valgrind/valgrind.mk | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 valgrind: install to staging

In reply to Vicente Olivert Riera
Quoted 19 lines · Vicente Olivert Riera

This is necessary for some packages depending on valgrind, such as libdrm which will fail with an error like this one:

checking for VALGRIND... no
checking whether to enable Valgrind support... configure: error:
Valgrind support required but not present package/pkg-generic.mk:146: recipe for target '/br/output/build/libdrm-2.4.62/.stamp_configured' failed

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/valgrind/valgrind.mk | 1 +
 1 file changed, 1 insertion(+)
package/valgrind/valgrind.mk +0 -0
index cfce8da..f8f205e 100644

package/valgrind/valgrind.mk VALGRIND_LICENSE = GPLv2 GFDLv1.2 · line 14

Quoted 4 lines
package/valgrind/valgrind.mk +1 -0
@@ -11,6 +11,7 @@ VALGRIND_LICENSE = GPLv2 GFDLv1.2
 VALGRIND_LICENSE_FILES = COPYING COPYING.DOCS
 VALGRIND_CONF_OPTS = --disable-tls
 VALGRIND_AUTORECONF = YES
+VALGRIND_INSTALL_STAGING = YES

I wonder, are there going to be a lot of packages that will autodetect valgrind
presence and will now start linking with it?

Regards,
Arnout

Quoted 4 lines
package/valgrind/valgrind.mk +0 -0
 # On ARM, Valgrind only supports ARMv7, and uses the arch part of the
 # host tuple to determine whether it's being built for ARMv7 or
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#4 lore raw

PATCH 1/1 valgrind: install to staging

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 4 lines
package/valgrind/valgrind.mk +0 -0
index cfce8da..f8f205e 100644
Quoted 8 lines
Quoted 5 lines
package/valgrind/valgrind.mk +0 -0
@@ -11,6 +11,7 @@ VALGRIND_LICENSE = GPLv2 GFDLv1.2

VALGRIND_LICENSE_FILES = COPYING COPYING.DOCS
VALGRIND_CONF_OPTS = --disable-tls
VALGRIND_AUTORECONF = YES
+VALGRIND_INSTALL_STAGING = YES

I wonder, are there going to be a lot of packages that will autodetect valgrind
presence and will now start linking with it?

Do programs need to link against valgrind? I thought it only provided a header with some magic macros that somehow would direct valgrind to behave differently, but didn't do anything when not running through valgrind?

In any case, if the user has enabled valgrind, then he/she presumably wants to enable valgrind support in all applicable packages, but we indeed will need to add valgrind as an optional dependency of those.

I don't know how common it is to have explicit valgrind support though, I guess only a few packages have it.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 valgrind: install to staging

Quoted 17 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 4 lines
package/valgrind/valgrind.mk +0 -0
index cfce8da..f8f205e 100644
Quoted 8 lines
Quoted 5 lines
package/valgrind/valgrind.mk +0 -0
@@ -11,6 +11,7 @@ VALGRIND_LICENSE = GPLv2 GFDLv1.2

VALGRIND_LICENSE_FILES = COPYING COPYING.DOCS
VALGRIND_CONF_OPTS = --disable-tls
VALGRIND_AUTORECONF = YES
+VALGRIND_INSTALL_STAGING = YES

I wonder, are there going to be a lot of packages that will autodetect valgrind
presence and will now start linking with it?

Quoted 4 lines

Do programs need to link against valgrind? I thought it only provided a header with some magic macros that somehow would direct valgrind to behave differently, but didn't do anything when not running through valgrind?

I'm not altogether sure, but I thought there were extra functions you could
call when running through valgrind (these functions are in fact inline and detect whether you're running under valgrind or not). But you can only use these functions when valgrind headers are available, so a program that wants to use them will be slightly different when valgrind headers are available.

The problem I'm worried about is reproducible builds, of course. When valgrind
happens to be built earlier than your program, it will be different than when the program is built first.

Of course, Fabio's per-package staging patch series (which I really should
review...) will fix all that!

Quoted 6 lines

In any case, if the user has enabled valgrind, then he/she presumably wants to enable valgrind support in all applicable packages, but we indeed will need to add valgrind as an optional dependency of those.

I don't know how common it is to have explicit valgrind support though, I guess only a few packages have it.

Probably, yes. But one or two, or a few dozen? That's a big difference...
Perhaps someone who has all packages extracted could grep for valgrind in them?

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF