Skip to contentSkip to conversation

ibqueryerrors: code improvement

PATCH Applied Hal Rosenstock 2 participants 2 messages Apr 26, 2015 – Jul 3, 2015 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH 4/4 ibqueryerrors: code improvement

From: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Date: Sun, 26 Apr 2015 18:29:31 +0300

goto is performed after IBEXIT call

Signed-off-by Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>
---
 src/ibqueryerrors.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
src/ibqueryerrors.c +0 -1
index 398e2a7..bdae156 100644
@@ -1011,7 +1011,6 @@ int main(int argc, char **argv)
 	if (resolve_self(ibd_ca, ibd_ca_port, &self_portid, &port, &self_gid.raw) < 0) {
 		mad_rpc_close_port(ibmad_port);
 		IBEXIT("can't resolve self port %s", argv[0]);
-		goto close_port;
 	}
 
 	node_name_map = open_node_name_map(node_name_map_file);
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 553D3DA9.1080507-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

#2 lore raw
Quoted 7 lines · Hal Rosenstock

From: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Date: Sun, 26 Apr 2015 18:29:31 +0300

goto is performed after IBEXIT call

Signed-off-by Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks I applied this earlier in the series because I wanted to fix up the goto labels in your other patch.

Ira

Quoted 19 lines
---
 src/ibqueryerrors.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
src/ibqueryerrors.c +0 -1
index 398e2a7..bdae156 100644
@@ -1011,7 +1011,6 @@ int main(int argc, char **argv)
 	if (resolve_self(ibd_ca, ibd_ca_port, &self_portid, &port, &self_gid.raw) < 0) {
 		mad_rpc_close_port(ibmad_port);
 		IBEXIT("can't resolve self port %s", argv[0]);
-		goto close_port;
 	}
 
 	node_name_map = open_node_name_map(node_name_map_file);
Signature · 1 line
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html