Skip to contentSkip to conversation

ibqueryerrors: Fix crash when no SM is running

PATCH Applied Hal Rosenstock 2 participants 2 messages Apr 26, 2015 – Jul 3, 2015 1 message not in the archive InfiniBand

lore
Share & tools
lore

Hal Rosenstock

author
#0 lore raw

PATCH v2 1/4 ibqueryerrors: Fix crash when no SM is running

From: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Date: Tue, 21 Apr 2015 17:12:05 +0300

Handle sa_get_handle error in path_record_query

Signed-off-by Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

---
Changes since v1:
Added my signoff on this patch

 src/ibqueryerrors.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
src/ibqueryerrors.c +3 -1
index 8fbb9d1..97a555d 100644
@@ -326,7 +326,9 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
      uint8_t reversible = 0;
      struct sa_handle * h;
 
-     h = sa_get_handle();
+     if (!(h = sa_get_handle()))
+	return -1;
+
      ibd_timeout = DEFAULT_HALF_WORLD_PR_TIMEOUT;
      memset(&pr, 0, sizeof(pr));
Signature · 6 lines
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 553D3D98.3040905-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org

Applied
#2 lore raw
Quoted 7 lines · Hal Rosenstock

From: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Date: Tue, 21 Apr 2015 17:12:05 +0300

Handle sa_get_handle error in path_record_query

Signed-off-by Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/[email protected]>
Signed-off-by Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/[email protected]>

Thanks applied,
Ira

Quoted 25 lines

---
Changes since v1:
Added my signoff on this patch

 src/ibqueryerrors.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
src/ibqueryerrors.c +3 -1
index 8fbb9d1..97a555d 100644
@@ -326,7 +326,9 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
      uint8_t reversible = 0;
      struct sa_handle * h;
 
-     h = sa_get_handle();
+     if (!(h = sa_get_handle()))
+	return -1;
+
      ibd_timeout = DEFAULT_HALF_WORLD_PR_TIMEOUT;
      memset(&pr, 0, sizeof(pr));
Signature · 1 line
1.7.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html