drm/i915: set FDI translations to NULL on SKL
Subsystems (2)
PATCH 1/1 drm/i915: set FDI translations to NULL on SKL
From: Paulo Zanoni <[email protected]>
drivers/gpu/drm/i915/intel_ddi.c: In function ‘intel_prepare_ddi’:drivers/gpu/drm/i915/intel_ddi.c:517:6: warning:
‘ddi_translations_fdi’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (ddi_translations_fdi)
^
drivers/gpu/drm/i915/intel_ddi.c:446:30: note: ‘ddi_translations_fdi’
was declared here
const struct ddi_buf_trans *ddi_translations_fdi;
^This line used to be there, but was removed by:
commit f8896f5d58e64bfd3c2b5f7c5ba5c3f3967e93c7
Author: David Weinehall <[email protected]> Date: Thu Jun 25 11:11:03 2015 +030
drm/i915/skl: Buffer translation improvements
--- drivers/gpu/drm/i915/intel_ddi.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_ddi.c +1 -0
@@ -458,6 +458,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port, INTEL_OUTPUT_HDMI);return ; }else if (IS_SKYLAKE (dev)) { + ddi_translations_fdi =NULL ; ddi_translations_dp =skl_get_buf_trans_dp (dev, &n_dp_entries); ddi_translations_edp =
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 15 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
drivers/gpu/drm/i915/intel_ddi.c: In function ‘intel_prepare_ddi’:drivers/gpu/drm/i915/intel_ddi.c:517:6: warning:
‘ddi_translations_fdi’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (ddi_translations_fdi)^ drivers/gpu/drm/i915/intel_ddi.c:446:30: note: ‘ddi_translations_fdi’ was declared here const struct ddi_buf_trans *ddi_translations_fdi; ^This line used to be there, but was removed by:
Quoted 7 lines
commit
f8896f5d58e64bfd3c2b5f7c5ba5c3f3967e93c7Author: David Weinehall <[email protected]> Date: Thu Jun 25 11:11:03 2015 +030drm/i915/skl: Buffer translation improvements
Cc David Weinehall <[email protected]>Signed-off-by Paulo Zanoni <[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Quoted 23 lines
--- drivers/gpu/drm/i915/intel_ddi.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/intel_ddi.c +1
-0@@ -458,6 +458,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port, INTEL_OUTPUT_HDMI);return ; }else if (IS_SKYLAKE (dev)) { + ddi_translations_fdi =NULL ; ddi_translations_dp =skl_get_buf_trans_dp (dev, &n_dp_entries); ddi_translations_edp =Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
drivers/gpu/drm/i915/intel_ddi.c: In function ‘intel_prepare_ddi’:drivers/gpu/drm/i915/intel_ddi.c:517:6: warning:
‘ddi_translations_fdi’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (ddi_translations_fdi)^
drivers/gpu/drm/i915/intel_ddi.c:446:30: note: ‘ddi_translations_fdi’ was declared here
const structddi_buf_trans*ddi_translations_fdi;
Thanks for noticing! Weird -- and embarassing -- that I missed this :S
Kind regards, David
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · David Weinehall
Quoted 11 lines · Paulo Zanoni
From: Paulo Zanoni <[email protected]>
drivers/gpu/drm/i915/intel_ddi.c: In function ‘intel_prepare_ddi’:drivers/gpu/drm/i915/intel_ddi.c:517:6: warning:
‘ddi_translations_fdi’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (ddi_translations_fdi)^
drivers/gpu/drm/i915/intel_ddi.c:446:30: note: ‘ddi_translations_fdi’ was declared here
const structddi_buf_trans*ddi_translations_fdi;
Quoted 1 line
Thanks for noticing! Weird -- and embarassing -- that I missed this :S
Create a personal public git repo somewhere, tell the 0-day folks about it and just wait a few hours before hitting send. You _will_ reliable get reports about this stuff before I get them when I apply the patch ;-) -Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx