rx51-battery.ko incompatiblity: board code vs DT
Hello,
now I found out that rx51-battery.ko driver register sysnode /sys/class/power_supply/rx51-battery/ when booting with legacy board code. But when booting DT kernel it register sysnode with different name /sys/class/power_supply/n900-battery/
Sysfs node for DT kernel comes from Nokia N900 DTS file:arch/arm/boot/dts/omap3-n900.dts
I would propose change which change DTS to "rx51-battery" to have it compatible with naming which is for legacy board code. It is just because to have compatibility and same naming scheme and also to make existing programs to work without needing patching them.
What do you think?
Signature · 2 lines
Pali Rohár [email protected]
Quoted 10 lines · Pali Rohár
Hello,
now I found out that rx51-battery.ko driver register sysnode
/sys/class/power_supply/rx51-battery/when booting with legacy board code. But when booting DT kernel it register sysnode with different name/sys/class/power_supply/n900-battery/Sysfs node for DT kernel comes from Nokia N900 DTS file:
arch/arm/boot/dts/omap3-n900.dts
Quoted 6 lines
I would propose change which change DTS to "rx51-battery" to have it compatible with naming which is for legacy board code. It is just because to have compatibility and same naming scheme and also to make existing programs to work without needing patching them.
What do you think?
Makes sense.. along with _big_ comment in the dts why we are doing this.
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi,
Quoted 8 lines · Pali Rohár
now I found out that rx51-battery.ko driver register sysnode
/sys/class/power_supply/rx51-battery/when booting with legacy board code. But when booting DT kernel it register sysnode with different name/sys/class/power_supply/n900-battery/Sysfs node for DT kernel comes from Nokia N900 DTS file:
arch/arm/boot/dts/omap3-n900.dts
Quoted 6 lines
I would propose change which change DTS to "rx51-battery" to have it compatible with naming which is for legacy board code. It is just because to have compatibility and same naming scheme and also to make existing programs to work without needing patching them.
What do you think?
Change the driver instead (in rx51_battery_probe):
- di->bat.name = dev_name(&pdev->dev);
+ di->bat.name = "rx51-battery"
This will keep the DT ABI stable and avoid introducing the term rx51 in the device tree file.
-- Sebastian
Quoted 23 lines · On Tuesday 07 July 2015 17:02:30 Sebastian Reichel wrote:
Hi,
Quoted 8 lines · Pali Rohár
now I found out that rx51-battery.ko driver register sysnode
/sys/class/power_supply/rx51-battery/when booting with legacy board code. But when booting DT kernel it register sysnode with different name/sys/class/power_supply/n900-battery/Sysfs node for DT kernel comes from Nokia N900 DTS file:
arch/arm/boot/dts/omap3-n900.dtsQuoted 6 lines
I would propose change which change DTS to "rx51-battery" to have it compatible with naming which is for legacy board code. It is just because to have compatibility and same naming scheme and also to make existing programs to work without needing patching them.
What do you think?
Change the driver instead (in
rx51_battery_probe):(quoted diff) +1
-1- di->bat.name = dev_name(&pdev->dev); + di->bat.name = "rx51-battery"
Quoted 4 lines
This will keep the DT ABI stable and avoid introducing the term rx51 in the device tree file.
-- Sebastian
Perfect, if it works fine can you send & apply patch?
Signature · 2 lines
Pali Rohár [email protected]