ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

PATCH New Geert Uytterhoeven 4 participants 10 messages Jul 6, 2015 – Aug 14, 2015

Subsystems (3)

Device tree bindings HID SuperH

lore

Share & tools

lore

Geert Uytterhoeven

author

2015-07-06 10:55 UTC #0 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").

Signed-off-by Geert Uytterhoeven <[email protected]>

---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.

This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".

v2:
- Drop deprecated "adi,adxl34x"

---
 arch/arm/boot/dts/sh73a0-kzm9g.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/sh73a0-kzm9g.dts +1 -1

index 24b4cd24dceb2f9e..7fc5602810ad0da1 100644
@@ -206,7 +206,7 @@
 	};
 
 	accelerometer at 1d {
-		compatible = "adi,adxl34x";
+		compatible = "adi,adxl345";
 		reg = <0x1d>;
 		interrupt-parent = <&irqpin3>;
 		interrupts = <2 IRQ_TYPE_LEVEL_HIGH>,

Signature · 1 line

1.9.1

Laurent Pinchart

2015-07-06 13:29 UTC #1 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Hi Geert,

Thank you for the patch.

Quoted 5 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:

Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>

Acked-by Laurent Pinchart <[email protected]>

Quoted 27 lines

---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".
v2:
- Drop deprecated "adi,adxl34x"
---
 arch/arm/boot/dts/sh73a0-kzm9g.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/arch/arm/boot/dts/sh73a0-kzm9g.dts index
24b4cd24dceb2f9e..7fc5602810ad0da1 100644
arch/arm/boot/dts/sh73a0-kzm9g.dts +1 -1
@@ -206,7 +206,7 @@
 	};
 
 	accelerometer at 1d {
-		compatible = "adi,adxl34x";
+		compatible = "adi,adxl345";
 		reg = <0x1d>;
 		interrupt-parent = <&irqpin3>;
 		interrupts = <2 IRQ_TYPE_LEVEL_HIGH>,

Signature · 3 lines

Regards,

Laurent Pinchart

Simon Horman

2015-07-07 00:26 UTC #2 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Quoted 4 lines · Laurent Pinchart

Hi Geert,
Thank you for the patch.

Quoted 15 lines

Quoted 5 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 6 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".

It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.

Quoted 26 lines

Quoted 20 lines
v2:
- Drop deprecated "adi,adxl34x"
---
 arch/arm/boot/dts/sh73a0-kzm9g.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/arch/arm/boot/dts/sh73a0-kzm9g.dts index
24b4cd24dceb2f9e..7fc5602810ad0da1 100644
arch/arm/boot/dts/sh73a0-kzm9g.dts +1 -1
@@ -206,7 +206,7 @@
 	};
 
 	accelerometer at 1d {
-		compatible = "adi,adxl34x";
+		compatible = "adi,adxl345";
 		reg = <0x1d>;
 		interrupt-parent = <&irqpin3>;
 		interrupts = <2 IRQ_TYPE_LEVEL_HIGH>,
Signature · 3 lines
Regards,

Laurent Pinchart

Laurent Pinchart

2015-07-07 06:56 UTC #3 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Hi Simon,

Quoted 14 lines · On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:

Quoted 13 lines · Laurent Pinchart
Quoted 5 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 4 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.

Quoted 7 lines

Quoted 2 lines
Quoted 2 lines
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".
It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.

That's the forward compatibility that Geert mentioned, is that really an issue, especially on this board ?

Quoted 22 lines

Quoted 22 lines
Quoted 22 lines
v2:
- Drop deprecated "adi,adxl34x"
---
 arch/arm/boot/dts/sh73a0-kzm9g.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/arch/arm/boot/dts/sh73a0-kzm9g.dts index
24b4cd24dceb2f9e..7fc5602810ad0da1 100644
arch/arm/boot/dts/sh73a0-kzm9g.dts +1 -1
@@ -206,7 +206,7 @@
 	};
 
 	accelerometer at 1d {
-		compatible = "adi,adxl34x";
+		compatible = "adi,adxl345";
 		reg = <0x1d>;
 		interrupt-parent = <&irqpin3>;
 		interrupts = <2 IRQ_TYPE_LEVEL_HIGH>,

Signature · 3 lines

Regards,

Laurent Pinchart

Simon Horman

2015-07-08 00:51 UTC #4 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Quoted 20 lines · Laurent Pinchart

Hi Simon,
Quoted 17 lines · On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
Quoted 15 lines · Laurent Pinchart
Quoted 5 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 6 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".

Quoted 7 lines

Quoted 4 lines
It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.
That's the forward compatibility that Geert mentioned, is that really an issue, especially on this board ?

I think it would be best to provide backwards compatibility unless there is a compelling reason not to.

Simon Horman

2015-08-13 00:05 UTC #5 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Quoted 26 lines · Simon Horman

Quoted 25 lines · Laurent Pinchart
Hi Simon,
Quoted 21 lines · On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
Quoted 15 lines · Laurent Pinchart
Quoted 5 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 6 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".
It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.

Quoted 5 lines

Quoted 2 lines
That's the forward compatibility that Geert mentioned, is that really an issue, especially on this board ?
I think it would be best to provide backwards compatibility unless there is a compelling reason not to.

I would like to revisit this discussion with a view to getting some version of this patch queued up (yes I know I pushed back on it earlier in this thread).

Geert Uytterhoeven

2015-08-13 09:26 UTC #6 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Hi Simon,

Quoted 25 lines · Simon Horman

Quoted 24 lines · Simon Horman
Quoted 23 lines · Laurent Pinchart
Quoted 21 lines · On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
Quoted 15 lines · Laurent Pinchart
Quoted 5 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 6 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".
It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
That's the forward compatibility that Geert mentioned, is that really an issue, especially on this board ?
I think it would be best to provide backwards compatibility unless there is a compelling reason not to.
I would like to revisit this discussion with a view to getting some version of this patch queued up (yes I know I pushed back on it earlier in this thread).

I'm fine with applying v1.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Laurent Pinchart

2015-08-13 21:31 UTC #7 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Quoted 31 lines · On Thursday 13 August 2015 11:26:32 Geert Uytterhoeven wrote:

Quoted 30 lines · Simon Horman
Quoted 29 lines · Simon Horman
Quoted 27 lines · Laurent Pinchart
Quoted 16 lines · On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
Quoted 15 lines · Laurent Pinchart
Quoted 6 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by: Laurent Pinchart
<[email protected]>
Quoted 4 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".
It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.
That's the forward compatibility that Geert mentioned, is that really an issue, especially on this board ?

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
I think it would be best to provide backwards compatibility unless there is a compelling reason not to.
I would like to revisit this discussion with a view to getting some version of this patch queued up (yes I know I pushed back on it earlier in this thread).
I'm fine with applying v1.

And I'm quite unsurprisingly not, as I've asked for a v2.

The "adi,adxl34x" compatible string is deprecated. That means we still support it in the driver for device trees that haven't been updated, but it shouldn't be used forward by new device trees. That's why the device tree sources contained in the kernel shouldn't use it, especially given that they often serve as references for device trees shipped out of tree.

Signature · 3 lines

Regards,

Laurent Pinchart

Simon Horman

2015-08-14 04:54 UTC #8 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Quoted 41 lines · Laurent Pinchart

Quoted 31 lines · On Thursday 13 August 2015 11:26:32 Geert Uytterhoeven wrote:
Quoted 30 lines · Simon Horman
Quoted 29 lines · Simon Horman
Quoted 27 lines · Laurent Pinchart
Quoted 16 lines · On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
Quoted 15 lines · Laurent Pinchart
Quoted 6 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by: Laurent Pinchart
<[email protected]>
Quoted 4 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".
It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.
That's the forward compatibility that Geert mentioned, is that really an issue, especially on this board ?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
I think it would be best to provide backwards compatibility unless there is a compelling reason not to.
I would like to revisit this discussion with a view to getting some version of this patch queued up (yes I know I pushed back on it earlier in this thread).
I'm fine with applying v1.

Quoted 7 lines

And I'm quite unsurprisingly not, as I've asked for a v2.
The "adi,adxl34x" compatible string is deprecated. That means we still support it in the driver for device trees that haven't been updated, but it shouldn't be used forward by new device trees. That's why the device tree sources contained in the kernel shouldn't use it, especially given that they often serve as references for device trees shipped out of tree.

Thanks, I see your point now. I have queued up v2.

Laurent Pinchart

2015-08-14 05:17 UTC #9 lore raw

PATCH v2 1/1 ARM: shmobile: kzm9g dts: Use adxl345-specific compatible property

Hi Simon,

Quoted 44 lines · On Friday 14 August 2015 13:54:16 Simon Horman wrote:

Quoted 43 lines · Laurent Pinchart
Quoted 31 lines · On Thursday 13 August 2015 11:26:32 Geert Uytterhoeven wrote:
Quoted 30 lines · Simon Horman
Quoted 29 lines · Simon Horman
Quoted 27 lines · Laurent Pinchart
Quoted 16 lines · On Tuesday 07 July 2015 09:26:21 Simon Horman wrote:
Quoted 15 lines · Laurent Pinchart
Quoted 6 lines · On Monday 06 July 2015 12:55:32 Geert Uytterhoeven wrote:
Replace the deprecated generic "adi,adxl34x" compatible value by the adxl345-specific "adi,adxl345" value, cfr. commit e465bf6fc55d5ce2 ("DT:
i2c: Deprecate adi,adxl34x compatible string").
Signed-off-by Geert Uytterhoeven <[email protected]>
Acked-by: Laurent Pinchart
<[email protected]>
Quoted 4 lines
---
Depends on commit 3a38958d2477b718 ("Input: adxl34x - add OF match support"), which is in v4.2-rc1.
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
This is v2 of "ARM: shmobile: kzm9g dts: Add adxl345-specific compatible property".
It appears to me that this will cause a regression when booting old kernels with new dts blobs. For that reason think we should consider v1 of this change coupled with a schedule to remove use of the deprecated compat string.
That's the forward compatibility that Geert mentioned, is that really an issue, especially on this board ?
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
I think it would be best to provide backwards compatibility unless there is a compelling reason not to.
I would like to revisit this discussion with a view to getting some version of this patch queued up (yes I know I pushed back on it earlier in this thread).
I'm fine with applying v1.
And I'm quite unsurprisingly not, as I've asked for a v2.

Quoted 7 lines

Quoted 5 lines
The "adi,adxl34x" compatible string is deprecated. That means we still support it in the driver for device trees that haven't been updated, but it shouldn't be used forward by new device trees. That's why the device tree sources contained in the kernel shouldn't use it, especially given that they often serve as references for device trees shipped out of tree.
Thanks, I see your point now. I have queued up v2.

Thank you :-)

Signature · 3 lines

Regards,

Laurent Pinchart