BUG? Duplicate key code 0xe045 in dell-wmi.c
Hello,
I'm looking at dell-wmi.c driver and its history in git and I found problem with handling WMI key code 0xe045. In current dell-wmi.c code is
{KE_KEY, 0xe045, KEY_PROG1},
{KE_IGNORE, 0xe045, KEY_NUMLOCK},
I bet this is some copy-paste error as one code can be translated only to one input key event.
In git history I found that above change was added by commit:
===============================================
commit 5cab0098171712a9fd51399b06181c8dfdebe9c9
Author: Mario Limonciello <[email protected]> Date: Wed Jun 10 19:40:47 2009 +0000
dell-wmi: add additional keyboard events
Upcoming Dell hardware will send more keyboard events via WMI. Add support for them.
===============================================
Sending email to all signers of this commit. Problematic code is still in upstream kernel, so it needs to be fixed.
Mario Limonciello: Do you know if code 0xe045 is some PROG1 or NUMLOCK?
Signature · 2 lines
Pali Rohár [email protected]
Quoted 29 lines · Pali Rohár
Hello,
I'm looking at
dell-wmi.cdriver and its history in git and I found problem with handling WMI key code0xe045. In currentdell-wmi.ccode is{
KE_KEY,0xe045,KEY_PROG1},
{KE_IGNORE,0xe045,KEY_NUMLOCK},I bet this is some copy-paste error as one code can be translated only to one input key event.
In git history I found that above change was added by commit:
===============================================
commit5cab0098171712a9fd51399b06181c8dfdebe9c9Author: Mario Limonciello <[email protected]> Date: Wed Jun 10 19:40:47 2009 +0000dell-wmi: add additional keyboard events
Upcoming Dell hardware will send more keyboard events via WMI. Add support for them.
Signed-off-by Mario Limonciello <[email protected]>Signed-off-by Matthew Garrett <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Len Brown <[email protected]>
Quoted 7 lines
===============================================
Sending email to all signers of this commit. Problematic code is still in upstream kernel, so it needs to be fixed.
Mario Limonciello: Do you know if code
0xe045is some PROG1 or NUMLOCK?
Hi Pali,
Yes this looks like a mistake and that the KEY_PROG1 item should have been removed in that patch. It should be a notification (KEY_IGNORE) for numlock.
Thanks,
Quoted 39 lines · On Tuesday 07 July 2015 13:38:41 Mario Limonciello wrote:
Quoted 29 lines · Pali Rohár
Hello,
I'm looking at
dell-wmi.cdriver and its history in git and I found problem with handling WMI key code0xe045. In currentdell-wmi.ccode is{
KE_KEY,0xe045,KEY_PROG1},
{KE_IGNORE,0xe045,KEY_NUMLOCK},I bet this is some copy-paste error as one code can be translated only to one input key event.
In git history I found that above change was added by commit:
===============================================
commit5cab0098171712a9fd51399b06181c8dfdebe9c9Author: Mario Limonciello <[email protected]> Date: Wed Jun 10 19:40:47 2009 +0000dell-wmi: add additional keyboard events
Upcoming Dell hardware will send more keyboard events via WMI. Add support for them.
Signed-off-by Mario Limonciello <[email protected]>Signed-off-by Matthew Garrett <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Len Brown <[email protected]>Quoted 7 lines
===============================================
Sending email to all signers of this commit. Problematic code is still in upstream kernel, so it needs to be fixed.
Mario Limonciello: Do you know if code
0xe045is some PROG1 or NUMLOCK?
Quoted 7 lines
Hi Pali,
Yes this looks like a mistake and that the
KEY_PROG1item should have been removed in that patch. It should be a notification (KEY_IGNORE) for numlock.Thanks,
Hi, I looked into git history of dell-wmi more deeply... into first commit of dell-wmi.c source code. It is this one from year 2009:
Here Matthew Garrett says:
... send a generic input event when a button with a picture of a battery on it is pressed ...
and adds code:
+static struct key_entry dell_wmi_keymap[] = {
+ {KE_KEY, 0xe045, KEY_PROG1},
+ {KE_END, 0}
+};
So basically when "picture of a battery" is pressed WMI send event 0xe045 which is translated to KEY_PROG1.
Matthew Garrett is original author of that code and I believe that on some his machine 0xe045 code from DELL WMI really could be sent when battery button is pressed.
Mario, if you as Dell authority says that 0xe045 is sent when numlock is pressed, it means either code 0xe045 is ambiguous :-( and has different meaning for different machines or there is error in (your) documentation or bios... or Matthew cannot differ between picture of battery and picture of numlock on his dell machine :-)
Matthew: If you still reading this email thread, do you know for which Dell machine did you write this dell-wmi.c driver originally?
Mario: Do you know more about this problem?
From function sparse_keymap_setup() called by dell-wmi.c this structure:
{KE_KEY, 0xe045, KEY_PROG1},
{KE_IGNORE, 0xe045, KEY_NUMLOCK},
is decoded that 0xe045 event is *not* ignored and reports KEY_PROG1 key.
Signature · 2 lines
Pali Rohár [email protected]
Quoted 84 lines · On Tuesday 07 July 2015 23:18:48 Pali Rohár wrote:
Quoted 39 lines · On Tuesday 07 July 2015 13:38:41 Mario Limonciello wrote:
Quoted 29 lines · Pali Rohár
Hello,
I'm looking at
dell-wmi.cdriver and its history in git and I found problem with handling WMI key code0xe045. In currentdell-wmi.ccode is{
KE_KEY,0xe045,KEY_PROG1},
{KE_IGNORE,0xe045,KEY_NUMLOCK},I bet this is some copy-paste error as one code can be translated only to one input key event.
In git history I found that above change was added by commit:
===============================================
commit5cab0098171712a9fd51399b06181c8dfdebe9c9Author: Mario Limonciello <[email protected]> Date: Wed Jun 10 19:40:47 2009 +0000dell-wmi: add additional keyboard events
Upcoming Dell hardware will send more keyboard events via WMI. Add support for them.
Signed-off-by Mario Limonciello <[email protected]>Signed-off-by Matthew Garrett <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Len Brown <[email protected]>Quoted 7 lines
===============================================
Sending email to all signers of this commit. Problematic code is still in upstream kernel, so it needs to be fixed.
Mario Limonciello: Do you know if code
0xe045is some PROG1 or NUMLOCK?Quoted 7 lines
Hi Pali,
Yes this looks like a mistake and that the
KEY_PROG1item should have been removed in that patch. It should be a notification (KEY_IGNORE) for numlock.Thanks,
Hi, I looked into git history of dell-wmi more deeply... into first commit of
dell-wmi.csource code. It is this one from year 2009:Here Matthew Garrett says:
... send a generic input event when a button with a picture of a battery on it is pressed ...
and adds code:
(quoted diff) +4
-0+static struct key_entry dell_wmi_keymap[] = { + {KE_KEY, 0xe045, KEY_PROG1}, + {KE_END, 0} +};So basically when "picture of a battery" is pressed WMI send event
0xe045which is translated toKEY_PROG1.Matthew Garrett is original author of that code and I believe that on some his machine
0xe045code from DELL WMI really could be sent when battery button is pressed.Mario, if you as Dell authority says that
0xe045is sent when numlock is pressed, it means either code0xe045is ambiguous :-( and has different meaning for different machines or there is error in (your) documentation or bios... or Matthew cannot differ between picture of battery and picture of numlock on his dell machine :-)Matthew: If you still reading this email thread, do you know for which Dell machine did you write this
dell-wmi.cdriver originally?Mario: Do you know more about this problem?
Quoted 7 lines
From function
sparse_keymap_setup()called bydell-wmi.cthis structure:{
KE_KEY,0xe045,KEY_PROG1},
{KE_IGNORE,0xe045,KEY_NUMLOCK},is decoded that
0xe045event is *not* ignored and reportsKEY_PROG1key.
Mario & Matthew: ping
Signature · 2 lines
Pali Rohár [email protected]
Quoted 84 lines · On Tuesday 07 July 2015 23:18:48 Pali Rohár wrote:
Quoted 39 lines · On Tuesday 07 July 2015 13:38:41 Mario Limonciello wrote:
Quoted 29 lines · Pali Rohár
Hello,
I'm looking at
dell-wmi.cdriver and its history in git and I found problem with handling WMI key code0xe045. In currentdell-wmi.ccode is{
KE_KEY,0xe045,KEY_PROG1},
{KE_IGNORE,0xe045,KEY_NUMLOCK},I bet this is some copy-paste error as one code can be translated only to one input key event.
In git history I found that above change was added by commit:
===============================================
commit5cab0098171712a9fd51399b06181c8dfdebe9c9Author: Mario Limonciello <[email protected]> Date: Wed Jun 10 19:40:47 2009 +0000dell-wmi: add additional keyboard events
Upcoming Dell hardware will send more keyboard events via WMI. Add support for them.
Signed-off-by Mario Limonciello <[email protected]>Signed-off-by Matthew Garrett <[email protected]>Signed-off-by Andrew Morton <[email protected]>Signed-off-by Len Brown <[email protected]>Quoted 7 lines
===============================================
Sending email to all signers of this commit. Problematic code is still in upstream kernel, so it needs to be fixed.
Mario Limonciello: Do you know if code
0xe045is some PROG1 or NUMLOCK?Quoted 7 lines
Hi Pali,
Yes this looks like a mistake and that the
KEY_PROG1item should have been removed in that patch. It should be a notification (KEY_IGNORE) for numlock.Thanks,
Hi, I looked into git history of dell-wmi more deeply... into first commit of
dell-wmi.csource code. It is this one from year 2009:Here Matthew Garrett says:
... send a generic input event when a button with a picture of a battery on it is pressed ...
and adds code:
(quoted diff) +4
-0+static struct key_entry dell_wmi_keymap[] = { + {KE_KEY, 0xe045, KEY_PROG1}, + {KE_END, 0} +};So basically when "picture of a battery" is pressed WMI send event
0xe045which is translated toKEY_PROG1.Matthew Garrett is original author of that code and I believe that on some his machine
0xe045code from DELL WMI really could be sent when battery button is pressed.Mario, if you as Dell authority says that
0xe045is sent when numlock is pressed, it means either code0xe045is ambiguous :-( and has different meaning for different machines or there is error in (your) documentation or bios... or Matthew cannot differ between picture of battery and picture of numlock on his dell machine :-)Matthew: If you still reading this email thread, do you know for which Dell machine did you write this
dell-wmi.cdriver originally?Mario: Do you know more about this problem?
Quoted 7 lines
From function
sparse_keymap_setup()called bydell-wmi.cthis structure:{
KE_KEY,0xe045,KEY_PROG1},
{KE_IGNORE,0xe045,KEY_NUMLOCK},is decoded that
0xe045event is *not* ignored and reportsKEY_PROG1key.
Hi Mario! Can you comment something about that KEY_PROG1?
Signature · 2 lines
Pali Rohár [email protected]