ixgbe: fix bounds checking in ixgbe_setup_tc for 82598
Subsystems (2)
PATCH 1/1 ixgbe: fix bounds checking in ixgbe_setup_tc for 82598
This patch resolves an issue where users were not able to dynamically set number of queues for 82598 via ethtool -L
Signed-off-by Emil Tantilov <[email protected]>
Reported-by Tal Abudi <[email protected]>
--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +4 -3
@@ -7863,9 +7863,10 @@ int ixgbe_setup_tc(struct net_device *dev, u8 tc)bool pools;/* Hardware supports up to 8 traffic classes */ -if (tc > adapter->dcb_cfg.num_tcs.pg_tcs || - (hw->mac.type == ixgbe_mac_82598EB && - tc <MAX_TRAFFIC_CLASS )) +if (tc > adapter->dcb_cfg.num_tcs.pg_tcs) +return -EINVAL ; + +if (hw->mac.type == ixgbe_mac_82598EB && tc && tc <MAX_TRAFFIC_CLASS )return -EINVAL ; pools = (find_first_zero_bit (&adapter->fwd_bitmask,32 ) >1 );