Skip to contentSkip to conversation

parse_integer: add checkpatch.pl notice

PATCH New Alexey Dobriyan 1 participant 1 message Jul 10, 2015 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 parse_integer: add checkpatch.pl notice

* remove check for strict_strto*(), they were fully removed long ago,

* add check for simple_strto*(), suggest replacements

sscanf() is a bit icky to suggest because it accepts arbitrary amount of whitespace before any integer conversion, but assume programmer knows such twist and don't use sscanf() where real strictness is required (yes, sure...).

---

 scripts/checkpatch.pl |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +3 -3
@@ -5498,10 +5498,10 @@ sub process {
 			     "consider using a completion\n" . $herecurr);
 		}
 
-# recommend kstrto* over simple_strto* and strict_strto*
-		if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
+# simple_strto*() is deprecated
+		if ($line =~ /\b(simple_strto(l|ll|ul|ull))\s*\(/) {
 			WARN("CONSIDER_KSTRTO",
-			     "$1 is obsolete, use k$3 instead\n" . $herecurr);
+			     "$1 is obsolete, use parse_integer(), kstrto*(), kstrto*_from_user(), sscanf() instead\n" . $herecurr);
 		}
 
 # check for __initcall(), use device_initcall() explicitly or more appropriate function please