Skip to contentSkip to conversation

net/xen-netback: off by one in BUG_ON() condition

PATCH In review Dan Carpenter 2 participants 3 messages Jul 11, 2015 – Jul 14, 2015

Subsystems (4)
Networking Network drivers Kernel janitors Xen network backend driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 net/xen-netback: off by one in BUG_ON() condition

The > should be >=. I also added spaces around the '-' operations so the code is a little more consistent and matches the condition better.

Fixes f53c3fe8dad7 ('xen-netback: Introduce TX grant mapping')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/xen-netback/netback.c +1 -3
index 880d0d6..7d50711 100644
@@ -1566,13 +1566,13 @@ static inline void xenvif_tx_dealloc_action(struct xenvif_queue *queue)
 		smp_rmb();
 
 		while (dc != dp) {
-			BUG_ON(gop - queue->tx_unmap_ops > MAX_PENDING_REQS);
+			BUG_ON(gop - queue->tx_unmap_ops >= MAX_PENDING_REQS);
 			pending_idx  				queue->dealloc_ring[pending_index(dc++)];
 
-			pending_idx_release[gop-queue->tx_unmap_ops] +			pending_idx_release[gop - queue->tx_unmap_ops]  				pending_idx;
-			queue->pages_to_unmap[gop-queue->tx_unmap_ops] +			queue->pages_to_unmap[gop - queue->tx_unmap_ops]  				queue->mmap_pages[pending_idx];
 			gnttab_set_unmap_op(gop,
 					    idx_to_kaddr(queue, pending_idx),
maintainer
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Sun, 12 Jul 2015 01:20:55 +0300

Quoted 5 lines

The > should be >=. I also added spaces around the '-' operations so the code is a little more consistent and matches the condition better.

Fixes f53c3fe8dad7 ('xen-netback: Introduce TX grant mapping')
Signed-off-by Dan Carpenter <[email protected]>

Applied and queued up for -stable, thanks.