metag/irq: Use access helper irq_data_get_affinity_mask()
PATCH 1/1 metag/irq: Use access helper irq_data_get_affinity_mask()
From: Jiang Liu <[email protected]>
This is a preparatory patch for moving irq_data struct members.
Signed-off-by Jiang Liu <[email protected]>
Cc James Hogan <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
--- arch/metag/kernel/irq.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
arch/metag/kernel/irq.c +6 -4
@@ -270,23 +270,25 @@ void migrate_irqs(void)for_each_active_irq (i) {struct irq_data *data =irq_get_irq_data (i); +struct cpumask *mask;unsigned int newcpu;if (irqd_is_per_cpu (data))continue ; -if (!cpumask_test_cpu (cpu, data->affinity)) + mask =irq_data_get_affinity_mask (data); +if (!cpumask_test_cpu (cpu, mask))continue ; - newcpu =cpumask_any_and (data->affinity, cpu_online_mask); + newcpu =cpumask_any_and (mask, cpu_online_mask);if (newcpu >= nr_cpu_ids) {pr_info_ratelimited ("IRQ%u no longer affine to CPU%u\n" , i, cpu); -cpumask_setall (data->affinity); +cpumask_setall (mask); } -irq_set_affinity (i, data->affinity); +irq_set_affinity (i, mask); } }#endif /* CONFIG_HOTPLUG_CPU */
Hi,
Quoted 7 lines · Thomas Gleixner
From: Jiang Liu <[email protected]>
This is a preparatory patch for moving
irq_datastruct members.Signed-off-by Jiang Liu <[email protected]>Cc James Hogan <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>
Looks reasonable. Do you want this to go through metag tree?
If not,
Acked-by James Hogan <[email protected]>
Cheers
James
Quoted 40 lines
--- arch/metag/kernel/irq.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)Index:
tip/arch/metag/kernel/irq.c
===================================================================arch/metag/kernel/irq.c +6
-4@@ -270,23 +270,25 @@ void migrate_irqs(void)for_each_active_irq (i) {struct irq_data *data =irq_get_irq_data (i); +struct cpumask *mask;unsigned int newcpu;if (irqd_is_per_cpu (data))continue ; -if (!cpumask_test_cpu (cpu, data->affinity)) + mask =irq_data_get_affinity_mask (data); +if (!cpumask_test_cpu (cpu, mask))continue ; - newcpu =cpumask_any_and (data->affinity, cpu_online_mask); + newcpu =cpumask_any_and (mask, cpu_online_mask);if (newcpu >= nr_cpu_ids) {pr_info_ratelimited ("IRQ%u no longer affine to CPU%u\n" , i, cpu); -cpumask_setall (data->affinity); +cpumask_setall (mask); } -irq_set_affinity (i, data->affinity); +irq_set_affinity (i, mask); } }#endif /* CONFIG_HOTPLUG_CPU */
Quoted 10 lines · James Hogan
Quoted 7 lines · Thomas Gleixner
From: Jiang Liu <[email protected]>
This is a preparatory patch for moving
irq_datastruct members.Signed-off-by Jiang Liu <[email protected]>Cc James Hogan <[email protected]>Signed-off-by Thomas Gleixner <[email protected]>Looks reasonable. Do you want this to go through metag tree?
Yes please.