Skip to contentSkip to conversation

Add missing #iommu-cells on IOMMU nodes

PATCH New Suman Anna 2 participants 4 messages Jul 10, 2015 – Jul 14, 2015 Device tree bindings

lore
Share & tools
lore

Suman Anna

author
#0 lore raw

cover Add missing #iommu-cells on IOMMU nodes

Hi Tony,

This series adds the #iommu-cells property to the existing IOMMU nodes on OMAP4 & OMAP5. It was already fixed for OMAP3 in commit 2055088b5e17 ("ARM: dts: omap3: Add #iommu-cells to isp and iva iommu").

OMAP4 and OMAP5 do not yet have users for these IOMMUs (remoteproc nodes), so the warning as seen with the fix added for OMAP3 is not seen yet, but will as soon as a user is added.

Patches based on 4.2-rc1.

regards
Suman

Suman Anna (2):
ARM: dts: OMAP4: Add #iommu-cells property to IOMMUs
ARM: dts: OMAP5: Add #iommu-cells property to IOMMUs

 arch/arm/boot/dts/omap4.dtsi | 2 ++
 arch/arm/boot/dts/omap5.dtsi | 2 ++
 2 files changed, 4 insertions(+)
Signature · 1 line
2.4.4
author
#1 lore raw

PATCH 1/2 ARM: dts: OMAP4: Add #iommu-cells property to IOMMUs

Add missing #iommu-cells property to the DSP and IPU IOMMU nodes for OMAP4 platforms. This property is required as per the generic iommu binding.

---
 arch/arm/boot/dts/omap4.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/omap4.dtsi +2 -0
index f884d6adb71e..7d31c6ff246f 100644
@@ -551,6 +551,7 @@
 			reg = <0x4a066000 0x100>;
 			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
 			ti,hwmods = "mmu_dsp";
+			#iommu-cells = <0>;
 		};
 
 		mmu_ipu: mmu at 55082000 {
@@ -558,6 +559,7 @@
 			reg = <0x55082000 0x100>;
 			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
 			ti,hwmods = "mmu_ipu";
+			#iommu-cells = <0>;
 			ti,iommu-bus-err-back;
 		};
 
Signature · 1 line
2.4.4
author
#2 lore raw

PATCH 2/2 ARM: dts: OMAP5: Add #iommu-cells property to IOMMUs

In reply to Suman Anna

Add missing #iommu-cells property to the DSP and IPU IOMMU nodes for OMAP5 platforms. This property is required as per the generic iommu binding.

---
 arch/arm/boot/dts/omap5.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/omap5.dtsi +2 -0
index 7d24ae0306b5..c8fd648a7108 100644
@@ -612,6 +612,7 @@
 			reg = <0x4a066000 0x100>;
 			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
 			ti,hwmods = "mmu_dsp";
+			#iommu-cells = <0>;
 		};
 
 		mmu_ipu: mmu at 55082000 {
@@ -619,6 +620,7 @@
 			reg = <0x55082000 0x100>;
 			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
 			ti,hwmods = "mmu_ipu";
+			#iommu-cells = <0>;
 			ti,iommu-bus-err-back;
 		};
 
Signature · 1 line
2.4.4
#3 lore raw

cover Add missing #iommu-cells on IOMMU nodes

In reply to Suman Anna
Quoted 10 lines · Suman Anna

Hi Tony,

This series adds the #iommu-cells property to the existing IOMMU nodes on OMAP4 & OMAP5. It was already fixed for OMAP3 in commit 2055088b5e17 ("ARM: dts: omap3: Add #iommu-cells to isp and iva iommu").

OMAP4 and OMAP5 do not yet have users for these IOMMUs (remoteproc nodes), so the warning as seen with the fix added for OMAP3 is not seen yet, but will as soon as a user is added.

Applying both into omap-for-v4.2/fixes thanks.

Tony