drm/misc: Kconfig cleanup
cover drm/misc: Kconfig cleanup
The top level drm Kconfig is a bit messy at the moment. Most of the drm drivers have their own Kconfig files, but a few have their Kconfig files in the top level Kconfig option itself.
Create new Kconfig files for drivers that don't have one. This cleans up the Kconfig quite a bit
Archit Taneja (10):
drm/tdfx: clean up: create a separate Kconfig file drm/r128: clean up: create a separate Kconfig file drm/radeon: clean up: move config option to driver's own Kconfig file drm/amdgpu: clean up: move config option to driver's own Kconfig file drm/i810: clean up: create a separate Kconfig file drm/mga: clean up: create a separate Kconfig file
drm/sis: clean up: create a separate Kconfig file
drm/via: clean up: create a separate Kconfig file drm/savage: clean up: create a separate Kconfig file drm/misc: clean up: group device specific Kconfigs
drivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++ 10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/Kconfig
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH 1/10 drm/tdfx: clean up: create a separate Kconfig file
Remove the DRM_TDFX from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 7 +------ drivers/gpu/drm/tdfx/Kconfig | 6 ++++++ 2 files changed, 7 insertions(+), 6 deletions(-) create mode 100644 drivers/gpu/drm/tdfx/Kconfig
drivers/gpu/drm/Kconfig +1 -6
@@ -81,12 +81,7 @@ source "drivers/gpu/drm/i2c/Kconfig" source "drivers/gpu/drm/bridge/Kconfig" -config DRM_TDFX - tristate "3dfx Banshee/Voodoo3+" - depends on DRM && PCI - help - Choose this option if you have a 3dfx Banshee or Voodoo3 (or later), - graphics card. If M is selected, the module will be called tdfx. +source "drivers/gpu/drm/tdfx/Kconfig" config DRM_R128 tristate "ATI Rage 128"
drivers/gpu/drm/tdfx/Kconfig new file +6 -0
@@ -0,0 +1,6 @@ +config DRM_TDFX + tristate "3dfx Banshee/Voodoo3+" + depends on DRM && PCI + help + Choose this option if you have a 3dfx Banshee or Voodoo3 (or later), + graphics card. If M is selected, the module will be called tdfx.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH 2/10 drm/r128: clean up: create a separate Kconfig file
In reply to Archit TanejaRemove the DRM_R128 config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/r128/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/r128/Kconfig
drivers/gpu/drm/Kconfig +1 -8
@@ -83,14 +83,7 @@ source "drivers/gpu/drm/bridge/Kconfig" source "drivers/gpu/drm/tdfx/Kconfig" -config DRM_R128 - tristate "ATI Rage 128" - depends on DRM && PCI - select FW_LOADER - help - Choose this option if you have an ATI Rage 128 graphics card. If M - is selected, the module will be called r128. AGP support for - this card is strongly suggested (unless you have a PCI version). +source "drivers/gpu/drm/r128/Kconfig" config DRM_RADEON tristate "ATI Radeon"
drivers/gpu/drm/r128/Kconfig new file +8 -0
@@ -0,0 +1,8 @@ +config DRM_R128 + tristate "ATI Rage 128" + depends on DRM && PCI + select FW_LOADER + help + Choose this option if you have an ATI Rage 128 graphics card. If M + is selected, the module will be called r128. AGP support for + this card is strongly suggested (unless you have a PCI version).
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH 3/10 drm/radeon: clean up: move config option to driver's own Kconfig file
In reply to Archit TanejaRemove the DRM_RADEON config option from the top level drm Kconfig file and move it to the Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 21 --------------------- drivers/gpu/drm/radeon/Kconfig | 21 +++++++++++++++++++++ 2 files changed, 21 insertions(+), 21 deletions(-)
drivers/gpu/drm/Kconfig +0 -21
@@ -85,27 +85,6 @@ source "drivers/gpu/drm/tdfx/Kconfig" source "drivers/gpu/drm/r128/Kconfig" -config DRM_RADEON - tristate "ATI Radeon" - depends on DRM && PCI - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT - select FW_LOADER - select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select DRM_TTM - select POWER_SUPPLY - select HWMON - select BACKLIGHT_CLASS_DEVICE - select INTERVAL_TREE - help - Choose this option if you have an ATI Radeon graphics card. There - are both PCI and AGP versions. You don't need to choose this to - run the Radeon in plain VGA mode. - - If M is selected, the module will be called radeon. - source "drivers/gpu/drm/radeon/Kconfig" config DRM_AMDGPU
drivers/gpu/drm/radeon/Kconfig +21 -0
@@ -1,3 +1,24 @@ +config DRM_RADEON + tristate "ATI Radeon" + depends on DRM && PCI + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + select FW_LOADER + select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER + select DRM_TTM + select POWER_SUPPLY + select HWMON + select BACKLIGHT_CLASS_DEVICE + select INTERVAL_TREE + help + Choose this option if you have an ATI Radeon graphics card. There + are both PCI and AGP versions. You don't need to choose this to + run the Radeon in plain VGA mode. + + If M is selected, the module will be called radeon. + config DRM_RADEON_USERPTR bool "Always enable userptr support" depends on DRM_RADEON
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Re: [PATCH 03/10] drm/radeon: clean up: move config option to driver's own Kconfig file
On Mon, Jul 13, 2015 at 12:06:26PM +0530, Archit Taneja wrote:
[...]
Quoted 5 lines
drivers/gpu/drm/radeon/Kconfig +0
-0
drivers/gpu/drm/radeon/Kconfig line 10
Quoted 10 lines
drivers/gpu/drm/radeon/Kconfig +10
-0@@ -1,3 +1,24 @@ +config DRM_RADEON + tristate "ATI Radeon" + depends on DRM && PCI + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + select FW_LOADER + select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER + select DRM_TTM
There's a mix of tabs vs. spaces here, which you might want to clean up as part of this clean up series.
Thierry
PATCH 4/10 drm/amdgpu: clean up: move config option to driver's own Kconfig file
In reply to Archit TanejaRemove the DRM_AMDGPU config option from the top level drm Kconfig file and move to Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 19 ------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 19 deletions(-)
drivers/gpu/drm/Kconfig +0 -19
@@ -87,25 +87,6 @@ source "drivers/gpu/drm/r128/Kconfig" source "drivers/gpu/drm/radeon/Kconfig" -config DRM_AMDGPU - tristate "AMD GPU" - depends on DRM && PCI - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT - select FW_LOADER - select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select DRM_TTM - select POWER_SUPPLY - select HWMON - select BACKLIGHT_CLASS_DEVICE - select INTERVAL_TREE - help - Choose this option if you have a recent AMD Radeon graphics card. - - If M is selected, the module will be called amdgpu. - source "drivers/gpu/drm/amd/amdgpu/Kconfig" source "drivers/gpu/drm/nouveau/Kconfig"
drivers/gpu/drm/amd/amdgpu/Kconfig +19 -0
@@ -1,3 +1,22 @@ +config DRM_AMDGPU + tristate "AMD GPU" + depends on DRM && PCI + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + select FW_LOADER + select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER + select DRM_TTM + select POWER_SUPPLY + select HWMON + select BACKLIGHT_CLASS_DEVICE + select INTERVAL_TREE + help + Choose this option if you have a recent AMD Radeon graphics card. + + If M is selected, the module will be called amdgpu. + config DRM_AMDGPU_CIK bool "Enable amdgpu support for CIK parts" depends on DRM_AMDGPU
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 04/10] drm/amdgpu: clean up: move config option to driver's own Kconfig file
On Mon, Jul 13, 2015 at 12:06:27PM +0530, Archit Taneja wrote:
[...]
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +0
-0
drivers/gpu/drm/amd/amdgpu/Kconfig line 10
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/Kconfig +10
-0@@ -1,3 +1,22 @@ +config DRM_AMDGPU + tristate "AMD GPU" + depends on DRM && PCI + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + select FW_LOADER + select DRM_KMS_HELPER + select DRM_KMS_FB_HELPER + select DRM_TTM
Same here.
Thierry
PATCH 5/10 drm/i810: clean up: create a separate Kconfig file
In reply to Archit TanejaRemove the DRM_I810 config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/i810/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig
drivers/gpu/drm/Kconfig +1 -8
@@ -91,14 +91,7 @@ source "drivers/gpu/drm/amd/amdgpu/Kconfig" source "drivers/gpu/drm/nouveau/Kconfig" -config DRM_I810 - tristate "Intel I810" - # !PREEMPT because of missing ioctl locking - depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN) - help - Choose this option if you have an Intel I810 graphics card. If M is - selected, the module will be called i810. AGP support is required - for this driver to work. +source "drivers/gpu/drm/i810/Kconfig" source "drivers/gpu/drm/i915/Kconfig"
drivers/gpu/drm/i810/Kconfig new file +8 -0
@@ -0,0 +1,8 @@ +config DRM_I810 + tristate "Intel I810" + # !PREEMPT because of missing ioctl locking + depends on DRM && AGP && AGP_INTEL && (!PREEMPT || BROKEN) + help + Choose this option if you have an Intel I810 graphics card. If M is + selected, the module will be called i810. AGP support is required + for this driver to work.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH 6/10 drm/mga: clean up: create a separate Kconfig file
In reply to Archit TanejaRemove the DRM_MGA config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/mga/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/mga/Kconfig
drivers/gpu/drm/Kconfig +1 -8
@@ -95,14 +95,7 @@ source "drivers/gpu/drm/i810/Kconfig" source "drivers/gpu/drm/i915/Kconfig" -config DRM_MGA - tristate "Matrox g200/g400" - depends on DRM && PCI - select FW_LOADER - help - Choose this option if you have a Matrox G200, G400 or G450 graphics - card. If M is selected, the module will be called mga. AGP - support is required for this driver to work. +source "drivers/gpu/drm/mga/Kconfig" config DRM_SIS tristate "SiS video cards"
drivers/gpu/drm/mga/Kconfig new file +8 -0
@@ -0,0 +1,8 @@ +config DRM_MGA + tristate "Matrox g200/g400" + depends on DRM && PCI + select FW_LOADER + help + Choose this option if you have a Matrox G200, G400 or G450 graphics + card. If M is selected, the module will be called mga. AGP + support is required for this driver to work.
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH 7/10 drm/sis: clean up: create a separate Kconfig file
In reply to Archit TanejaRemove the DRM_SIS config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 9 +-------- drivers/gpu/drm/sis/Kconfig | 8 ++++++++ 2 files changed, 9 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/sis/Kconfig
drivers/gpu/drm/Kconfig +1 -8
@@ -97,14 +97,7 @@ source "drivers/gpu/drm/i915/Kconfig" source "drivers/gpu/drm/mga/Kconfig" -config DRM_SIS - tristate "SiS video cards" - depends on DRM && AGP - depends on FB_SIS || FB_SIS=n - help - Choose this option if you have a SiS 630 or compatible video - chipset. If M is selected the module will be called sis. AGP - support is required for this driver to work. +source "drivers/gpu/drm/sis/Kconfig" config DRM_VIA tristate "Via unichrome video cards"
drivers/gpu/drm/sis/Kconfig new file +8 -0
@@ -0,0 +1,8 @@ +config DRM_SIS + tristate "SiS video cards" + depends on DRM && AGP + depends on FB_SIS || FB_SIS=n + help + Choose this option if you have a SiS 630 or compatible video + chipset. If M is selected the module will be called sis. AGP + support is required for this driver to work.
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 8/10 drm/via: clean up: create a separate Kconfig file
In reply to Archit TanejaRemove the DRM_VIA config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 7 +------ drivers/gpu/drm/via/Kconfig | 6 ++++++ 2 files changed, 7 insertions(+), 6 deletions(-) create mode 100644 drivers/gpu/drm/via/Kconfig
drivers/gpu/drm/Kconfig +1 -6
@@ -99,12 +99,7 @@ source "drivers/gpu/drm/mga/Kconfig" source "drivers/gpu/drm/sis/Kconfig" -config DRM_VIA - tristate "Via unichrome video cards" - depends on DRM && PCI - help - Choose this option if you have a Via unichrome or compatible video - chipset. If M is selected the module will be called via. +source "drivers/gpu/drm/via/Kconfig" config DRM_SAVAGE tristate "Savage video cards"
drivers/gpu/drm/via/Kconfig new file +6 -0
@@ -0,0 +1,6 @@ +config DRM_VIA + tristate "Via unichrome video cards" + depends on DRM && PCI + help + Choose this option if you have a Via unichrome or compatible video + chipset. If M is selected the module will be called via.
Signature · 7 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 9/10 drm/savage: clean up: create a separate Kconfig file
In reply to Archit TanejaRemove the DRM_SAVAGE config option from the top level drm Kconfig file and create a new Kconfig file within the driver folder.
--- drivers/gpu/drm/Kconfig | 8 +------- drivers/gpu/drm/savage/Kconfig | 7 +++++++ 2 files changed, 8 insertions(+), 7 deletions(-) create mode 100644 drivers/gpu/drm/savage/Kconfig
drivers/gpu/drm/Kconfig +1 -7
@@ -101,13 +101,6 @@ source "drivers/gpu/drm/sis/Kconfig" source "drivers/gpu/drm/via/Kconfig" -config DRM_SAVAGE - tristate "Savage video cards" - depends on DRM && PCI - help - Choose this option if you have a Savage3D/4/SuperSavage/Pro/Twister - chipset. If M is selected the module will be called savage. - config DRM_VGEM tristate "Virtual GEM provider" depends on DRM
@@ -116,6 +109,7 @@ config DRM_VGEM as used by Mesa's software renderer for enhanced performance. If M is selected the module will be called vgem. +source "drivers/gpu/drm/savage/Kconfig" source "drivers/gpu/drm/exynos/Kconfig"
drivers/gpu/drm/savage/Kconfig new file +7 -0
@@ -0,0 +1,7 @@ +config DRM_SAVAGE + tristate "Savage video cards" + depends on DRM && PCI + help + Choose this option if you have a Savage3D/4/SuperSavage/Pro/Twister + chipset. If M is selected the module will be called savage. +
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH 10/10 drm/misc: clean up: group device specific Kconfigs
In reply to Archit TanejaMove the VGEM Kconfig option along with other DRM Kconfig options. Add a comment saying that the device specific Kconfig options start from here.
--- drivers/gpu/drm/Kconfig | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/gpu/drm/Kconfig +10 -8
@@ -77,6 +77,16 @@ config DRM_KMS_CMA_HELPER help Choose this if you need the KMS CMA helper functions +config DRM_VGEM + tristate "Virtual GEM provider" + depends on DRM + help + Choose this option to get a virtual graphics memory manager, + as used by Mesa's software renderer for enhanced performance. + If M is selected the module will be called vgem. + +#device specific Kconfigs + source "drivers/gpu/drm/i2c/Kconfig" source "drivers/gpu/drm/bridge/Kconfig"
@@ -101,14 +111,6 @@ source "drivers/gpu/drm/sis/Kconfig" source "drivers/gpu/drm/via/Kconfig" -config DRM_VGEM - tristate "Virtual GEM provider" - depends on DRM - help - Choose this option to get a virtual graphics memory manager, - as used by Mesa's software renderer for enhanced performance. - If M is selected the module will be called vgem. - source "drivers/gpu/drm/savage/Kconfig" source "drivers/gpu/drm/exynos/Kconfig"
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoted 6 lines · Archit Taneja
The top level drm
Kconfigis a bit messy at the moment. Most of the drm drivers have their ownKconfigfiles, but a few have theirKconfigfiles in the top levelKconfigoption itself.Create new
Kconfigfiles for drivers that don't have one. This cleans up theKconfigquite a bit
Series is :
Quoted 40 lines
Archit Taneja (10):
drm/tdfx: clean up: create a separateKconfigfile drm/r128: clean up: create a separateKconfigfile drm/radeon: clean up: move config option to driver's ownKconfigfile drm/amdgpu: clean up: move config option to driver's ownKconfigfile drm/i810: clean up: create a separateKconfigfile drm/mga: clean up: create a separateKconfigfile
drm/sis: clean up: create a separateKconfigfile
drm/via: clean up: create a separateKconfigfile drm/savage: clean up: create a separateKconfigfile drm/misc: clean up: group device specific Kconfigsdrivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++ 10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/Kconfig--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 29 lines · Archit Taneja
The top level drm
Kconfigis a bit messy at the moment. Most of the drm drivers have their ownKconfigfiles, but a few have theirKconfigfiles in the top levelKconfigoption itself.Create new
Kconfigfiles for drivers that don't have one. This cleans up theKconfigquite a bitArchit Taneja (10):
drm/tdfx: clean up: create a separateKconfigfile drm/r128: clean up: create a separateKconfigfile drm/radeon: clean up: move config option to driver's ownKconfigfile drm/amdgpu: clean up: move config option to driver's ownKconfigfile drm/i810: clean up: create a separateKconfigfile drm/mga: clean up: create a separateKconfigfile
drm/sis: clean up: create a separateKconfigfile
drm/via: clean up: create a separateKconfigfile drm/savage: clean up: create a separateKconfigfile drm/misc: clean up: group device specific Kconfigsdrivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++
Quoted 8 lines
10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/Kconfig
Looking at the current state of the top-level Kconfig file, I think it'd be a good idea to sort it in some way once this series has been merged. There are a bunch of options that are interleaved in completely non- intuitive ways.
I'm not sure what the best ordering would be, but I'd suggest to at least order them alphabetically. I think it'd also make sense to separate out panel and bridge drivers so that they are listed at the very bottom.
Perhaps also splitting legacy drivers and modesetting drivers might be useful, though perhaps a little discriminatory...
Thierry
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 44 lines · Thierry Reding
Quoted 29 lines · Archit Taneja
The top level drm
Kconfigis a bit messy at the moment. Most of the drm drivers have their ownKconfigfiles, but a few have theirKconfigfiles in the top levelKconfigoption itself.Create new
Kconfigfiles for drivers that don't have one. This cleans up theKconfigquite a bitArchit Taneja (10):
drm/tdfx: clean up: create a separateKconfigfile drm/r128: clean up: create a separateKconfigfile drm/radeon: clean up: move config option to driver's ownKconfigfile drm/amdgpu: clean up: move config option to driver's ownKconfigfile drm/i810: clean up: create a separateKconfigfile drm/mga: clean up: create a separateKconfigfile
drm/sis: clean up: create a separateKconfigfile
drm/via: clean up: create a separateKconfigfile drm/savage: clean up: create a separateKconfigfile drm/misc: clean up: group device specific Kconfigsdrivers/gpu/drm/Kconfig | 116 ++++++------------------------------- drivers/gpu/drm/amd/amdgpu/Kconfig | 19 ++++++ drivers/gpu/drm/i810/Kconfig | 8 +++ drivers/gpu/drm/mga/Kconfig | 8 +++ drivers/gpu/drm/r128/Kconfig | 8 +++ drivers/gpu/drm/radeon/Kconfig | 21 +++++++ drivers/gpu/drm/savage/Kconfig | 7 +++ drivers/gpu/drm/sis/Kconfig | 8 +++ drivers/gpu/drm/tdfx/Kconfig | 6 ++ drivers/gpu/drm/via/Kconfig | 6 ++Quoted 8 lines
10 files changed, 108 insertions(+), 99 deletions(-) create mode 100644 drivers/gpu/drm/i810/Kconfig create mode 100644 drivers/gpu/drm/mga/Kconfig create mode 100644 drivers/gpu/drm/r128/Kconfig create mode 100644 drivers/gpu/drm/savage/Kconfig create mode 100644 drivers/gpu/drm/sis/Kconfig create mode 100644 drivers/gpu/drm/tdfx/Kconfig create mode 100644 drivers/gpu/drm/via/KconfigLooking at the current state of the top-level
Kconfigfile, I think it'd be a good idea to sort it in some way once this series has been merged. There are a bunch of options that are interleaved in completely non- intuitive ways.
Quoted 7 lines
I'm not sure what the best ordering would be, but I'd suggest to at least order them alphabetically. I think it'd also make sense to separate out panel and bridge drivers so that they are listed at the very bottom.
Perhaps also splitting legacy drivers and modesetting drivers might be useful, though perhaps a little discriminatory...
I ended up patching things while writing this, so I'll just wait until these patches have landed, rebase on top of them and send out a proposal.
Thierry