Skip to contentSkip to conversation

checkpatch: Fixes: tag lines are allowed to be long

PATCH In review Dan Carpenter 2 participants 2 messages Jul 14, 2015 – Jul 15, 2015 Checkpatch

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 checkpatch: Fixes: tag lines are allowed to be long

A lot of the Fixes: tags go over the 75 character limit and that's ok.

Fixes 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns')
Signed-off-by Dan Carpenter <[email protected]>

---
The other common cause of false positives it Oops output but I don't have an idea how to filter for that.

scripts/checkpatch.pl +1 -1
index 90e1edc..537973b 100755
@@ -2310,7 +2310,7 @@ sub process {
 
 # Check for line lengths > 75 in commit log, warn once
 		if ($in_commit_log && !$commit_log_long_line &&
-		    length($line) > 75) {
+		    length($line) > 75 && !($line =~ /^Fixes:/)) {
 			WARN("COMMIT_LOG_LONG_LINE",
 			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
 			$commit_log_long_line = 1;
maintainer
#1 lore raw
Quoted 13 lines · Dan Carpenter

A lot of the Fixes: tags go over the 75 character limit and that's ok.

Fixes 2a076f40d8c9 ('checkpatch, SubmittingPatches: suggest line wrapping commit messages at 75 columns')
Signed-off-by Dan Carpenter <[email protected]>

---
The other common cause of false positives it Oops output but I don't have an idea how to filter for that.

scripts/checkpatch.pl +0 -0
index 90e1edc..537973b 100755[0-9a-f

scripts/checkpatch.pl sub process { · line 2316

Quoted 8 lines
scripts/checkpatch.pl +1 -1
@@ -2310,7 +2310,7 @@ sub process {
 
 # Check for line lengths > 75 in commit log, warn once
 		if ($in_commit_log && !$commit_log_long_line &&
-		    length($line) > 75) {
+		    length($line) > 75 && !($line =~ /^Fixes:/)) {
 			WARN("COMMIT_LOG_LONG_LINE",
 			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
 			$commit_log_long_line = 1;

Maybe some combination of:

^\s*>
^.*\[\s*timestamp\s*\]
^\s*\[\<0-9a-f\>\]
oops:

BUG: Unable to

Unable to

Followed by any blank line to reset