ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3

PATCH In review Magnus Damm 3 participants 6 messages Jul 13, 2015 – Jul 15, 2015

Subsystems (4)

Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture

lore

Share & tools

lore

Magnus Damm

author maintainer

2015-07-13 06:14 UTC #0 lore raw

v3 cover ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3

ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3

[PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file

This series is simply resending the remaining r8a7779 multiplatform cleanup patches. The code has not changed since V2:

[PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2

With these patches applied the r8a7779 SoC gets DT-only multiplatform support and old C board code for multiplatform gets removed.

The legacy r8a7779 Marzen code is not touched by this series, but with these patches applied basic r8a7779 multiplatform SoC support is done and only a few I/O devices are legacy-only.

Signed-off-by Magnus Damm <[email protected]>

---

Built on top of renesas-devel-20150706-v4.2-rc1
No special dependencies

 arch/arm/configs/shmobile_defconfig             |    1 
 arch/arm/mach-shmobile/Kconfig                  |    7 --
 arch/arm/mach-shmobile/Makefile                 |    4 -
 arch/arm/mach-shmobile/board-marzen-reference.c |   56 -----------------------
 arch/arm/mach-shmobile/clock-r8a7779.c          |    2 
 arch/arm/mach-shmobile/r8a7779.h                |    2 
 arch/arm/mach-shmobile/setup-r8a7779.c          |    3 -
 7 files changed, 4 insertions(+), 71 deletions(-)

Simon Horman

2015-07-15 00:25 UTC #1 lore raw

Hi Magnus,

Quoted 10 lines · Magnus Damm

ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
[PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
This series is simply resending the remaining r8a7779 multiplatform cleanup patches. The code has not changed since V2:

Quoted 8 lines

[PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
With these patches applied the r8a7779 SoC gets DT-only multiplatform support and old C board code for multiplatform gets removed.
The legacy r8a7779 Marzen code is not touched by this series, but with these patches applied basic r8a7779 multiplatform SoC support is done and only a few I/O devices are legacy-only.

Thanks, I have queued these up.

Please send a follow-up patch to address Geert's observation that CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.

Simon Horman

2015-07-15 01:16 UTC #2 lore raw

In reply to Magnus Damm

Hi Magnus,

Quoted 18 lines · Simon Horman

Hi Magnus,
Quoted 15 lines · Magnus Damm
ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
[PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
This series is simply resending the remaining r8a7779 multiplatform cleanup patches. The code has not changed since V2:
[PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
With these patches applied the r8a7779 SoC gets DT-only multiplatform support and old C board code for multiplatform gets removed.

Quoted 8 lines

Quoted 3 lines
The legacy r8a7779 Marzen code is not touched by this series, but with these patches applied basic r8a7779 multiplatform SoC support is done and only a few I/O devices are legacy-only.
Thanks, I have queued these up.
Please send a follow-up patch to address Geert's observation that CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.

Unfortunately I have noticed a problem with patch 02/04, and in particular the following portion of it:

arch/arm/mach-shmobile/Kconfig +0 -7

@@ -89,13 +89,6 @@ config ARCH_SH73A0
        select ARCH_RMOBILE
        select RENESAS_INTC_IRQPIN
 
-comment "Renesas ARM SoCs Board Type"
-
-config MACH_MARZEN
-       bool "MARZEN board"
-       depends on ARCH_R8A7779
-       select REGULATOR_FIXED_VOLTAGE if REGULATOR
-

It appears that with the above applied REGULATOR_FIXED_VOLTAGE is no longer set after make shmobile_defconfig which causes all sorts of trouble as the fixed regulator is used by many devices on many boards.

I wonder if the best way forwards would be to simply enable REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably multi_v7_defconfig too).

Magnus Damm

author maintainer

2015-07-15 05:56 UTC #3 lore raw

In reply to Magnus Damm

Hi Simon,

Quoted 47 lines · Simon Horman

Hi Magnus,
Quoted 18 lines · Simon Horman
Hi Magnus,
Quoted 15 lines · Magnus Damm
ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
[PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
This series is simply resending the remaining r8a7779 multiplatform cleanup patches. The code has not changed since V2:
[PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
With these patches applied the r8a7779 SoC gets DT-only multiplatform support and old C board code for multiplatform gets removed.
Quoted 8 lines
Quoted 3 lines
The legacy r8a7779 Marzen code is not touched by this series, but with these patches applied basic r8a7779 multiplatform SoC support is done and only a few I/O devices are legacy-only.
Thanks, I have queued these up.
Please send a follow-up patch to address Geert's observation that CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.
Unfortunately I have noticed a problem with patch 02/04, and in particular the following portion of it:
arch/arm/mach-shmobile/Kconfig +0 -7
@@ -89,13 +89,6 @@ config ARCH_SH73A0
        select ARCH_RMOBILE
        select RENESAS_INTC_IRQPIN
 
-comment "Renesas ARM SoCs Board Type"
-
-config MACH_MARZEN
-       bool "MARZEN board"
-       depends on ARCH_R8A7779
-       select REGULATOR_FIXED_VOLTAGE if REGULATOR
-
 

Quoted 3 lines

It appears that with the above applied REGULATOR_FIXED_VOLTAGE is no longer set after make shmobile_defconfig which causes all sorts of trouble as the fixed regulator is used by many devices on many boards.

Right, the regulator portion is indeed troublesome. And like you say, it is needed for many boards including Gen2.

Quoted 3 lines

I wonder if the best way forwards would be to simply enable REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably multi_v7_defconfig too).

Yeah, I think so.

Thanks,

/ magnus

Simon Horman

2015-07-15 06:43 UTC #4 lore raw

In reply to Magnus Damm

Quoted 57 lines · Magnus Damm

Hi Simon,
Quoted 47 lines · Simon Horman
Hi Magnus,
Quoted 18 lines · Simon Horman
Hi Magnus,
Quoted 15 lines · Magnus Damm
ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
[PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
This series is simply resending the remaining r8a7779 multiplatform cleanup patches. The code has not changed since V2:
[PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
With these patches applied the r8a7779 SoC gets DT-only multiplatform support and old C board code for multiplatform gets removed.
Quoted 8 lines
Quoted 3 lines
The legacy r8a7779 Marzen code is not touched by this series, but with these patches applied basic r8a7779 multiplatform SoC support is done and only a few I/O devices are legacy-only.
Thanks, I have queued these up.
Please send a follow-up patch to address Geert's observation that CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.
Unfortunately I have noticed a problem with patch 02/04, and in particular the following portion of it:
arch/arm/mach-shmobile/Kconfig +0 -7
@@ -89,13 +89,6 @@ config ARCH_SH73A0
        select ARCH_RMOBILE
        select RENESAS_INTC_IRQPIN
 
-comment "Renesas ARM SoCs Board Type"
-
-config MACH_MARZEN
-       bool "MARZEN board"
-       depends on ARCH_R8A7779
-       select REGULATOR_FIXED_VOLTAGE if REGULATOR
-
 
Quoted 3 lines
It appears that with the above applied REGULATOR_FIXED_VOLTAGE is no longer set after make shmobile_defconfig which causes all sorts of trouble as the fixed regulator is used by many devices on many boards.
Right, the regulator portion is indeed troublesome. And like you say, it is needed for many boards including Gen2.

Quoted 5 lines

Quoted 3 lines
I wonder if the best way forwards would be to simply enable REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably multi_v7_defconfig too).
Yeah, I think so.

Thanks, I have sent a patch.
Review would be much appreciated.

Geert Uytterhoeven

2015-07-15 07:41 UTC #5 lore raw

In reply to Magnus Damm

Hi Simon,

Quoted 43 lines · Simon Horman

Quoted 16 lines · Simon Horman
Quoted 15 lines · Magnus Damm
ARM: shmobile: r8a7779 Marzen multiplatform cleanup V3
[PATCH v3 01/04] ARM: shmobile: r8a7779: Generic SMP ops [PATCH v3 02/04] ARM: shmobile: marzen-reference: Remove C board code [PATCH v3 03/04] ARM: shmobile: Remove Marzen from shmobile_defconfig [PATCH v3 04/04] ARM: shmobile: r8a7779: Cleanup header file
This series is simply resending the remaining r8a7779 multiplatform cleanup patches. The code has not changed since V2:
[PATCH v2 00/06] ARM: shmobile: r8a7779 IRQ update and Marzen cleanup V2
With these patches applied the r8a7779 SoC gets DT-only multiplatform support and old C board code for multiplatform gets removed.
Quoted 8 lines
Quoted 3 lines
The legacy r8a7779 Marzen code is not touched by this series, but with these patches applied basic r8a7779 multiplatform SoC support is done and only a few I/O devices are legacy-only.
Thanks, I have queued these up.
Please send a follow-up patch to address Geert's observation that CONFIG_MACH_MARZEN should be removed from multi_v7_defconfig.
Unfortunately I have noticed a problem with patch 02/04, and in particular the following portion of it:
arch/arm/mach-shmobile/Kconfig +0 -7
@@ -89,13 +89,6 @@ config ARCH_SH73A0
        select ARCH_RMOBILE
        select RENESAS_INTC_IRQPIN
 
-comment "Renesas ARM SoCs Board Type"
-
-config MACH_MARZEN
-       bool "MARZEN board"
-       depends on ARCH_R8A7779
-       select REGULATOR_FIXED_VOLTAGE if REGULATOR
-
 

Quoted 3 lines

It appears that with the above applied REGULATOR_FIXED_VOLTAGE is no longer set after make shmobile_defconfig which causes all sorts of trouble as the fixed regulator is used by many devices on many boards.

Indeed,

"linux-config-from-dt arch/arm/boot/dts/r8a7779-marzen.dtb" says:

    ...
    regulator-fixed is provided by:
            drivers/regulator/fixed.c
                    needs CONFIG_REGULATOR_FIXED_VOLTAGE
    ...

Quoted 3 lines

I wonder if the best way forwards would be to simply enable REGULATOR_FIXED_VOLTAGE in shmobile_defconfig (and probably multi_v7_defconfig too).

Yes please.

Rule of thumb: check if the .configs generated from defconfigs have changed after dropping a select.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds