Skip to contentSkip to conversation

rts5208:Fix checkpatch warnings

PATCH RESEND In review Ravi Teja Darbha 2 participants 2 messages Jul 1, 2015 – Jul 15, 2015 Staging

lore
Share & tools
lore

Ravi Teja Darbha

author
#0 lore raw

PATCH RESEND 1/1 rts5208:Fix checkpatch warnings

else is not generally useful after a break or return, hence removed.

Signed-off-by Ravi Teja Darbha <[email protected]>
---
 drivers/staging/rts5208/xd.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/staging/rts5208/xd.c +4 -6
index 10fea7b..42d8d82 100644
@@ -1689,10 +1689,9 @@ static int xd_read_multiple_pages(struct rtsx_chip *chip, u32 phy_blk,
 			xd_set_err_code(chip, XD_TO_ERROR);
 			rtsx_trace(chip);
 			return STATUS_FAIL;
-		} else {
-			rtsx_trace(chip);
-			goto Fail;
 		}
+		rtsx_trace(chip);
+		goto Fail;
 	}
 
 	return STATUS_SUCCESS;

@@ -1905,10 +1904,9 @@ static int xd_write_multiple_pages(struct rtsx_chip *chip, u32 old_blk,
 			xd_set_err_code(chip, XD_TO_ERROR);
 			rtsx_trace(chip);
 			return STATUS_FAIL;
-		} else {
-			rtsx_trace(chip);
-			goto Fail;
 		}
+		rtsx_trace(chip);
+		goto Fail;
 	}
 
 	if (end_page == (xd_card->page_off + 1)) {
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 6 lines · Ravi Teja Darbha

else is not generally useful after a break or return, hence removed.

Signed-off-by Ravi Teja Darbha <[email protected]>
---
 drivers/staging/rts5208/xd.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Why resend? What is different from the previous version? What was wrong with it?

Please be specific when sending patches.

thanks,

greg k-h