Skip to contentSkip to conversation

Add xxhash package

PATCH New Ed Swierk 3 participants 3 messages Jul 16, 2015 – Sep 19, 2015

lore
Share & tools
lore

Ed Swierk

author
#0 lore raw

PATCH 1/1 Add xxhash package

"xxHash is an extremely fast hash algorithm, running at RAM speed limits."

---
 package/Config.in        |  1 +
 package/xxhash/Config.in |  7 +++++++
 package/xxhash/xxhash.mk | 19 +++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/xxhash/Config.in
 create mode 100644 package/xxhash/xxhash.mk
package/Config.in +1 -0
index 86a53c8..916ff47 100644
@@ -1395,6 +1395,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/which/Config.in"
 endif
 	source "package/xmlstarlet/Config.in"
+	source "package/xxhash/Config.in"
 endmenu
 
 menu "System tools"
package/xxhash/Config.in new file +7 -0
new file mode 100644
index 0000000..6720225
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_XXHASH
+	bool "xxhash"
+	help
+	  xxHash is an extremely fast hash algorithm, running at RAM
+	  speed limits.
+	  
+	  https://github.com/Cyan4973/xxHash
package/xxhash/xxhash.mk new file +19 -0
new file mode 100644
index 0000000..ba680ba
@@ -0,0 +1,19 @@
+################################################################################
+#
+# xxhash
+#
+################################################################################
+
+XXHASH_VERSION = r40
+XXHASH_SITE = $(call github,Cyan4973,xxHash,$(XXHASH_VERSION))
+XXHASH_LICENSE = Free
+
+define XXHASH_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) xxhsum
+endef
+
+define XXHASH_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/xxhsum $(TARGET_DIR)/usr/bin/xxhsum
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 Add xxhash package

Ed, All,

On 2015-07-16 13:59 -0700, Ed Swierk spake thusly:

Quoted 4 lines

"xxHash is an extremely fast hash algorithm, running at RAM speed limits."

[--SNIP--]

Quoted 5 lines

new file mode 100644
index 0000000..ba680ba

package/xxhash/xxhash.mk line 9

Quoted 9 lines
package/xxhash/xxhash.mk new file +9 -0
@@ -0,0 +1,19 @@
+################################################################################
+#
+# xxhash
+#
+################################################################################
+
+XXHASH_VERSION = r40
+XXHASH_SITE = $(call github,Cyan4973,xxHash,$(XXHASH_VERSION))
+XXHASH_LICENSE = Free

'Free' is not a license name (t least not a common one). We have a list of commonly used licenses in the manual:
http://buildroot.net/downloads/manual/manual.html#legal-info-list-licenses

However, the licensing terms of that package are in fact a bit weird. In fact, the LICENSE file is the text of the BSD-2c. But when one looks at the source files, one (xxhash.c) is BSD-2c, while the other (xxhsum.c) is clearly GPLv2+.

So you would write:

XXHASH_LICENSE = BSD-2c, GPLv2+
XXHASH_LICENSE_FILES = LICENSE xxhsum.c

(yes, we put the source file in there because the GPLv2+ license is only visible in that file).

Regards,
Yann E. MORIN.

Quoted 16 lines
package/xxhash/xxhash.mk new file +9 -0
+define XXHASH_BUILD_CMDS
+	$(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) xxhsum
+endef
+
+define XXHASH_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/xxhsum $(TARGET_DIR)/usr/bin/xxhsum
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 Add xxhash package

In reply to Ed Swierk

Dear Ed Swierk,

Quoted 11 lines · Ed Swierk

"xxHash is an extremely fast hash algorithm, running at RAM speed limits."

---
 package/Config.in        |  1 +
 package/xxhash/Config.in |  7 +++++++
 package/xxhash/xxhash.mk | 19 +++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/xxhash/Config.in
 create mode 100644 package/xxhash/xxhash.mk

Applied, after doing the following changes:

[Thomas:
- tweak commit log title
- add correct license and license files information, using the suggestion from Yann E. Morin
- add $(TARGET_MAKE_ENV) in the environment in the build step.]

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com