Staging: rtl8192u: pointer math bug in ieee80211_rx_DELBA()

PATCH Superseded Dan Carpenter 1 participant 1 message Jul 17, 2015

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2015-07-17 09:24 UTC #0 lore raw

PATCH 1/2 Staging: rtl8192u: pointer math bug in ieee80211_rx_DELBA()

The "delba" variable is a pointer to struct rtl_80211_hdr_3addr so this addition here means we read nonsense data from beyond the end of the buffer. It could result in an oops if the memory is not mapped.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c +1 -1

index 9ff8e05..c1c1a1e 100644
@@ -592,7 +592,7 @@ int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb)
 	IEEE80211_DEBUG_DATA(IEEE80211_DL_DATA|IEEE80211_DL_BA, skb->data, skb->len);
 	delba = (struct rtl_80211_hdr_3addr *)skb->data;
 	dst = (u8 *)(&delba->addr2[0]);
-	delba += sizeof(struct rtl_80211_hdr_3addr);
+	delba++;
 	pDelBaParamSet = (PDELBA_PARAM_SET)(delba+2);
 	pReasonCode = (u16 *)(delba+4);