commands: Add dhrystone
RFC 1/1 commands: Add dhrystone
This tool will help to measure the system performance.
Signed-off-by Daniel Schultz <[email protected]>
--- commands/Kconfig | 7 + commands/Makefile | 1 + commands/dhrystone.c | 404 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 412 insertions(+) create mode 100644 commands/dhrystone.c
commands/Kconfig +7 -0
@@ -2102,6 +2102,13 @@ config CMD_STATE depends on STATE prompt "state" +config CMD_DHRYSTONE + bool + default n + prompt "dhrystone" + help + CPU benchmark tool + # end Miscellaneous commands endmenu
commands/Makefile +1 -0
@@ -112,3 +112,4 @@ obj-$(CONFIG_CMD_NV) += nv.o obj-$(CONFIG_CMD_DEFAULTENV) += defaultenv.o obj-$(CONFIG_CMD_STATE) += state.o obj-$(CONFIG_CMD_DHCP) += dhcp.o +obj-$(CONFIG_CMD_DHRYSTONE) += dhrystone.o
commands/dhrystone.c new file +404 -0
404 lines not on this page · raw message
Signature · 7 lines
1.9.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 3 lines · On Thu, 16 Jul 2015 15:50:33 +0200 Daniel Schultz <[email protected]> wrote:
This tool will help to measure the system performance.
Signed-off-by Daniel Schultz <[email protected]>
...
commands/dhrystone.c line 395
Quoted 4 lines
commands/dhrystone.c new file +4
-0+ +BAREBOX_CMD_HELP_START(dhrystone) +BAREBOX_CMD_HELP_TEXT( +"this command runs a dhrystone benchmark to get an astimation of the CPU freq")
^^ ^^^^^^^^^^ estimation?
do you mean that there are __several__ __different__ dhrystone benchmarks?
Quoted 17 lines
commands/dhrystone.c new file +9
-0+BAREBOX_CMD_HELP_END + +BAREBOX_CMD_START(dhrystone) + .cmd = do_dhrystone, + BAREBOX_CMD_DESC("run dhrystone test, specify number of runs") + BAREBOX_CMD_OPTS("number_of_runs") + BAREBOX_CMD_GROUP(CMD_GRP_INFO) + BAREBOX_CMD_HELP(cmd_dhrystone_help) +BAREBOX_CMD_ENDSignature · 7 lines
1.9.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Signature · 8 lines
-- Best regards, Antony Pavlov _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Hi Daniel,
Quoted 15 lines · Daniel Schultz
This tool will help to measure the system performance.
Signed-off-by Daniel Schultz <[email protected]>--- commands/Kconfig | 7 + commands/Makefile | 1 + commands/dhrystone.c | 404 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 412 insertions(+) create mode 100644 commands/dhrystone.ccommands/Kconfig +0
-0
commands/Kconfig config CMD_STATE · line 2107
Quoted 6 lines
commands/Kconfig +3
-0@@ -2102,6 +2102,13 @@ config CMD_STATE depends on STATE prompt "state" +config CMD_DHRYSTONE + bool + default n
'n' already is the default. Please drop this line.
Quoted 81 lines
commands/Kconfig +4
-0+ prompt "dhrystone" + help + CPU benchmark tool + # end Miscellaneous commands endmenucommands/Makefile +1
-0@@ -112,3 +112,4 @@ obj-$(CONFIG_CMD_NV) += nv.o obj-$(CONFIG_CMD_DEFAULTENV) += defaultenv.o obj-$(CONFIG_CMD_STATE) += state.o obj-$(CONFIG_CMD_DHCP) += dhcp.o +obj-$(CONFIG_CMD_DHRYSTONE) += dhrystone.ocommands/dhrystone.c new file +59
-0@@ -0,0 +1,404 @@ +/* +* (C) Copyright 2014 Phytec Messtechnik GmbH +* Author: Stefan Müller-Klieser <[email protected]> +* (C) Copyright (C) 2015 Phytec Messtechnik GmbH +* Author: Daniel Schultz <[email protected]> +* +* based on "DHRYSTONE" Benchmark Program +* Version: C, Version 2.1 +* Date: May 25, 1988 +* Author: Reinhold P. Weicker +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 +* as published by the Free Software Foundation. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +*/ + +#include <common.h> +#include <command.h> +#include <errno.h> +#include <clock.h> +#include <asm-generic/div64.h> +#include <malloc.h> +#include <stdbool.h> +#include <stdio.h> /* for strcpy, strcmp */ + +enum idents {ident_1, ident_2, ident_3, ident_4, ident_5}; + +/* General definitions: */ + +struct record { +struct record *ptr_comp; +enum idents discr; +union { +struct { +enum idents enum_comp; +int int_comp; +char str_comp[31 ]; + } var_1; +struct { +enum idents enum_comp_2; +char str_2_comp[31 ]; + } var_2; +struct { +char char_1_Comp; +char char_2_Comp; + } var_3; + } variant; +}; + +/* Global Variables: */ + +struct record *record_glob; +struct record *next_record_glob;
commands/dhrystone.c line 69
Quoted 10 lines
commands/dhrystone.c new file +10
-0+int int_glob; +bool bool_glob; +char char_1_glob; +char char_2_glob; +int arr_1_glob[50 ]; +int arr_2_glob[50 ][50 ]; + +/* variables for time measurement: */ + +#define TOO_SMALL_TIME 50000000
50 * MSECOND
commands/dhrystone.c line 71
Quoted 2 lines
commands/dhrystone.c new file +2
-0+/* Measurements should last at least 50mseconds */ +#define TOO_LARGE_TIME 2000000000
2 * SECOND
Makes this better readable.
Quoted 276 lines
commands/dhrystone.c new file +276
-0+ +u64 begin_time; +u64 end_time; +u64 user_time; +u64 microseconds; +u64 dhrystones_per_second; +/* end of variables for time measurement */ + +enum idents compare_chars (char char_1,char char_2) +{ +if (char_1 != char_2) { +return ident_1; + }else {/* should not executed */ + char_1_glob = char_1; +return ident_2; + } +} + +bool compare_strs (char str_1[31 ],char str_2[31 ]) +{ +int offset; + + offset =2 ; +while (offset <=2 ) +if (compare_chars (str_1[offset], str_2[offset+1 ]) == ident_1) + ++offset; +if (strcmp (str_1, str_2) >0 ) { + int_glob = offset +7 ; +return true; + }else { +return false; + } + +} + +bool check_ident (enum idents ident) +{ +if (ident == ident_3) +return true; +else +return false; +} + +void proc_7 (int input_1,int input_2,int *out) +{ + *out = input_2 + input_1 +2 ; +} + +void proc_6 (enum idents ident,enum idents *ident_out) +{ + *ident_out = ident; +if (!check_ident (ident)) + *ident_out = ident_4; +switch (ident) { +case ident_1: + *ident_out = ident_1; +break ; +case ident_2: +if (int_glob >100 ) + *ident_out = ident_1; +else + *ident_out = ident_4; +break ; +case ident_3: + *ident_out = ident_2; +break ; +case ident_4: +break ; +case ident_5: + *ident_out = ident_3; +break ; + } +} + +void fill_record (struct record *record) +{ +struct record *next_record = record->ptr_comp; + + *record->ptr_comp = *record_glob; + record->variant.var_1.int_comp =5 ; + next_record->variant.var_1.int_comp = record->variant.var_1.int_comp; + next_record->ptr_comp = record->ptr_comp; +proc_7 (10 , int_glob, &record_glob->variant.var_1.int_comp); +/* Ptr_Val_Par->ptr_comp->ptr_comp == record_glob->ptr_comp */ +if (next_record->discr == ident_1) {/* then, executed */ + next_record->variant.var_1.int_comp =6 ; +proc_6 (record->variant.var_1.enum_comp, + &next_record->variant.var_1.enum_comp); + next_record->ptr_comp = record_glob->ptr_comp; +proc_7 (next_record->variant.var_1.int_comp,10 , + &next_record->variant.var_1.int_comp); + }else {/* not executed */ + *record = *record->ptr_comp; + } +} + +void proc_2 (int *out) +{ +if (char_1_glob =='A' ) + *out = *out +9 - int_glob; +} + +void proc_4 (void ) +{ + bool_glob = (char_1_glob =='A' ) | bool_glob; + char_2_glob ='B' ; +} + +void proc_5 (void ) +{ + char_1_glob ='A' ; + bool_glob = false; +} + +/* dhry_2.c */ + +void fill_array (int arr_1[50 ],int arr_2[50 ][50 ],int val_1,int val_2) +{ +int i; +int offset; + + offset = val_1 +5 ; + arr_1[offset] = val_2; + arr_1[offset+1 ] = arr_1[offset]; + arr_1[offset+30 ] = offset; +for (i = offset; i <= offset+1 ; ++i) + arr_2[offset][i] = offset; + arr_2[offset][offset-1 ] +=1 ; + arr_2[offset+20 ][offset] = arr_1[offset]; + int_glob =5 ; +} + +static int do_dhrystone (int argc,char *argv[]) +{ +/* main program, corresponds to procedures */ +/* Main and Proc_0 in the Ada version */ +int int_1; +int int_2; +int int_3; +char char_i; +enum idents ident; +char str_1[31 ]; +char str_2[31 ]; +int i; +int number_of_runs; + +/* barebox cmd */ +if (argc <2 ) +return COMMAND_ERROR_USAGE ; + number_of_runs =simple_strtoul (argv[1 ],NULL ,10 ); + +/* Initializations */ + ident = ident_2;/* prevent compiler warning */ + int_2 =0 ;/* prevent compiler warning */ + int_3 =0 ;/* prevent compiler warning */ + + next_record_glob =malloc (sizeof (struct record )); + record_glob =malloc (sizeof (struct record )); + + record_glob->ptr_comp = next_record_glob; + record_glob->discr = ident_1; + record_glob->variant.var_1.enum_comp = ident_3; + record_glob->variant.var_1.int_comp =40 ; +strcpy (record_glob->variant.var_1.str_comp, +"DHRYSTONE PROGRAM, SOME STRING" ); +strcpy (str_1,"DHRYSTONE PROGRAM, 1'ST STRING" ); + + arr_2_glob[8 ][7 ] =10 ; +/* Was missing in published program. Without this statement, */ +/* arr_2_glob [8][7] would have an undefined value. */ +/* Warning: With 16-Bit processors and number_of_runs > 32000, */ +/* overflow may occur for this array element. */ + +printf ("\n" ); +printf ("Dhrystone Benchmark, Version 2.1 (Language: C)\n" ); +printf ("\n" ); +printf ("Program compiled without 'register' attribute\n" ); +printf ("\n" ); +printf ("Execution starts, %d runs through Dhrystone\n" , number_of_runs); + +/***************/ +/* Start timer */ +/***************/ + begin_time =get_time_ns (); + +for (i =1 ; i <= number_of_runs; ++i) { +proc_5 (); +proc_4 (); +/* char_1_glob == 'A', char_2_glob == 'B', bool_glob == true */ + int_1 =2 ; + int_2 =3 ; +strcpy (str_2,"DHRYSTONE PROGRAM, 2'ND STRING" ); + ident = ident_2; + bool_glob = !compare_strs (str_1, str_2); +/* bool_glob == 1 */ +while (int_1 < int_2) { + int_3 =5 * int_1 - int_2; +/* int_3 == 7 */ +proc_7 (int_1, int_2, &int_3); +/* int_3 == 7 */ + int_1 +=1 ; + } +/* int_1 == 3, int_2 == 3, int_3 == 7 */ +fill_array (arr_1_glob, arr_2_glob, int_1, int_3); +/* int_glob == 5 */ +fill_record (record_glob); +for (char_i ='A' ; char_i <= char_2_glob; ++char_i) { +if (ident ==compare_chars (char_i,'C' )) { +proc_6 (ident_1, &ident); +strcpy (str_2, +"DHRYSTONE PROGRAM, 3'RD STRING" ); + int_2 = i; + int_glob = i; + } + } +/* int_1 == 3, int_2 == 3, int_3 == 7 */ + int_2 = int_2 * int_1; + int_1 = int_2 / int_3; + int_2 =7 * (int_2 - int_3) - int_1; +/* int_1 == 1, int_2 == 13, int_3 == 7 */ +proc_2 (&int_1); +/* int_1 == 5 */ + } + +/**************/ +/* Stop timer */ +/**************/ + end_time =get_time_ns (); + +printf ("Execution ends\n" ); +printf ("\n" ); +printf ("Final values of the variables used in the benchmark:\n" ); +printf ("\n" ); +printf ("int_glob: %d\n" , int_glob); +printf (" should be: %d\n" ,5 ); +printf ("bool_glob: %d\n" , bool_glob); +printf (" should be: %d\n" ,1 ); +printf ("char_1_glob: %c\n" , char_1_glob); +printf (" should be: %c\n" ,'A' ); +printf ("char_2_glob: %c\n" , char_2_glob); +printf (" should be: %c\n" ,'B' ); +printf ("arr_1_glob[8]: %d\n" , arr_1_glob[8 ]); +printf (" should be: %d\n" ,7 ); +printf ("arr_2_glob[8][7]: %d\n" , arr_2_glob[8 ][7 ]); +printf (" should be: number_of_runs + 10\n" ); +printf ("record_glob->\n" ); +printf (" ptr_comp: %d\n" , (int ) record_glob->ptr_comp); +printf (" should be: (implementation-dependent)\n" ); +printf (" discr: %d\n" , record_glob->discr); +printf (" should be: %d\n" ,0 ); +printf (" enum_comp: %d\n" , + record_glob->variant.var_1.enum_comp); +printf (" should be: %d\n" ,2 ); +printf (" int_comp: %d\n" , + record_glob->variant.var_1.int_comp); +printf (" should be: %d\n" ,17 ); +printf (" str_comp: %s\n" , + record_glob->variant.var_1.str_comp); +printf (" should be: DHRYSTONE PROGRAM, SOME STRING\n" ); +printf ("next_record_glob->\n" ); +printf (" ptr_comp: %d\n" , (int ) next_record_glob->ptr_comp); +printf (" should be: (implementation-dependent), same as above\n" ); +printf (" discr: %d\n" , next_record_glob->discr); +printf (" should be: %d\n" ,0 ); +printf (" enum_comp: %d\n" , + next_record_glob->variant.var_1.enum_comp); +printf (" should be: %d\n" ,1 ); +printf (" int_comp: %d\n" , + next_record_glob->variant.var_1.int_comp); +printf (" should be: %d\n" ,18 ); +printf (" str_comp: %s\n" , + next_record_glob->variant.var_1.str_comp); +printf (" should be: DHRYSTONE PROGRAM, SOME STRING\n" ); +printf ("int_1: %d\n" , int_1); +printf (" should be: %d\n" ,5 ); +printf ("int_2: %d\n" , int_2);
commands/dhrystone.c line 357
Quoted 10 lines
commands/dhrystone.c new file +10
-0+printf (" should be: %d\n" ,13 ); +printf ("int_3: %d\n" , int_3); +printf (" should be: %d\n" ,7 ); +printf ("ident: %d\n" , ident); +printf (" should be: %d\n" ,1 ); +printf ("str_1: %s\n" , str_1); +printf (" should be: DHRYSTONE PROGRAM, 1'ST STRING\n" ); +printf ("str_2: %s\n" , str_2); +printf (" should be: DHRYSTONE PROGRAM, 2'ND STRING\n" ); +printf ("\n" );
When the values above match the expected values they seem mostly uninteresting. You should only print them when they actually don't match the expected values.
commands/dhrystone.c line 365
Quoted 8 lines
commands/dhrystone.c new file +8
-0+ + user_time = end_time - begin_time; + +if (user_time <TOO_SMALL_TIME ) { +printf ("Measured time too small to obtain meaningful results\n" ); +printf ("or a timer wrap happend. Please increase number of runs\n" ); +printf ("starting from 10 in *10 increments\n" ); +printf ("user_time: %llu\n" , user_time);
Add unit to printf (ns)?
commands/dhrystone.c line 370
Quoted 5 lines
commands/dhrystone.c new file +5
-0+ }else if (user_time >TOO_LARGE_TIME ) { +printf ("Measured time too large to obtain meaningful results.\n" ); +printf ("Please decrease number of runs by *10\n" ); +printf ("Timer overflow could occured.\n" ); +printf ("user_time: %llu\n" , user_time);
ditto.
The above loks very 80ies style. How about making the number of iterations optional on the command line and just run the benchmark until enough time is over? You may test for the time only every 10000 iterations or so to keep the overhead of measuring the time small.
commands/dhrystone.c line 381
Quoted 11 lines
commands/dhrystone.c new file +11
-0+ }else if (end_time < begin_time) { +printf ("Timer overflow occured.\n" ); +printf ("Please restart the programm.\n" ); + }else { +printf ("user_time: %llu ns\n" , user_time); + + microseconds = user_time; +do_div (microseconds, number_of_runs); + +printf ("Nanoseconds for one run through Dhrystone: " ); +printf ("%llu\n" , microseconds);
Should the variable name be nanoseconds?
Should be a single printf.
Quoted 4 lines
commands/dhrystone.c new file +4
-0+printf ("Dhrystones per Second:\n " ); +printf ("(%d / %llu) * 10^9\n" , number_of_runs, user_time); +printf ("DMIPS:\n " ); + printf("((%d / %llu) * 10^9) / 1757\n", number_of_runs,
commands/dhrystone.c line 395
Quoted 10 lines
commands/dhrystone.c new file +10
-0+ user_time); +printf ("\n" ); + } + +return 0 ; +} + +BAREBOX_CMD_HELP_START(dhrystone) +BAREBOX_CMD_HELP_TEXT( +"this command runs a dhrystone benchmark to get an astimation of the CPU freq")
s/astimation/estimation/
Sascha
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox