net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

PATCH Applied Sowmini Varadhan 4 participants 4 messages Jul 20, 2015 – Jul 21, 2015

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Sowmini Varadhan

author

2015-07-20 07:55 UTC #0 lore raw

PATCH v2 1/1 net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

__vxlan_find_mac invokes ether_addr_equal on the eth_addr field, which triggers unaligned access messages, so rearrange vxlan_fdb to avoid this in the most non-intrusive way.

Signed-off-by Sowmini Varadhan <[email protected]>

---
v2: Alexander Duyck comments: place eth_addr[] to be 64b aligned

 drivers/net/vxlan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/vxlan.c +1 -1

index 34c519e..ec86a11 100644
@@ -106,9 +106,9 @@ struct vxlan_fdb {
 	unsigned long	  updated;	/* jiffies */
 	unsigned long	  used;
 	struct list_head  remotes;
+	u8		  eth_addr[ETH_ALEN];
 	u16		  state;	/* see ndm_state */
 	u8		  flags;	/* see ndm_flags */
-	u8		  eth_addr[ETH_ALEN];
 };
 
 /* Pseudo network device */

Signature · 1 line

1.7.1

Jiri Pirko

Reviewed-by on v2 1/1

2015-07-20 08:04 UTC #1 lore raw

Quoted 6 lines · Mon, Jul 20, 2015 at 09:54:50AM CEST, [email protected] wrote:

__vxlan_find_mac invokes ether_addr_equal on the eth_addr field, which triggers unaligned access messages, so rearrange vxlan_fdb to avoid this in the most non-intrusive way.
Signed-off-by Sowmini Varadhan <[email protected]>

Reviewed-by Jiri Pirko <[email protected]>

Marcelo Ricardo Leitner

Reviewed-by on v2 1/1

2015-07-20 14:07 UTC #2 lore raw

In reply to Sowmini Varadhan

Quoted 6 lines · Sowmini Varadhan

__vxlan_find_mac invokes ether_addr_equal on the eth_addr field, which triggers unaligned access messages, so rearrange vxlan_fdb to avoid this in the most non-intrusive way.
Signed-off-by Sowmini Varadhan <[email protected]>

Reviewed-by Marcelo Ricardo Leitner <[email protected]>

David Miller

maintainer Applied

2015-07-21 07:12 UTC #3 lore raw

In reply to Sowmini Varadhan

From: Sowmini Varadhan <[email protected]>
Date: Mon, 20 Jul 2015 09:54:50 +0200

Quoted 8 lines

__vxlan_find_mac invokes ether_addr_equal on the eth_addr field, which triggers unaligned access messages, so rearrange vxlan_fdb to avoid this in the most non-intrusive way.
Signed-off-by Sowmini Varadhan <[email protected]>
---
v2: Alexander Duyck comments: place eth_addr[] to be 64b aligned

Applied, thanks.