Skip to contentSkip to conversation

ARM: tegra: Add Tegra20 SPI device nodes

PATCH Superseded Mirza Krak 3 participants 4 messages Jul 20, 2015 – Jul 21, 2015

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Mirza Krak

author
#0 lore raw

PATCH 1/1 ARM: tegra: Add Tegra20 SPI device nodes

From: Mirza Krak <[email protected]>

Add the device tree node for the SPI controllers found on Tegra20 SOCs.

---
 arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm/dts/tegra20.dtsi +44 -0
index b8c8a923017e..82168c9012e3 100644
@@ -268,6 +268,50 @@
 		#pwm-cells = <2>;
 	};
 
+	spi at 7000d400 {
+		compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+		reg = <0x7000d400 0x200>;
+		interrupts = <0 59 0x04>;
+		nvidia,dma-request-selector = <&apbdma 15>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&tegra_car 41>;
+		status = "disabled";
+	};
+
+	spi at 7000d600 {
+		compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+		reg = <0x7000d600 0x200>;
+		interrupts = <0 82 0x04>;
+		nvidia,dma-request-selector = <&apbdma 16>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&tegra_car 44>;
+		status = "disabled";
+	};
+
+	spi at 7000d800 {
+		compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+		reg = <0x7000d480 0x200>;
+		interrupts = <0 83 0x04>;
+		nvidia,dma-request-selector = <&apbdma 17>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&tegra_car 46>;
+		status = "disabled";
+	};
+
+	spi at 7000da00 {
+		compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";
+		reg = <0x7000da00 0x200>;
+		interrupts = <0 93 0x04>;
+		nvidia,dma-request-selector = <&apbdma 18>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+		clocks = <&tegra_car 68>;
+		status = "disabled";
+	};
+
 	i2c at 7000c000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
Signature · 1 line
2.1.0
#2 lore raw

PATCH 1/1 ARM: tegra: Add Tegra20 SPI device nodes

In reply to Mirza Krak
Quoted 15 lines · Mirza Krak

From: Mirza Krak <[email protected]>

Add the device tree node for the SPI controllers found on Tegra20 SOCs.

---
 arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm/dts/tegra20.dtsi +0 -0
index b8c8a923017e..82168c9012e3 100644

arch/arm/dts/tegra20.dtsi line 272

Quoted 5 lines
arch/arm/dts/tegra20.dtsi +2 -0
@@ -268,6 +268,50 @@
 		#pwm-cells = <2>;
 	};
 
+	spi at 7000d400 {
+		compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";

This can't be correct on Tegra20 since Tegra30 didn't exist at the time. You'll need to drop the first string in the list for this to be correct.

Also, might be worth copying these from the Linux kernel's copy of the device tree files, since they are slightly different. That might involve pulling in a couple of headers too, though, so might not be worth it.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150721/738ef42c/attachment.sig>

author
#3 lore raw

PATCH 1/1 ARM: tegra: Add Tegra20 SPI device nodes

2015-07-21 11:02 GMT+02:00 Thierry Reding <[email protected]>:

Quoted 20 lines · Mirza Krak
Quoted 18 lines

From: Mirza Krak <[email protected]>

Add the device tree node for the SPI controllers found on Tegra20 SOCs.

---
 arch/arm/dts/tegra20.dtsi | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm/dts/tegra20.dtsi +0 -0
index b8c8a923017e..82168c9012e3 100644
@@ -268,6 +268,50 @@
              #pwm-cells = <2>;
      };
 
Quoted 5 lines

arch/arm/dts/tegra20.dtsi line 272

Quoted 2 lines
arch/arm/dts/tegra20.dtsi +2 -0
+     spi at 7000d400 {
+             compatible = "nvidia,tegra30-slink", "nvidia,tegra20-slink";

This can't be correct on Tegra20 since Tegra30 didn't exist at the time. You'll need to drop the first string in the list for this to be correct.

Sent v2 of patch dropping tegra30 compatible string.

Quoted 6 lines

Also, might be worth copying these from the Linux kernel's copy of the device tree files, since they are slightly different. That might involve pulling in a couple of headers too, though, so might not be worth it.

Thierry

Pulling from Linux kernel's copy of these files is not something I am up for at the moment.

Signature · 14 lines
Med V?nliga H?lsningar / Best Regards

*******************************************************************
Mirza Krak
Host Mobility AB
mirza.krak at hostmobility.com
Anders Personsgatan 12, 416 64 G?teborg
Sweden
http://www.hostmobility.com
Direct: +46 31 31 32 704
Phone: +46 31 31 32 700
Fax: +46 31 80 67 51
Mobile: +46 730 28 06 22
*******************************************************************