Skip to contentSkip to conversation

b43: Fix typo in function name

PATCH Applied Nik Nyby 4 participants 4 messages Jun 30, 2015 – Jul 21, 2015 Networking drivers (wireless)

lore
Share & tools
lore

Nik Nyby

author
#0 lore raw

PATCH 1/1 b43: Fix typo in function name

This fixes a typo in the "b43_lo_g_maintenance_work" function name.

Signed-off-by Nik Nyby <[email protected]>
---
 drivers/net/wireless/b43/lo.c    | 4 ++--
 drivers/net/wireless/b43/lo.h    | 2 +-
 drivers/net/wireless/b43/phy_g.c | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/wireless/b43/lo.c +2 -2
index 916123a..a335f94 100644
@@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
 	b43_lo_write(dev, &cal->ctl);
 }
 
-/* Periodic LO maintanance work */
-void b43_lo_g_maintanance_work(struct b43_wldev *dev)
+/* Periodic LO maintenance work */
+void b43_lo_g_maintenance_work(struct b43_wldev *dev)
 {
 	struct b43_phy *phy = &dev->phy;
 	struct b43_phy_g *gphy = phy->g;
drivers/net/wireless/b43/lo.h +1 -1
index 3b27e20..7b4df38 100644
@@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
 
 void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);
 
-void b43_lo_g_maintanance_work(struct b43_wldev *dev);
+void b43_lo_g_maintenance_work(struct b43_wldev *dev);
 void b43_lo_g_cleanup(struct b43_wldev *dev);
 void b43_lo_g_init(struct b43_wldev *dev);
drivers/net/wireless/b43/phy_g.c +1 -1
index 727ce6e..462310e 100644
@@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
 		   phy->rev == 1) {
 		//TODO: implement rev1 workaround
 	}
-	b43_lo_g_maintanance_work(dev);
+	b43_lo_g_maintenance_work(dev);
 	b43_mac_enable(dev);
 }
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 b43: Fix typo in function name

Quoted 9 lines · Nik Nyby

This fixes a typo in the "b43_lo_g_maintenance_work" function name.

Signed-off-by Nik Nyby <[email protected]>
---
  drivers/net/wireless/b43/lo.c    | 4 ++--
  drivers/net/wireless/b43/lo.h    | 2 +-
  drivers/net/wireless/b43/phy_g.c | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)

This patch is OK; however, can there really be a typo in a function name? How do you ever know that the author did not mean to use a name that looks like a typo?

Please be careful with these.

Acked-by Larry Finger <[email protected]>

Larry

Quoted 43 lines
drivers/net/wireless/b43/lo.c +2 -2
index 916123a..a335f94 100644
@@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
  	b43_lo_write(dev, &cal->ctl);
  }
 
-/* Periodic LO maintanance work */
-void b43_lo_g_maintanance_work(struct b43_wldev *dev)
+/* Periodic LO maintenance work */
+void b43_lo_g_maintenance_work(struct b43_wldev *dev)
  {
  	struct b43_phy *phy = &dev->phy;
  	struct b43_phy_g *gphy = phy->g;
drivers/net/wireless/b43/lo.h +1 -1
index 3b27e20..7b4df38 100644
@@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
 
  void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);
 
-void b43_lo_g_maintanance_work(struct b43_wldev *dev);
+void b43_lo_g_maintenance_work(struct b43_wldev *dev);
  void b43_lo_g_cleanup(struct b43_wldev *dev);
  void b43_lo_g_init(struct b43_wldev *dev);
drivers/net/wireless/b43/phy_g.c +1 -1
index 727ce6e..462310e 100644
@@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
  		   phy->rev == 1) {
  		//TODO: implement rev1 workaround
  	}
-	b43_lo_g_maintanance_work(dev);
+	b43_lo_g_maintenance_work(dev);
  	b43_mac_enable(dev);
  }
#2 lore raw

PATCH 1/1 b43: Fix typo in function name

Quoted 11 lines · On Mon, 29 Jun 2015 20:29:24 -0500 Larry Finger <[email protected]>…
Quoted 9 lines · Nik Nyby

This fixes a typo in the "b43_lo_g_maintenance_work" function name.

Signed-off-by Nik Nyby <[email protected]>
---
  drivers/net/wireless/b43/lo.c    | 4 ++--
  drivers/net/wireless/b43/lo.h    | 2 +-
  drivers/net/wireless/b43/phy_g.c | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)
Quoted 6 lines

This patch is OK; however, can there really be a typo in a function name? How do you ever know that the author did not mean to use a name that looks like a typo?

Please be careful with these.

Acked-by Larry Finger <[email protected]>

Nice finding.
Me as the original author of that mess gets a brown paper bag and acks this.

Acked-by Michael Buesch <[email protected]>
Signature · 8 lines
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20150630/4994c090/attachment.sig>