Including rwlock.h directly will cause kernel builds to fail if CONFIG_PREEMPT_RT_FULL is defined. The correct header file (rwlock_rt.h OR rwlock.h) will be included by spinlock.h which is included by locktorture.c anyway.

---
 kernel/locking/locktorture.c | 1 -
 1 file changed, 1 deletion(-)

kernel/locking/locktorture.c +0 -1

index ec8cce2..aa60d91 100644
@@ -24,7 +24,6 @@
 #include <linux/module.h>
 #include <linux/kthread.h>
 #include <linux/spinlock.h>
-#include <linux/rwlock.h>
 #include <linux/mutex.h>
 #include <linux/rwsem.h>
 #include <linux/smp.h>

Signature · 1 line

1.9.1

Quoted 36 lines · Steven Rostedt

Dear RT Folks,
I'm pleased to announce the 3.18.17-rt14 stable release.
This release is just an update to the new stable 3.18.17 version and no RT specific changes have been made.
You can get this release via the git tree at:
   git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt.git

   branch: v3.18-rt
   Head SHA1: bba903c2bb20dbb6c57a8ba3889f9b8f09dcc6e0
Or to build 3.18.17-rt14 directly, the following patches should be applied:
   http://www.kernel.org/pub/linux/kernel/v3.x/linux-3.18.tar.xz

   http://www.kernel.org/pub/linux/kernel/v3.x/patch-3.18.17.xz

   http://www.kernel.org/pub/linux/kernel/projects/rt/3.18/patch-3.18.17-rt14.patch.xz
Enjoy,
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Sebastian Andrzej Siewior

2015-07-20 15:47 UTC #2 lore raw

Re: [PATCH 1/1] 3.18.17-rt14 locktorture: Do NOT include rwlock.h directly

Quoted 4 lines · * linuxball | 2015-07-20 11:33:12 [+0200]:

Including rwlock.h directly will cause kernel builds to fail if CONFIG_PREEMPT_RT_FULL is defined. The correct header file (rwlock_rt.h OR rwlock.h) will be included by spinlock.h which is included by locktorture.c anyway.

Documentation/SubmittingPatches:
11) Sign your work

Sebastian

linuxball

2015-07-21 14:20 UTC #3 lore raw

Re: [PATCH 1/1] 3.18.17-rt14 locktorture: Do NOT include rwlock.h directly

Signed-off-by Wolfgang M. Reimer <[email protected]>

---
 kernel/locking/locktorture.c | 1 -
 1 file changed, 1 deletion(-)

kernel/locking/locktorture.c +0 -1

index ec8cce2..aa60d91 100644
@@ -24,7 +24,6 @@
 #include <linux/module.h>
 #include <linux/kthread.h>
 #include <linux/spinlock.h>
-#include <linux/rwlock.h>
 #include <linux/mutex.h>
 #include <linux/rwsem.h>
 #include <linux/smp.h>

Signature · 1 line

1.9.1

Quoted 10 lines · Sebastian Andrzej Siewior

Quoted 4 lines · * linuxball | 2015-07-20 11:33:12 [+0200]:
Including rwlock.h directly will cause kernel builds to fail if CONFIG_PREEMPT_RT_FULL is defined. The correct header file (rwlock_rt.h OR rwlock.h) will be included by spinlock.h which is included by locktorture.c anyway.
Documentation/SubmittingPatches:
11) Sign your work
Sebastian

Sebastian Andrzej Siewior

2015-07-21 16:45 UTC #4 lore raw

Re: [PATCH 1/1] 3.18.17-rt14 locktorture: Do NOT include rwlock.h directly

Quoted 6 lines · * linuxball | 2015-07-21 16:20:07 [+0200]:

Including rwlock.h directly will cause kernel builds to fail if CONFIG_PREEMPT_RT_FULL is defined. The correct header file (rwlock_rt.h OR rwlock.h) will be included by spinlock.h which is included by locktorture.c anyway.
Signed-off-by Wolfgang M. Reimer <[email protected]>

If you don't mind I set From: to you have here. If you intendent to sent further patches I suggest that you get rid of "format=flowed" which adds a white space for no reason to the diff. I won't fix it again.

Sebastian