Skip to contentSkip to conversation

freerdp: Add support for tz package

PATCH New FanChengPing 2 participants 2 messages Jul 21, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 freerdp: Add support for tz package

Fixes error message while freerdp connected the remote desktop:
Unable to detect time zone

---
 .../freerdp/0004-add-support-for-tz-package.patch  | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch
package/freerdp/0004-add-support-for-tz-package.patch new file +30 -0
new file mode 100644
index 0000000..93e4afd
@@ -0,0 +1,30 @@
+From 605d0a85183d2f9d5b0da5629cbadf01173bbb2f Mon Sep 17 00:00:00 2001
+From: Scott Fan <[email protected]>
+Date: Mon, 13 Jul 2015 15:01:17 +0800
+Subject: [PATCH] Add support for tz package
+
+Fixes error message while freerdp connected the remote desktop:
+Unable to detect time zone
+
+Signed-off-by: Scott Fan <[email protected]>
+---
+ libfreerdp/locale/timezone.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/libfreerdp/locale/timezone.c b/libfreerdp/locale/timezone.c
+index 3070f1f..4a06786 100644
+--- a/libfreerdp/locale/timezone.c
++++ b/libfreerdp/locale/timezone.c
+@@ -1539,7 +1539,8 @@ char* freerdp_get_unix_timezone_identifier()
+ 	 * America/Montreal for example.
+ 	 */
+ 	
+-	if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1)
++	if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1 ||
++	    (len = readlink("/etc/TZ", buf, sizeof(buf) - 1)) != -1)
+ 	{
+ 		int num = 0;
+ 		int pos = len;
+-- 
+2.4.5
+
Signature · 1 line
2.4.6
#1 lore raw

PATCH 1/4 freerdp: Add support for tz package

Dear FanChengPing,

Could you fix your setup so that the From: and Signed-off-by: are matching, and are the same for every patch?

In this current version you posted, the first two patches have:

From: FanChengPing <[email protected]>

(which is not good)

and the last two patches have:

From: Scott Fan <[email protected]>

which is good.

Also, when posting new version, please add a version number to your patches, by using:

	git format-patch --subject-prefix="PATCH v2"

as well as a changelog between the versions, either in a cover letter e-mail (--cover argument of git format-patch) or in the individual patches. See
http://buildroot.org/downloads/manual/manual.html#submitting-patches
for more details.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com