lpfc: Use && instead of & for boolean expression

PATCH In review Sebastian Herbszt 2 participants 2 messages Jul 22, 2015

Subsystems (2)

SCSI Emulex/Broadcom lpfc FC/FCoE SCSI driver

lore

Share & tools

lore

Sebastian Herbszt

author

2015-07-22 08:53 UTC #0 lore raw

PATCH 1/1 lpfc: Use && instead of & for boolean expression

Use logical instead of bitwise AND.

Signed-off-by Sebastian Herbszt <[email protected]>

---

drivers/scsi/lpfc/lpfc_hbadisc.c +1 -1

diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -701,7 +701,7 @@ lpfc_work_done(struct lpfc_hba *phba)
 								HA_RXMASK));
 			}
 		}
-		if ((phba->sli_rev == LPFC_SLI_REV4) &
+		if ((phba->sli_rev == LPFC_SLI_REV4) &&
 				 (!list_empty(&pring->txq)))
 			lpfc_drain_txq(phba);
 		/*

James Smart

Reviewed-by on v1 1/1

2015-07-22 15:47 UTC #1 lore raw

Reviewed-by James Smart <[email protected]>

Thanks

-- james

Quoted 17 lines · Sebastian Herbszt

Use logical instead of bitwise AND.
Signed-off-by Sebastian Herbszt <[email protected]>
---
diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
drivers/scsi/lpfc/lpfc_hbadisc.c +1 -1
@@ -701,7 +701,7 @@ lpfc_work_done(struct lpfc_hba *phba)
  								HA_RXMASK));
  			}
  		}
-		if ((phba->sli_rev == LPFC_SLI_REV4) &
+		if ((phba->sli_rev == LPFC_SLI_REV4) &&
  				 (!list_empty(&pring->txq)))
  			lpfc_drain_txq(phba);
  		/*