Skip to contentSkip to conversation

package/ulogd: remove autoreconf

PATCH New Romain Naour 2 participants 14 messages Jul 20, 2015 – Jul 22, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/11 package/ulogd: remove autoreconf

Autoreconf is not needed anymore since ulogd 2.0.4 where logd-01-pthread-conditional.patch was removed.

commit: 010745a955b6cf4c979588fafdb7506460038e0f

---
 package/ulogd/ulogd.mk | 1 -
 1 file changed, 1 deletion(-)
package/ulogd/ulogd.mk +0 -1
index 7ff5b73..7730198 100644
@@ -8,7 +8,6 @@ ULOGD_VERSION = 2.0.5
 ULOGD_SOURCE = ulogd-$(ULOGD_VERSION).tar.bz2
 ULOGD_SITE = http://www.netfilter.org/projects/ulogd/files
 ULOGD_CONF_OPTS = --with-dbi=no --with-pgsql=no
-ULOGD_AUTORECONF = YES
 ULOGD_DEPENDENCIES = host-pkgconf \
 	libmnl libnetfilter_acct libnetfilter_conntrack libnetfilter_log \
 	libnfnetlink
Signature · 1 line
2.4.3
#1 lore raw

PATCH 2/11 package/stress: remove autoreconf

autoreconf is not needed anymore since non-lfs enabler patch has been removed.

commit: 415765b5a8861f3b7e86e9786bf903a5a4d09e73

---
 package/stress/stress.mk | 1 -
 1 file changed, 1 deletion(-)
package/stress/stress.mk +0 -1
index 4bb801e..1b5ba06 100644
@@ -8,7 +8,6 @@ STRESS_VERSION = 1.0.4
 STRESS_SITE = http://people.seas.harvard.edu/~apw/stress
 STRESS_LICENSE = GPLv2+
 STRESS_LICENSE_FILES = COPYING
-STRESS_AUTORECONF = YES
 
 # Stress is linked statically if the --enable-static is specified.
 # However, this option is always specified in the global
Signature · 1 line
2.4.3
#2 lore raw

PATCH 3/11 package/wipe: remove autoreconf

In reply to Romain Naour

A configure script is already bundled in the archive. There is no comment why autoreconf was added.

---
Not sure, to be tested.

---
 package/wipe/wipe.mk | 1 -
 1 file changed, 1 deletion(-)
package/wipe/wipe.mk +0 -1
index 38cb434..9ec7faf 100644
@@ -7,7 +7,6 @@
 WIPE_VERSION = 2.3.1
 WIPE_SITE = http://downloads.sourceforge.net/project/wipe/wipe/$(WIPE_VERSION)
 WIPE_SOURCE = wipe-$(WIPE_VERSION).tar.bz2
-WIPE_AUTORECONF = YES
 WIPE_LICENSE = GPLv2+
 WIPE_LICENSE_FILES = LICENSE
 
Signature · 1 line
2.4.3
#3 lore raw

PATCH 4/11 package/neard: remove autoreconf

In reply to Romain Naour

neard have been bumped several time since autoreconf was added in neard.mk.
autoreconf seems not needed anymore.

---
 package/neard/neard.mk | 1 -
 1 file changed, 1 deletion(-)
package/neard/neard.mk +0 -1
index fc92421..ed2c6b1 100644
@@ -10,7 +10,6 @@ NEARD_SITE = $(BR2_KERNEL_MIRROR)/linux/network/nfc
 NEARD_LICENSE = GPLv2
 NEARD_LICENSE_FILES = COPYING
 
-NEARD_AUTORECONF = YES
 NEARD_DEPENDENCIES = host-pkgconf dbus libglib2 libnl
 NEARD_CONF_OPTS = --disable-traces
 
Signature · 1 line
2.4.3
#4 lore raw

PATCH 5/11 package/dhcp: remove autoreconf

In reply to Romain Naour

0001-fix-configure-debug.patch was removed in
commit 68e846d3b2875b5e7a79bfb33629bf2793840939

---
 package/dhcp/dhcp.mk | 2 --
 1 file changed, 2 deletions(-)
package/dhcp/dhcp.mk +0 -2
index c0d4588..effcbe2 100644
@@ -9,8 +9,6 @@ DHCP_SITE = http://ftp.isc.org/isc/dhcp/$(DHCP_VERSION)
 DHCP_INSTALL_STAGING = YES
 DHCP_LICENSE = ISC
 DHCP_LICENSE_FILES = LICENSE
-# For 0001-fix-configure-debug.patch
-DHCP_AUTORECONF = YES
 DHCP_CONF_ENV = \
 	CPPFLAGS='-D_PATH_DHCPD_CONF=\"/etc/dhcp/dhcpd.conf\" \
 		-D_PATH_DHCLIENT_CONF=\"/etc/dhcp/dhclient.conf\"' \
Signature · 1 line
2.4.3
#5 lore raw

PATCH 6/11 package/libfslparser: remove autoreconf

In reply to Romain Naour

autoreconf is not needed anymore with the current
version (4.0.2).

---
 package/libfslparser/libfslparser.mk | 3 ---
 1 file changed, 3 deletions(-)
package/libfslparser/libfslparser.mk +0 -3
index 50f0bf6..116a0a2 100644
@@ -20,7 +20,4 @@ endef
 # The Makefile installs several versions of the libraries, but we only
 # need one of them, depending on the platform.
 
-# without AUTORECONF, configure fails to find install-sh.
-LIBFSLPARSER_AUTORECONF = YES
-
 $(eval $(autotools-package))
Signature · 1 line
2.4.3
#6 lore raw

PATCH 7/11 package/libdvbsi: remove autoreconf

In reply to Romain Naour

A configure script is bundled with the archive
of the current version.

---
 package/libdvbsi/libdvbsi.mk | 3 ---
 1 file changed, 3 deletions(-)
package/libdvbsi/libdvbsi.mk +0 -3
index ed8b382..f6469f9 100644
@@ -11,7 +11,4 @@ LIBDVBSI_INSTALL_STAGING = YES
 LIBDVBSI_LICENSE = LGPLv2.1
 LIBDVBSI_LICENSE_FILES = COPYING
 
-# sometimes no Makefile is in the archive, just (re)generate
-LIBDVBSI_AUTORECONF = YES
-
 $(eval $(autotools-package))
Signature · 1 line
2.4.3
#7 lore raw

PATCH 8/11 package/lttng-tools: remove autoreconf

In reply to Romain Naour

lttng-tools-2.0-pre15-no-sync-file-range-in-uclibc.patch is gone with the commit fb5d605638c359d008329dd9f8fb6c2c8a2c0537.

lttng-tools-no-sync-file-range-in-uclibc.patch is gone with the commit ed692e2dbbf8d4751d39a636dd1119e829bd0f99.

There is no need to autoreconf lttng-tools.

---
 package/lttng-tools/lttng-tools.mk | 2 --
 1 file changed, 2 deletions(-)
package/lttng-tools/lttng-tools.mk +0 -2
index e218a95..0cd381c 100644
@@ -17,8 +17,6 @@ LTTNG_TOOLS_CONF_OPTS += --with-xml-prefix=$(STAGING_DIR)/usr
 # trace format into an human readable format.
 LTTNG_TOOLS_DEPENDENCIES = liburcu libxml2 popt host-lttng-babeltrace util-linux
 
-LTTNG_AUTORECONF = YES
-
 ifeq ($(BR2_PACKAGE_LTTNG_LIBUST),y)
 LTTNG_TOOLS_CONF_OPTS += --enable-lttng-ust
 LTTNG_TOOLS_DEPENDENCIES += lttng-libust
Signature · 1 line
2.4.3
#8 lore raw

PATCH 9/11 package/x11r7/xdriver_xf86-video-neomagic: remove autoreconf

In reply to Romain Naour

xdriver_xf86-video-neomagic no longer use the git repository.

commit: 560660d06be550aed1f1bfa52bbe58be5fdc387d

---
 package/x11r7/xdriver_xf86-video-neomagic/xdriver_xf86-video-neomagic.mk | 1 -
 1 file changed, 1 deletion(-)
package/x11r7/xdriver_xf86-video-neomagic/xdriver_xf86-video-neomagic.mk +0 -1
index c307761..cfd5536 100644
@@ -9,7 +9,6 @@ XDRIVER_XF86_VIDEO_NEOMAGIC_SOURCE = xf86-video-neomagic-$(XDRIVER_XF86_VIDEO_NE
 XDRIVER_XF86_VIDEO_NEOMAGIC_SITE = http://xorg.freedesktop.org/releases/individual/driver
 XDRIVER_XF86_VIDEO_NEOMAGIC_LICENSE = MIT
 XDRIVER_XF86_VIDEO_NEOMAGIC_LICENSE_FILES = COPYING
-XDRIVER_XF86_VIDEO_NEOMAGIC_AUTORECONF = YES
 XDRIVER_XF86_VIDEO_NEOMAGIC_DEPENDENCIES = xserver_xorg-server xproto_fontsproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xf86dgaproto xproto_xproto
 
 $(eval $(autotools-package))
Signature · 1 line
2.4.3
#9 lore raw

PATCH 10/11 package/xdriver_xf86-video-cirrus: remove autoreconf

In reply to Romain Naour

xdriver_xf86-video-cirrus no longer use the git repository.

commit: e45edc34fadcd6e666a123a4ab32a13b37dc3f74

---
 package/x11r7/xdriver_xf86-video-cirrus/xdriver_xf86-video-cirrus.mk | 1 -
 1 file changed, 1 deletion(-)
package/x11r7/xdriver_xf86-video-cirrus/xdriver_xf86-video-cirrus.mk +0 -1
index f2523db..78e8a9c 100644
@@ -9,7 +9,6 @@ XDRIVER_XF86_VIDEO_CIRRUS_SOURCE = xf86-video-cirrus-$(XDRIVER_XF86_VIDEO_CIRRUS
 XDRIVER_XF86_VIDEO_CIRRUS_SITE = http://xorg.freedesktop.org/releases/individual/driver
 XDRIVER_XF86_VIDEO_CIRRUS_LICENSE = MIT
 XDRIVER_XF86_VIDEO_CIRRUS_LICENSE_FILES = COPYING
-XDRIVER_XF86_VIDEO_CIRRUS_AUTORECONF = YES
 XDRIVER_XF86_VIDEO_CIRRUS_DEPENDENCIES = xserver_xorg-server xproto_fontsproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xproto
 
 $(eval $(autotools-package))
Signature · 1 line
2.4.3
#10 lore raw

PATCH 11/11 package/x11r7/xdriver_xf86-video-siliconmotion: remove autoreconf

In reply to Romain Naour

xdriver_xf86-video-siliconmotion no longer use the git repository.

commit: b343bc690e0004ab916eda09d88be9f4210e867b

---
 .../xdriver_xf86-video-siliconmotion/xdriver_xf86-video-siliconmotion.mk | 1 -
 1 file changed, 1 deletion(-)
package/x11r7/xdriver_xf86-video-siliconmotion/xdriver_xf86-video-siliconmotion.mk +0 -1
index 37e87a5..2aa22ae 100644
@@ -9,7 +9,6 @@ XDRIVER_XF86_VIDEO_SILICONMOTION_SOURCE = xf86-video-siliconmotion-$(XDRIVER_XF8
 XDRIVER_XF86_VIDEO_SILICONMOTION_SITE = http://xorg.freedesktop.org/releases/individual/driver
 XDRIVER_XF86_VIDEO_SILICONMOTION_LICENSE = MIT
 XDRIVER_XF86_VIDEO_SILICONMOTION_LICENSE_FILES = COPYING
-XDRIVER_XF86_VIDEO_SILICONMOTION_AUTORECONF = YES
 XDRIVER_XF86_VIDEO_SILICONMOTION_DEPENDENCIES = xserver_xorg-server xproto_fontsproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xproto
 
 $(eval $(autotools-package))
Signature · 1 line
2.4.3
#11 lore raw

PATCH 1/11 package/ulogd: remove autoreconf

In reply to Romain Naour

Dear Romain Naour,

Quoted 9 lines · Romain Naour

Autoreconf is not needed anymore since ulogd 2.0.4 where logd-01-pthread-conditional.patch was removed.

commit: 010745a955b6cf4c979588fafdb7506460038e0f

---
 package/ulogd/ulogd.mk | 1 -
 1 file changed, 1 deletion(-)

All 11 patches applied, thanks. I have not tested them, I trust you :) The autobuilders will tell me if I was right or not! :-)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#12 lore raw

PATCH 1/11 package/ulogd: remove autoreconf

Hi Thomas,

Le 20/07/2015 22:56, Thomas Petazzoni a ?crit :

Quoted 8 lines

Dear Romain Naour,

Quoted 5 lines · Romain Naour

Autoreconf is not needed anymore since ulogd 2.0.4 where logd-01-pthread-conditional.patch was removed.

commit: 010745a955b6cf4c979588fafdb7506460038e0f

Quoted 7 lines
Quoted 4 lines
---
 package/ulogd/ulogd.mk | 1 -
 1 file changed, 1 deletion(-)

All 11 patches applied, thanks. I have not tested them, I trust you :) The autobuilders will tell me if I was right or not! :-)

I haven't see any build failure due to this series :)
So, I guess you was right but maybe there are too many build failure in autobuilders to see something ;-)

Seriously, I've tested each packages by selecting each of them in the config and build the entire config to see if all build fine.

Thanks,
Romain

Quoted 5 lines

Thanks!

Thomas

#13 lore raw

PATCH 1/11 package/ulogd: remove autoreconf

Romain,

Quoted 9 lines · Romain Naour
Quoted 2 lines

All 11 patches applied, thanks. I have not tested them, I trust you :) The autobuilders will tell me if I was right or not! :-)

I haven't see any build failure due to this series :)
So, I guess you was right but maybe there are too many build failure in autobuilders to see something ;-)

Seriously, I've tested each packages by selecting each of them in the config and build the entire config to see if all build fine.

Yes, so far I haven't identified any of the build failure to be caused by this series, so it looks good. Of course as you say, there are quite a lot of build failures currently, so it's hard to say if it really didn't cause any regression.

But no worries, I'm sure it's going to be OK :)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com