fs: Remove ext3 filesystem driver In-Reply-To: <[email protected]>
Heya,
So I did a trimmed export of the patch from repository pointed out, and I have a comment about the config change below. I'm pretty sure i probably got the headers wrong, so sorry if i break threading with this email.
Quoted 22 lines · Jan Kara
The functionality of ext3 is fully supported by ext4 driver. Major distributions (SUSE, RedHat) already use ext4 driver to handle ext3 filesystems for quite some time. There is some ugliness in mm resulting from jbd cleaning buffers in a dirty page without cleaning page dirty bit and also support for buffer bouncing in the block layer when stable pages are required is there only because of jbd. So let's remove the ext3 driver.
Signed-off-by Jan Kara <[email protected]>fs/ext4/Kconfig +1
-1@@ -28,14 +28,14 @@ config EXT4_FS If unsure, say N. -config EXT4_USE_FOR_EXT23 +config EXT4_USE_FOR_EXT2 bool "Use ext4 for ext2/ext3 file systems" depends on EXT4_FS
fs/ext4/Kconfig config EXT4_FS · line 40
Quoted 10 lines
fs/ext4/Kconfig +3
-3- depends on EXT3_FS=n || EXT2_FS=n + depends on EXT2_FS=n default y help - Allow the ext4 file system driver code to be used for ext2 or - ext3 file system mounts. This allows users to reduce their + Allow the ext4 file system driver code to be used for ext2 + file system mounts. This allows users to reduce their compiled kernel size by using one file system driver for ext2, ext3, and ext4 file systems.
I would prefer not to change the config option name or text, and only change the depends. Cause ext4 driver in fact can be used for ext2/3, and can be used for ext2 or ext3 system mounts. The fact that there isn't an ext3 module anymore, doesn't change ext4 driver.
I presume this option will remain even when both ext2 and ext3 drivers get dropped, such that one can toggle off ext2/3 portions of ext4 driver. Or am I wrong?
Signature · 3 lines
Regards, Dimitri.
Hello,
Quoted 32 lines · Dimitri John Ledkov
So I did a trimmed export of the patch from repository pointed out, and I have a comment about the config change below. I'm pretty sure i probably got the headers wrong, so sorry if i break threading with this email.
Quoted 29 lines · Jan Kara
The functionality of ext3 is fully supported by ext4 driver. Major distributions (SUSE, RedHat) already use ext4 driver to handle ext3 filesystems for quite some time. There is some ugliness in mm resulting from jbd cleaning buffers in a dirty page without cleaning page dirty bit and also support for buffer bouncing in the block layer when stable pages are required is there only because of jbd. So let's remove the ext3 driver.
Signed-off-by Jan Kara <[email protected]>fs/ext4/Kconfig +3
-4@@ -28,14 +28,14 @@ config EXT4_FS If unsure, say N. -config EXT4_USE_FOR_EXT23 +config EXT4_USE_FOR_EXT2 bool "Use ext4 for ext2/ext3 file systems" depends on EXT4_FS - depends on EXT3_FS=n || EXT2_FS=n + depends on EXT2_FS=n default y help - Allow the ext4 file system driver code to be used for ext2 or - ext3 file system mounts. This allows users to reduce their + Allow the ext4 file system driver code to be used for ext2
Quoted 8 lines
fs/ext4/Kconfig config EXT4_FS · line 40
Quoted 3 lines
fs/ext4/Kconfig +1
-0+ file system mounts. This allows users to reduce their compiled kernel size by using one file system driver for ext2, ext3, and ext4 file systems.I would prefer not to change the config option name or text, and only change the depends. Cause ext4 driver in fact can be used for ext2/3, and can be used for ext2 or ext3 system mounts. The fact that there isn't an ext3 module anymore, doesn't change ext4 driver.
But the fact is that even if this config option will be disabled, ext4 will still be used for handling ext3 filesystems. That's the reason why I changed the config name and description. And in the last patch of the series you can see I've somewhat updated ext4 description to make it clearer it's used for ext3 as well.
Quoted 3 lines
I presume this option will remain even when both ext2 and ext3 drivers get dropped, such that one can toggle off ext2/3 portions of ext4 driver. Or am I wrong?
I don't plan this option to remain if we ever drop ext2 codebase as well. We don't have anything like "ext2" or "ext3" portion of the ext4 driver (well, we do but it's like 30 lines of code) because from the fs driver point of view it's all the same filesystem just with particular on filesystem features being disabled or enabled...
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR