Skip to contentSkip to conversation

i2c: tegra: Build warning fixes for 64-bit

PATCH New Stephen Warren 3 participants 4 messages Jul 22, 2015 – Jul 23, 2015

Subsystems (2)
Tegra architecture support I2C
lore
Share & tools
lore

Stephen Warren

author
#0 lore raw

PATCH 1/1 i2c: tegra: Build warning fixes for 64-bit

From: Thierry Reding <[email protected]>

Signed-off-by Thierry Reding <[email protected]>
Signed-off-by Tom Warren <[email protected]>
Signed-off-by Stephen Warren <[email protected]>
---
 drivers/i2c/tegra_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/tegra_i2c.c +2 -2
index fc9564699489..a4289788a65c 100644
@@ -235,7 +235,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
 			if ((words == 1) && last_bytes) {
 				local = 0;
 				memcpy(&local, dptr, last_bytes);
-			} else if ((unsigned)dptr & 3) {
+			} else if ((unsigned long)dptr & 3) {
 				memcpy(&local, dptr, sizeof(u32));
 			} else {
 				local = *wptr;

@@ -258,7 +258,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
 			local = readl(&control->rx_fifo);
 			if ((words == 1) && last_bytes)
 				memcpy(dptr, (char *)&local, last_bytes);
-			else if ((unsigned)dptr & 3)
+			else if ((unsigned long)dptr & 3)
 				memcpy(dptr, &local, sizeof(u32));
 			else
 				*wptr = local;
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 i2c: tegra: Build warning fixes for 64-bit

On 07/22/2015 03:33 PM, Stephen Warren wrote:

Apparently Heiko is out-of-the-office until Aug 10th.

Tom Rini, perhaps you could apply this directly to u-boot.git, or ack it so that Tom Warren can apply it to the Tegra tree? The basic Tegra210 SoC patches will rely on these warnings being fixed, and I'd rather not hold off getting the SoC patches applied until mid-August.

Quoted 25 lines
  drivers/i2c/tegra_i2c.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/i2c/tegra_i2c.c +2 -2
index fc9564699489..a4289788a65c 100644
@@ -235,7 +235,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
  			if ((words == 1) && last_bytes) {
  				local = 0;
  				memcpy(&local, dptr, last_bytes);
-			} else if ((unsigned)dptr & 3) {
+			} else if ((unsigned long)dptr & 3) {
  				memcpy(&local, dptr, sizeof(u32));
  			} else {
  				local = *wptr;

@@ -258,7 +258,7 @@ static int send_recv_packets(struct i2c_bus *i2c_bus,
  			local = readl(&control->rx_fifo);
  			if ((words == 1) && last_bytes)
  				memcpy(dptr, (char *)&local, last_bytes);
-			else if ((unsigned)dptr & 3)
+			else if ((unsigned long)dptr & 3)
  				memcpy(dptr, &local, sizeof(u32));
  			else
  				*wptr = local;
#2 lore raw

PATCH 1/1 i2c: tegra: Build warning fixes for 64-bit

In reply to Stephen Warren
Quoted 5 lines · Stephen Warren

From: Thierry Reding <[email protected]>

Signed-off-by Thierry Reding <[email protected]>
Signed-off-by Tom Warren <[email protected]>
Signed-off-by Stephen Warren <[email protected]>
Acked-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150722/f5c65cba/attachment.sig>