Skip to contentSkip to conversation

target-i386/FPU: a misprint in helper_fistll_ST0

PATCH In review Dmitry Poletaev 2 participants 2 messages Jul 8, 2015 – Jul 23, 2015

lore
Share & tools
lore

Dmitry Poletaev

author
#0 lore raw

PATCH 1/1 target-i386/FPU: a misprint in helper_fistll_ST0

There is a misprint in the patch https://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01657.html . It cause errors in guest work. Here is the bugfix.

From: Dmitry Poletaev <[email protected]>

Signed-off-by Dmitry Poletaev <[email protected]>
Reported-by Kirill Batuzov <[email protected]>
---
 target-i386/fpu_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target-i386/fpu_helper.c +1 -1
index fc25a03..fcf400d 100644
@@ -273,7 +273,7 @@ int64_t helper_fistll_ST0(CPUX86State *env)
     old_exp_flags = get_float_exception_flags(&env->fp_status);
     set_float_exception_flags(0, &env->fp_status);
     
-    val = floatx80_to_int32(ST0, &env->fp_status);
+    val = floatx80_to_int64(ST0, &env->fp_status);
     if (get_float_exception_flags(&env->fp_status) & float_flag_invalid) {
         val = 0x8000000000000000ULL;
     }
Signature · 1 line
1.8.4.msysgit.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Dmitry Poletaev

There is a misprint in the patch https://lists.gnu.org/archive/html/qemu-devel/2014-11/msg01657.html . It cause errors in guest work. Here is the bugfix.

From: Dmitry Poletaev <[email protected]>

Signed-off-by Dmitry Poletaev <[email protected]>
Reported-by Kirill Batuzov <[email protected]>
---
 target-i386/fpu_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target-i386/fpu_helper.c +0 -0
index fc25a03..fcf400d 100644

target-i386/fpu_helper.c int64_t helper_fistll_ST0(CPUX86State *env) · line 279

Quoted 8 lines
target-i386/fpu_helper.c +1 -1
@@ -273,7 +273,7 @@ int64_t helper_fistll_ST0(CPUX86State *env)
     old_exp_flags = get_float_exception_flags(&env->fp_status);
     set_float_exception_flags(0, &env->fp_status);
 
-    val = floatx80_to_int32(ST0, &env->fp_status);
+    val = floatx80_to_int64(ST0, &env->fp_status);
     if (get_float_exception_flags(&env->fp_status) & float_flag_invalid) {
         val = 0x8000000000000000ULL;
     }
Reviewed-by Aurelien Jarno <[email protected]>

Adding the maintainers of target-i386 in the loop so they might pick-up the patch for 2.4.

Signature · 2 lines
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
[email protected]                 http://www.aurel32.net