mosh: new package
PATCH v4 1/1 mosh: new package
Adding mosh, the mobile shell.
Signed-off-by Christian Stewart <[email protected]>
--- package/Config.in | 1 + package/mosh/0001-remove-system-locale-calls.patch | 49 ++++++++++++++++++++++ package/mosh/Config.in | 28 +++++++++++++ package/mosh/mosh.hash | 1 + package/mosh/mosh.mk | 16 +++++++ 5 files changed, 95 insertions(+) create mode 100644 package/mosh/0001-remove-system-locale-calls.patch create mode 100644 package/mosh/Config.in create mode 100644 package/mosh/mosh.hash create mode 100644 package/mosh/mosh.mk
package/Config.in +1 -0
@@ -1250,6 +1250,7 @@ endif source "package/mongoose/Config.in" source "package/mongrel2/Config.in" source "package/monkey/Config.in" + source "package/mosh/Config.in" source "package/mosquitto/Config.in" source "package/mrouted/Config.in" source "package/mtr/Config.in"
package/mosh/0001-remove-system-locale-calls.patch new file +49 -0
49 lines not on this page · raw message
package/mosh/Config.in new file +28 -0
@@ -0,0 +1,28 @@ + +comment "mosh needs openssh and openssl to be built" + depends on !BR2_PACKAGE_OPENSSH || !BR2_PACKAGE_OPENSSL + +comment "mosh works on arm, i386, mipsel, or x64 architectures" + depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 + +comment "mosh needs a toolchain w/ threads" + depends on !BR2_TOOLCHAIN_HAS_THREADS + +comment "mosh needs a host architecture of x64 or x86" + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" + +config BR2_PACKAGE_MOSH + bool "mosh" + depends on BR2_PACKAGE_OPENSSL + depends on BR2_PACKAGE_OPENSSH + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" + select BR2_PACKAGE_PROTOBUF + select BR2_PACKAGE_NCURSES + help + Remote terminal application that supports intermittent connectivity, + allows roaming, and provides speculative local echo and line editing + of user keystrokes. + + https://github.com/keithw/mosh
package/mosh/mosh.hash new file +1 -0
@@ -0,0 +1 @@ +sha256 35025d412046ee5199ebaa8d876131fc683dccedde18b3945b3bc3662bc9f373 mosh-1.2.5.tar.gz
package/mosh/mosh.mk new file +16 -0
@@ -0,0 +1,16 @@ +################################################################################ +# +# mosh +# +################################################################################ + +MOSH_VERSION = 1.2.5 +MOSH_SITE = $(call github,keithw,mosh,mosh-$(MOSH_VERSION)) +MOSH_DEPENDENCIES = zlib ncurses protobuf openssl +MOSH_LICENSE = GPLv3+ +MOSH_LICENSE_FILES = COPYING COPYING.iOS + +# Necessary as we are pulling from Git. +MOSH_AUTORECONF = YES + +$(eval $(autotools-package))
Signature · 1 line
2.1.4
PATCH v4 1/1 mosh: new package
Hi Christian,
package/mosh/Config.in line 6
Quoted 12 lines · Christian Stewart
package/mosh/Config.in new file +6
-0@@ -0,0 +1,28 @@ + +comment "mosh needs openssh and openssl to be built" + depends on !BR2_PACKAGE_OPENSSH || !BR2_PACKAGE_OPENSSL + +comment "mosh works on arm, i386, mipsel, or x64 architectures" + depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
Target architecture dependency comments are not very helpful, since the user can't do much about it is most cases. Moreover the other dependency comment should only show when the target architecture is supported.
package/mosh/Config.in line 17
Quoted 11 lines
package/mosh/Config.in new file +11
-0+ +comment "mosh needs a toolchain w/ threads" + depends on !BR2_TOOLCHAIN_HAS_THREADS + +comment "mosh needs a host architecture of x64 or x86" + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" + +config BR2_PACKAGE_MOSH + bool "mosh" + depends on BR2_PACKAGE_OPENSSL + depends on BR2_PACKAGE_OPENSSH
I still think this two should be 'select'.
Quoted 17 lines
package/mosh/Config.in new file +11
-0+ depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" + select BR2_PACKAGE_PROTOBUF + select BR2_PACKAGE_NCURSES + help + Remote terminal application that supports intermittent connectivity, + allows roaming, and provides speculative local echo and line editing + of user keystrokes. + + https://github.com/keithw/moshpackage/mosh/mosh.hash new file +0
-0
package/mosh/mosh.hash line 1
Quoted 1 line
package/mosh/mosh.hash new file +1
-0@@ -0,0 +1 @@ +sha256 35025d412046ee5199ebaa8d876131fc683dccedde18b3945b3bc3662bc9f373 mosh-1.2.5.tar.gz
This doesn't match the hash mentioned at
https://github.com/keithw/mosh/releases/tag/mosh-1.2.5. This is most likely due to your use of git checkout. Please use the official release tarballs, either https://mosh.mit.edu/mosh-1.2.5.tar.gz or
https://github.com/keithw/mosh/releases/download/mosh-1.2.5/mosh-1.2.5.tar.gz.
Both match tag message hash.
Quoted 6 lines
package/mosh/mosh.mk new file +0
-0
package/mosh/mosh.mk line 10
Quoted 10 lines
package/mosh/mosh.mk new file +10
-0@@ -0,0 +1,16 @@ +################################################################################ +# +# mosh +# +################################################################################ + +MOSH_VERSION = 1.2.5 +MOSH_SITE = $(call github,keithw,mosh,mosh-$(MOSH_VERSION)) +MOSH_DEPENDENCIES = zlib ncurses protobuf openssl +MOSH_LICENSE = GPLv3+
License exceptions?
package/mosh/mosh.mk line 14
Quoted 4 lines
package/mosh/mosh.mk new file +4
-0+MOSH_LICENSE_FILES = COPYING COPYING.iOS + +# Necessary as we are pulling from Git. +MOSH_AUTORECONF = YES
The official tarball should not need autoreconf.
package/mosh/mosh.mk line 16
Quoted 1 line
package/mosh/mosh.mk new file +1
-0+$(eval $(autotools-package))
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH v4 1/1 mosh: new package
In reply to Christian StewartDear Christian Stewart,
Review
Quoted 2 lines · Christian Stewart
(quoted diff) +2
-0+comment "mosh needs a host architecture of x64 or x86" + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
Why ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v4 1/1 mosh: new package
Hi Thomas,
Quoted 5 lines · Thomas Petazzoni
Review
Quoted 2 lines · Christian Stewart
(quoted diff) +2
-0+comment "mosh needs a host architecture of x64 or x86" + depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"Why ?
Copied from protobuf dependencies.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -