Skip to contentSkip to conversation

mosh: new package

PATCH Superseded Christian Stewart 2 participants 4 messages Jul 25, 2015

v6 of 8 Superseded Latest is v8 →

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 mosh: new package

Adding mosh, the mobile shell. Mosh uses ssh or dropbear as an initial transport to start mosh-server which uses UDP to communicate with the client. Supports a predictive model to enhance performance on weak connections and compensate for general lag. Also supports disconnections and reconnections seamlessly.

---

[All:
- Fixed licensing issues
- Fixed dependencies
- Added note about upstream logging rejection]

 package/Config.in                                  |  1 +
 package/mosh/0001-remove-system-locale-calls.patch | 46 ++++++++++++++++++++++
 package/mosh/Config.in                             | 23 +++++++++++
 package/mosh/mosh.hash                             |  1 +
 package/mosh/mosh.mk                               | 13 ++++++
 5 files changed, 84 insertions(+)
 create mode 100644 package/mosh/0001-remove-system-locale-calls.patch
 create mode 100644 package/mosh/Config.in
 create mode 100644 package/mosh/mosh.hash
 create mode 100644 package/mosh/mosh.mk
package/Config.in +1 -0
index cfa7512..d1e6640 100644
@@ -1250,6 +1250,7 @@ endif
 	source "package/mongoose/Config.in"
 	source "package/mongrel2/Config.in"
 	source "package/monkey/Config.in"
+	source "package/mosh/Config.in"
 	source "package/mosquitto/Config.in"
 	source "package/mrouted/Config.in"
 	source "package/mtr/Config.in"
package/mosh/0001-remove-system-locale-calls.patch new file +46 -0

46 lines not on this page · raw message

package/mosh/Config.in new file +23 -0
new file mode 100644
index 0000000..632a190
@@ -0,0 +1,23 @@
+comment "mosh needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "mosh needs a host architecture of x64 or x86"
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64
+	depends on !(BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86")
+
+config BR2_PACKAGE_MOSH
+	bool "mosh"
+	depends on BR2_arm || BR2_i386 || BR2_mipsel || BR2_x86_64 # protobuf
+	depends on BR2_TOOLCHAIN_HAS_THREADS #protobuf
+	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" # protobuf
+	select BR2_PACKAGE_PROTOBUF
+	select BR2_PACKAGE_NCURSES
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_OPENSSH if !BR2_PACKAGE_DROPBEAR_CLIENT
+	select BR2_PACKAGE_ZLIB
+	help
+	  Remote terminal application that supports intermittent connectivity,
+	  allows roaming, and provides speculative local echo and line editing
+	  of user keystrokes.
+
+	  https://mosh.mit.edu
package/mosh/mosh.hash new file +1 -0
new file mode 100644
index 0000000..a78cb33
@@ -0,0 +1 @@
+sha256 637adb7f67406447e9264d30468fe69a6d5e8f97518ef133d794cdc65483fa54 mosh-1.2.5.tar.gz
package/mosh/mosh.mk new file +13 -0
new file mode 100644
index 0000000..142e08e
@@ -0,0 +1,13 @@
+################################################################################
+#
+# mosh
+#
+################################################################################
+
+MOSH_VERSION = 1.2.5
+MOSH_SITE = https://mosh.mit.edu/mosh-$(MOSH_VERSION).tar.gz
+MOSH_DEPENDENCIES = zlib ncurses protobuf openssl
+MOSH_LICENSE = GPLv3+ with exception
+MOSH_LICENSE_FILES = COPYING COPYING.iOS
+
+$(eval $(autotools-package))
Signature · 1 line
2.1.4
#1 lore raw

PATCH v6 1/1 mosh: new package

Christian, All,

On 2015-07-25 10:22 -0700, Christian Stewart spake thusly:

Quoted 7 lines

Adding mosh, the mobile shell. Mosh uses ssh or dropbear as an initial transport to start mosh-server which uses UDP to communicate with the client. Supports a predictive model to enhance performance on weak connections and compensate for general lag. Also supports disconnections and reconnections seamlessly.

[--SNIP--]

package/mosh/mosh.hash line 1

Quoted 7 lines
package/mosh/mosh.hash new file +1 -0
new file mode 100644
index 0000000..a78cb33
@@ -0,0 +1 @@
+sha256 637adb7f67406447e9264d30468fe69a6d5e8f97518ef133d794cdc65483fa54 mosh-1.2.5.tar.gz

We usually identify where that hash comes from. Sicne upstream actually did publish that hash, we can refer to it:

    # From: http://mailman.mit.edu/pipermail/mosh-users/2015-July/000283.html
    sha256 637adb7f67406447e9264d30468fe69a6d5e8f97518ef133d794cdc65483fa54 mosh-1.2.5.tar.gz
Quoted 6 lines
package/mosh/mosh.mk new file +0 -0
new file mode 100644
index 0000000..142e08e

package/mosh/mosh.mk line 8

Quoted 8 lines
package/mosh/mosh.mk new file +8 -0
@@ -0,0 +1,13 @@
+################################################################################
+#
+# mosh
+#
+################################################################################
+
+MOSH_VERSION = 1.2.5
+MOSH_SITE = https://mosh.mit.edu/mosh-$(MOSH_VERSION).tar.gz

Eh, how could I miss that on the previous review?

The _SITE variables is just the "directory part" of the URL, like:

MOSH_SITE = https://mosh.mit.edu/

Then Buildroot appends the archive filename to that, and the archive filename can be specified with:

    MOSH_SOURCE = mosh-$(MOSH_VERSION).tar.gz

But since that's the default, there's no need to specify it; so only keep the _SITE variable.

Sorry for asking an Nth iteration... :-/

Regards,
Yann E. MORIN.

Quoted 12 lines
package/mosh/mosh.mk new file +5 -0
+MOSH_DEPENDENCIES = zlib ncurses protobuf openssl
+MOSH_LICENSE = GPLv3+ with exception
+MOSH_LICENSE_FILES = COPYING COPYING.iOS
+
+$(eval $(autotools-package))
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v6 1/1 mosh: new package

In reply to Christian Stewart

Christian, All,

On 2015-07-25 10:22 -0700, Christian Stewart spake thusly:

Quoted 7 lines

Adding mosh, the mobile shell. Mosh uses ssh or dropbear as an initial transport to start mosh-server which uses UDP to communicate with the client. Supports a predictive model to enhance performance on weak connections and compensate for general lag. Also supports disconnections and reconnections seamlessly.

[--SNIP--]

package/mosh/mosh.hash line 1

Quoted 7 lines
package/mosh/mosh.hash new file +1 -0
new file mode 100644
index 0000000..a78cb33
@@ -0,0 +1 @@
+sha256 637adb7f67406447e9264d30468fe69a6d5e8f97518ef133d794cdc65483fa54 mosh-1.2.5.tar.gz

BTEW, this hash is incorrect, when you compare to what was published by upstream. And when I do check here, I get the same hash as publushed, not yours.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH v6 1/1 mosh: new package

All,

The correct hash is:

# From: http://mailman.mit.edu/pipermail/mosh-users/2015-July/000283.html
sha256 1af809e5d747c333a852fbf7acdbf4d354dc4bbc2839e3afe5cf798190074be3 mosh-1.2.5.tar.gz

Oh well. I've respun this so many times in the last couple days I'll wait a bit before sending it again. :)

Christian

Quoted 40 lines · Yann E. MORIN

Christian, All,

On 2015-07-25 10:22 -0700, Christian Stewart spake thusly:

Quoted 1 line

Adding mosh, the mobile shell. Mosh uses ssh or dropbear as an initial

transport to

Quoted 6 lines

start mosh-server which uses UDP to communicate with the client. Supports a predictive model to enhance performance on weak connections and compensate for general lag. Also supports disconnections and reconnections seamlessly.

[--SNIP--]

package/mosh/mosh.hash line 1

Quoted 7 lines
package/mosh/mosh.hash new file +1 -0
new file mode 100644
index 0000000..a78cb33
@@ -0,0 +1 @@
+sha256 637adb7f67406447e9264d30468fe69a6d5e8f97518ef133d794cdc65483fa54

mosh-1.2.5.tar.gz

BTEW, this hash is incorrect, when you compare to what was published by upstream. And when I do check here, I get the same hash as publushed, not yours.

Regards,
Yann E. MORIN.

--

.-----------------.--------------------.------------------.--------------------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
     |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is
no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
 conspiracy.  |
Quoted 2 lines

'------------------------------^-------^------------------^--------------------'

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150725/72f62c0c/attachment.html>