Skip to contentSkip to conversation

drm: Fix DP_TEST_COUNT_MASK

PATCH In review Rodrigo Vivi 3 participants 3 messages Jul 23, 2015 – Jul 27, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/7 drm: Fix DP_TEST_COUNT_MASK

By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].

This mask is wrong since when the counter was introduced by myself on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee

Author: Rodrigo Vivi <[email protected]>
Date:   Tue Sep 16 19:18:12 2014 -0400

drm/i915: Fix Sink CRC

---
 include/drm/drm_dp_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/drm_dp_helper.h +1 -1
index 2e86f64..94898f6 100644
@@ -420,7 +420,7 @@
 
 #define DP_TEST_SINK_MISC		    0x246
 # define DP_TEST_CRC_SUPPORTED		    (1 << 5)
-# define DP_TEST_COUNT_MASK		    0x7
+# define DP_TEST_COUNT_MASK		    0xf
 
 #define DP_TEST_RESPONSE		    0x260
 # define DP_TEST_ACK			    (1 << 0)
Signature · 6 lines
2.1.0

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/7
#1 lore raw
Quoted 27 lines · Rodrigo Vivi

By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].

This mask is wrong since when the counter was introduced by myself on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee

Author: Rodrigo Vivi <[email protected]>
Date:   Tue Sep 16 19:18:12 2014 -0400

drm/i915: Fix Sink CRC

---
  include/drm/drm_dp_helper.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/drm_dp_helper.h +1 -1
index 2e86f64..94898f6 100644
@@ -420,7 +420,7 @@
 
  #define DP_TEST_SINK_MISC		    0x246
  # define DP_TEST_CRC_SUPPORTED		    (1 << 5)
-# define DP_TEST_COUNT_MASK		    0x7
+# define DP_TEST_COUNT_MASK		    0xf
 
  #define DP_TEST_RESPONSE		    0x260
  # define DP_TEST_ACK			    (1 << 0)
Signature · 7 lines
regards,
Sivakumar

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
In reply to Rodrigo Vivi
Quoted 19 lines · Rodrigo Vivi

By Vesa's DP 1.2 Spec this counter has 4 bits [3:0].

This mask is wrong since when the counter was introduced by myself on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee

Author: Rodrigo Vivi <[email protected]>
Date:   Tue Sep 16 19:18:12 2014 -0400

drm/i915: Fix Sink CRC

---
 include/drm/drm_dp_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/drm_dp_helper.h +0 -0
index 2e86f64..94898f6 100644

include/drm/drm_dp_helper.h line 423

Quoted 5 lines
include/drm/drm_dp_helper.h +1 -1
@@ -420,7 +420,7 @@
 
 #define DP_TEST_SINK_MISC		    0x246
 # define DP_TEST_CRC_SUPPORTED		    (1 << 5)
-# define DP_TEST_COUNT_MASK		    0x7
+# define DP_TEST_COUNT_MASK		    0xf

According to the specification this field should really be called DP_TEST_CRC_COUNT_MASK, because it counts the number of times that the TEST_CRC_* registers are updated. That could be a separate patch, though.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel