Skip to contentSkip to conversation

package/rtl8821au: remove debugging patch

PATCH New Christian Stewart 3 participants 5 messages Jul 27, 2015

lore
Share & tools
lore

Christian Stewart

author
#0 lore raw

PATCH 1/1 package/rtl8821au: remove debugging patch

This patch updates rtl8821au to include an upstream commit which disables debug output without a runtime insmod parameter debug=level. This makes the old buildroot patch to remove hardcoded debug defines
unnecessary: as such, it has been removed.

Signed-off-by Christian Stewart <[email protected]>
---
 package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
 package/rtl8821au/rtl8821au.mk                     |  2 +-
 2 files changed, 1 insertion(+), 25 deletions(-)
 delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch
package/rtl8821au/0001-disable-default-debug.patch deleted +0 -24
deleted file mode 100644
index de6fc62..0000000
@@ -1,24 +0,0 @@
-Comment out the hardcoded debug defines. If extra debug is needed, we can add it
-as a define in the make flags.
-
-Signed-off-by: Christian Stewart <[email protected]>
-
-diff --git a/include/autoconf.h b/include/autoconf.h
---- a/include/autoconf.h
-+++ b/include/autoconf.h
-@@ -130,12 +130,12 @@
- /*
-  * Debug Related Config
-  */
--#define DBG	1
-+//#define DBG	1
- 
--#define CONFIG_DEBUG /* DBG_871X, etc... */
-+//#define CONFIG_DEBUG /* DBG_871X, etc... */
- //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_, _func_exit_ */
- 
--#define CONFIG_PROC_DEBUG
-+//#define CONFIG_PROC_DEBUG
- 
- 
- //#define DBG_TX
package/rtl8821au/rtl8821au.mk +1 -1
index d218e3c..eddb18e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
+RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
 RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
 RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
 RTL8821AU_LICENSE_FILES = COPYING
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 1/1 package/rtl8821au: remove debugging patch

All,

I've just tested this version on an Odroid XU3 running ARM with an Edimax USB wifi card. No debugging output without the insmod argument.

Tested-by Christian Stewart <[email protected]>

Best,
Christian

Quoted 60 lines · Christian Stewart

This patch updates rtl8821au to include an upstream commit which disables debug output without a runtime insmod parameter debug=level. This makes the old buildroot patch to remove hardcoded debug defines
unnecessary: as such, it has been removed.

Signed-off-by Christian Stewart <[email protected]>
---
 package/rtl8821au/0001-disable-default-debug.patch | 24
----------------------
 package/rtl8821au/rtl8821au.mk                     |  2 +-
 2 files changed, 1 insertion(+), 25 deletions(-)
 delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch
package/rtl8821au/0001-disable-default-debug.patch deleted +0 -1
deleted file mode 100644
index de6fc62..0000000
@@ -1,24 +0,0 @@
-Comment out the hardcoded debug defines. If extra debug is needed, we can

add it

package/rtl8821au/0001-disable-default-debug.patch deleted +0 -17
-as a define in the make flags.
-
-Signed-off-by: Christian Stewart <[email protected]>
-
-diff --git a/include/autoconf.h b/include/autoconf.h
---- a/include/autoconf.h
-+++ b/include/autoconf.h
-@@ -130,12 +130,12 @@
- /*
-  * Debug Related Config
-  */
--#define DBG   1
-+//#define DBG 1
-
--#define CONFIG_DEBUG /* DBG_871X, etc... */
-+//#define CONFIG_DEBUG /* DBG_871X, etc... */
- //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_,

_func_exit_ */

package/rtl8821au/0001-disable-default-debug.patch deleted +0 -6
-
--#define CONFIG_PROC_DEBUG
-+//#define CONFIG_PROC_DEBUG
-
-
- //#define DBG_TX
package/rtl8821au/ renamed from package/rtl8821au/rtl8821au.mk +0 -0

rtl8821au.mk
index d218e3c..eddb18e 100644

package/rtl8821au/rtl8821au.mk +1 -1
@@ -4,7 +4,7 @@
 #
 
 ################################################################################
 
-RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
+RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
 RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
 RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
Quoted 5 lines

RTL8821AU_LICENSE_FILES = COPYING
--
2.1.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150727/b527b6e5/attachment.html>

#2 lore raw

PATCH 1/1 package/rtl8821au: remove debugging patch

In reply to Christian Stewart

Christian, All,

On 2015-07-27 09:33 -0700, Christian Stewart spake thusly:

Quoted 2 lines

This patch updates rtl8821au to include an upstream commit which disables debug output without a runtime insmod parameter debug=level.

s/without/with/

Quoted 4 lines

This makes the old buildroot patch to remove hardcoded debug defines
unnecessary: as such, it has been removed.

Signed-off-by Christian Stewart <[email protected]>

Otherwise:

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 56 lines
---
 package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
 package/rtl8821au/rtl8821au.mk                     |  2 +-
 2 files changed, 1 insertion(+), 25 deletions(-)
 delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch
package/rtl8821au/0001-disable-default-debug.patch deleted +0 -24
deleted file mode 100644
index de6fc62..0000000
@@ -1,24 +0,0 @@
-Comment out the hardcoded debug defines. If extra debug is needed, we can add it
-as a define in the make flags.
-
-Signed-off-by: Christian Stewart <[email protected]>
-
-diff --git a/include/autoconf.h b/include/autoconf.h
---- a/include/autoconf.h
-+++ b/include/autoconf.h
-@@ -130,12 +130,12 @@
- /*
-  * Debug Related Config
-  */
--#define DBG	1
-+//#define DBG	1
- 
--#define CONFIG_DEBUG /* DBG_871X, etc... */
-+//#define CONFIG_DEBUG /* DBG_871X, etc... */
- //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_, _func_exit_ */
- 
--#define CONFIG_PROC_DEBUG
-+//#define CONFIG_PROC_DEBUG
- 
- 
- //#define DBG_TX
package/rtl8821au/rtl8821au.mk +1 -1
index d218e3c..eddb18e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
+RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
 RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
 RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
 RTL8821AU_LICENSE_FILES = COPYING
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/rtl8821au: remove debugging patch

Christian, All,

On 2015-07-27 19:25 +0200, Yann E. MORIN spake thusly:

Quoted 5 lines

On 2015-07-27 09:33 -0700, Christian Stewart spake thusly:

Quoted 2 lines

This patch updates rtl8821au to include an upstream commit which disables debug output without a runtime insmod parameter debug=level.

s/without/with/

As discussed on IRC, this was nt clear enough, so here's an alternate phrasing:

... an upstream commit which disables debug output, unless a runtime insmod parameter debug=level is passed when loading the module.

Regards,
Yann E. MORIN.

Quoted 80 lines
Quoted 4 lines

This makes the old buildroot patch to remove hardcoded debug defines
unnecessary: as such, it has been removed.

Signed-off-by Christian Stewart <[email protected]>

Otherwise:

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 56 lines
---
 package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
 package/rtl8821au/rtl8821au.mk                     |  2 +-
 2 files changed, 1 insertion(+), 25 deletions(-)
 delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch
package/rtl8821au/0001-disable-default-debug.patch deleted +0 -24
deleted file mode 100644
index de6fc62..0000000
@@ -1,24 +0,0 @@
-Comment out the hardcoded debug defines. If extra debug is needed, we can add it
-as a define in the make flags.
-
-Signed-off-by: Christian Stewart <[email protected]>
-
-diff --git a/include/autoconf.h b/include/autoconf.h
---- a/include/autoconf.h
-+++ b/include/autoconf.h
-@@ -130,12 +130,12 @@
- /*
-  * Debug Related Config
-  */
--#define DBG	1
-+//#define DBG	1
- 
--#define CONFIG_DEBUG /* DBG_871X, etc... */
-+//#define CONFIG_DEBUG /* DBG_871X, etc... */
- //#define CONFIG_DEBUG_RTL871X /* RT_TRACE, RT_PRINT_DATA, _func_enter_, _func_exit_ */
- 
--#define CONFIG_PROC_DEBUG
-+//#define CONFIG_PROC_DEBUG
- 
- 
- //#define DBG_TX
package/rtl8821au/rtl8821au.mk +1 -1
index d218e3c..eddb18e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-RTL8821AU_VERSION = f58e4a7fb27551bdbb4aee9db6086dd6ad996c8d
+RTL8821AU_VERSION = fef8c9d67d076eee9dfb9e19cb7cb69815d5a207
 RTL8821AU_SITE = $(call github,ulli-kroll,rtl8821au,$(RTL8821AU_VERSION))
 RTL8821AU_LICENSE = GPLv2, proprietary (rtl8821au.bin firmware)
 RTL8821AU_LICENSE_FILES = COPYING
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 package/rtl8821au: remove debugging patch

In reply to Christian Stewart

Dear Christian Stewart,

Quoted 11 lines · Christian Stewart

This patch updates rtl8821au to include an upstream commit which disables debug output without a runtime insmod parameter debug=level. This makes the old buildroot patch to remove hardcoded debug defines
unnecessary: as such, it has been removed.

Signed-off-by Christian Stewart <[email protected]>
---
 package/rtl8821au/0001-disable-default-debug.patch | 24 ----------------------
 package/rtl8821au/rtl8821au.mk                     |  2 +-
 2 files changed, 1 insertion(+), 25 deletions(-)
 delete mode 100644 package/rtl8821au/0001-disable-default-debug.patch

I've applied after tweaking the commit log as suggested by Yann, and also changed the commit title to:

package/rtl8821au: bump version and remove debugging patch

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com