Skip to contentSkip to conversation

package/exfat-utils: fix compilation error with musl

PATCH New Brendan Heading 2 participants 4 messages Jul 26, 2015 – Jul 27, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/exfat-utils: fix compilation error with musl

exfat-utils build would not build on Linux unless __GLIBC__ was defined. Patch added to use more relaxed __linux__ instead.

See http://autobuild.buildroot.net/results/c60/c60d0f9a93c90d41c3c86c78b0a0

---
Changes v1 -> v2 :
- removed unnecessary dependency change
- improvements (much simpler patch) as suggested by Thomas P

---
 .../0001-fix-compiling-with-non-glibc-libcs.patch  | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/exfat-utils/0001-fix-compiling-with-non-glibc-libcs.patch
package/exfat-utils/0001-fix-compiling-with-non-glibc-libcs.patch new file +23 -0
new file mode 100644
index 0000000..6244b16
@@ -0,0 +1,23 @@
+[PATCH] fix compilation when libc does not define __GLIBC__
+
+libexfat would only compile on Linux with __GLIBC__ defined. Changed
+to use __linux__ which likely better fits the original intent.
+
+Signed-off-by: Brendan Heading <[email protected]>
+---
+ platform.h |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+Index: libexfat/libexfat/platform.h
+===================================================================
+--- libexfat/libexfat/platform.h	(revision 422)
++++ libexfat/libexfat/platform.h	(working copy)
+@@ -24,7 +24,7 @@
+ #ifndef PLATFORM_H_INCLUDED
+ #define PLATFORM_H_INCLUDED
+ 
+-#if defined(__GLIBC__)
++#if defined(__linux__)
+ 
+ #include <endian.h>
+ #include <byteswap.h>
Signature · 1 line
2.4.3
#1 lore raw

PATCH v2 1/1 package/exfat-utils: fix compilation error with musl

Dear Brendan Heading,

Quoted 11 lines · Brendan Heading

exfat-utils build would not build on Linux unless __GLIBC__ was defined. Patch added to use more relaxed __linux__ instead.

See http://autobuild.buildroot.net/results/c60/c60d0f9a93c90d41c3c86c78b0a0

---
Changes v1 -> v2 :
- removed unnecessary dependency change
- improvements (much simpler patch) as suggested by Thomas P

Applied, thanks. Can you please submit the patch upstream?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 package/exfat-utils: fix compilation error with musl

Quoted 3 lines

Applied, thanks. Can you please submit the patch upstream?

Already done, and accepted by the upstream maintainer. I'll keep an eye out for the next upstream release.

https://groups.google.com/forum/#!topic/exfat/8g3yumqrf1A

regards

Brendan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150727/97ecece9/attachment.html>

#3 lore raw

PATCH v2 1/1 package/exfat-utils: fix compilation error with musl

Brendan,

Quoted 8 lines · Brendan Heading
Quoted 3 lines

Applied, thanks. Can you please submit the patch upstream?

Already done, and accepted by the upstream maintainer. I'll keep an eye out for the next upstream release.

https://groups.google.com/forum/#!topic/exfat/8g3yumqrf1A

Great, thanks!

I've updated the patch to indicate its upstream status:

http://git.buildroot.net/buildroot/commit/?id=efc54fe91ebd849618a15363602b84e53e15037d

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com