usb: gadget: fotg210-udc: remove duplicate conditions

PATCH New Dan Carpenter 1 participant 1 message Jul 29, 2015

Subsystems (2)

USB Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2015-07-29 21:29 UTC #0 lore raw

PATCH 1/1 usb: gadget: fotg210-udc: remove duplicate conditions

We handle the "if (!req->req.length)" condition at the start of the function and return. We can delete this dead code.

Signed-off-by Dan Carpenter <[email protected]>

---
This code doesn't change the current behavior but it's also possible that the current code is buggy. Perhaps we should delete the earlier check?

drivers/usb/gadget/udc/fotg210-udc.c +4 ~~-14~~

index 1137e33..a99ed6d 100644
@@ -384,25 +384,15 @@ static void fotg210_ep0_queue(struct fotg210_ep *ep,
 		return;
 	}
 	if (ep->dir_in) { /* if IN */
-		if (req->req.length) {
-			fotg210_start_dma(ep, req);
-		} else {
-			pr_err("%s : req->req.length = 0x%x\n",
-			       __func__, req->req.length);
-		}
+		fotg210_start_dma(ep, req);
 		if ((req->req.length = req->req.actual) ||
 		    (req->req.actual < ep->ep.maxpacket))
 			fotg210_done(ep, req, 0);
 	} else { /* OUT */
-		if (!req->req.length) {
-			fotg210_done(ep, req, 0);
-		} else {
-			u32 value = ioread32(ep->fotg210->reg +
-						FOTG210_DMISGR0);
+		u32 value = ioread32(ep->fotg210->reg + FOTG210_DMISGR0);
 
-			value &= ~DMISGR0_MCX_OUT_INT;
-			iowrite32(value, ep->fotg210->reg + FOTG210_DMISGR0);
-		}
+		value &= ~DMISGR0_MCX_OUT_INT;
+		iowrite32(value, ep->fotg210->reg + FOTG210_DMISGR0);
 	}
 }